Re: [PATCH v1 09/24] storage: Move generic inotify into storage.c

2012-10-22 Thread Daniel Wagner
On 19.10.2012 21:17, Patrik Flykt wrote: On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de --- include/storage.h | 8 +++ src/config.c | 122 +- src/connman.h | 5 ++ src/main.c

Re: [PATCH v1 09/24] storage: Move generic inotify into storage.c

2012-10-19 Thread Jukka Rissanen
Hi Daniel, this looks nice but there is a small issue when we get the connman-vpn integrated into connman. The connman-vpnd is linking storage.c as it needs some functions from there but it does not need config.c. If we could keep the notify stuff in config, then it would mean smaller

Re: [PATCH v1 09/24] storage: Move generic inotify into storage.c

2012-10-19 Thread Daniel Wagner
Hi Jukka, On 19.10.2012 13:50, Jukka Rissanen wrote: Hi Daniel, this looks nice but there is a small issue when we get the connman-vpn integrated into connman. The connman-vpnd is linking storage.c as it needs some functions from there but it does not need config.c. If we could keep the notify

Re: [PATCH v1 09/24] storage: Move generic inotify into storage.c

2012-10-19 Thread Jukka Rissanen
On 19.10.2012 14:58, Daniel Wagner wrote: Hi Jukka, On 19.10.2012 13:50, Jukka Rissanen wrote: Hi Daniel, this looks nice but there is a small issue when we get the connman-vpn integrated into connman. The connman-vpnd is linking storage.c as it needs some functions from there but it does not

Re: [PATCH v1 09/24] storage: Move generic inotify into storage.c

2012-10-19 Thread Daniel Wagner
On 19.10.2012 14:13, Jukka Rissanen wrote: On 19.10.2012 14:58, Daniel Wagner wrote: Hi Jukka, On 19.10.2012 13:50, Jukka Rissanen wrote: Hi Daniel, this looks nice but there is a small issue when we get the connman-vpn integrated into connman. The connman-vpnd is linking storage.c as it

Re: [PATCH v1 09/24] storage: Move generic inotify into storage.c

2012-10-19 Thread Patrik Flykt
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de --- include/storage.h | 8 +++ src/config.c | 122 +- src/connman.h | 5 ++ src/main.c| 2 + src/storage.c | 155

[PATCH v1 09/24] storage: Move generic inotify into storage.c

2012-10-17 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- include/storage.h | 8 +++ src/config.c | 122 +- src/connman.h | 5 ++ src/main.c| 2 + src/storage.c | 155 ++ 5 files