Re: [ofono-autoconnect RFC 7/9] ofono: retry autoconnect when gprs gets attached

2011-01-18 Thread Pekka Pessi
Hi Marcel, 2011/1/18 Marcel Holtmann : >> +     for (g_hash_table_iter_init(&i, network_hash); >> +          g_hash_table_iter_next(&i, NULL, &value);) { >> +             struct connman_network *network = value; > > don't you think a while loop would look a bit simpler? Well, I can try to squeeze

Re: [ofono-autoconnect RFC 7/9] ofono: retry autoconnect when gprs gets attached

2011-01-18 Thread Marcel Holtmann
Hi Pekka, > diff --git a/plugins/ofono.c b/plugins/ofono.c > index 3a6a9c1..a83602b 100644 > --- a/plugins/ofono.c > +++ b/plugins/ofono.c > @@ -81,6 +81,11 @@ struct modem_data { > gboolean requested_online; > gboolean online; > > + /* org.ofono.ConnectionManager properties */ >

[ofono-autoconnect RFC 7/9] ofono: retry autoconnect when gprs gets attached

2011-01-18 Thread Pekka . Pessi
From: Pekka Pessi --- plugins/ofono.c | 145 +-- 1 files changed, 120 insertions(+), 25 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 3a6a9c1..a83602b 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -81,6 +81,11 @@ s