Re: Re: [PATCH] Set exit value in connmanctl

2015-10-29 Thread Mikko Tuumanen
> > + if (!strncmp("Already ",error,8)) > > + ret = -2; > > + else > > + ret = -1; > > I don't think one can rely on the string here. It's a semi-descriptive > one that may be used for logging or other purposes, but not much else. Yes. A

Re: [PATCH] Set exit value in connmanctl

2015-10-28 Thread Patrik Flykt
Hi, On Tue, 2015-10-27 at 09:58 +0200, Mikko Tuumanen wrote: > --- > client/agent.c| 2 +- > client/commands.c | 27 +-- > client/dbus_helpers.c | 5 +++-- > client/input.c| 6 -- > client/input.h| 2 +- > 5 files changed, 30

Re: [PATCH] Set exit value in connmanctl

2015-10-28 Thread Patrik Flykt
On Tue, 2015-10-27 at 09:58 +0200, Mikko Tuumanen wrote: > --- > client/agent.c| 2 +- > client/commands.c | 27 +-- > client/dbus_helpers.c | 5 +++-- > client/input.c| 6 -- > client/input.h| 2 +- > 5 files changed, 30 insertions(+),