[PATCH dhcpv6-sf v1 06/10] dhcpv6: Renew message implemented.

2011-11-01 Thread Jukka Rissanen
--- gdhcp/client.c | 46 - gdhcp/gdhcp.h |5 ++- src/connman.h |2 + src/dhcpv6.c | 125 +++- src/network.c |2 + 5 files changed, 177 insertions(+), 3 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/clie

[PATCH dhcpv6-sf v1 07/10] dhcpv6: Rebind message implemented.

2011-11-01 Thread Jukka Rissanen
--- gdhcp/client.c | 48 - gdhcp/gdhcp.h |4 ++- src/dhcpv6.c | 107 --- 3 files changed, 150 insertions(+), 9 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index f1ce555..3e6b596 100644 --- a/gdhcp/

[PATCH dhcpv6-sf v1 10/10] dhcpv6: Allow address setting in IPv6 auto mode.

2011-11-01 Thread Jukka Rissanen
The DHCPv6 is used when doing autoconfiguration so we must allow address setting/unsetting in auto mode. --- src/ipconfig.c |6 +++--- src/network.c |4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index cced765..2443735 100644 --- a/

[PATCH dhcpv6-sf v1 00/10] dhcpv6: Support stateful DHCPv6

2011-11-01 Thread Jukka Rissanen
Hi, this patchset adds stateful DHCPv6 support. Cheers, Jukka Jukka Rissanen (10): inet: Return router advertisement packet length in callback. inet: Get router advertisement prefix option information. ipconfig: Return IPv6 privacy status. dhcpv6: Initial stateful DHCPv6 support

[PATCH dhcpv6-sf v1 09/10] dhcpv6: Release message impelemented.

2011-11-01 Thread Jukka Rissanen
--- gdhcp/client.c | 31 gdhcp/gdhcp.h |1 + src/connman.h |2 + src/dhcpv6.c | 61 src/network.c | 17 ++- 5 files changed, 111 insertions(+), 1 deletions(-) diff --git a/gdhcp/cl

[PATCH dhcpv6-sf v1 03/10] ipconfig: Return IPv6 privacy status.

2011-11-01 Thread Jukka Rissanen
--- src/connman.h |1 + src/ipconfig.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index efa38f4..f4059c2 100644 --- a/src/connman.h +++ b/src/connman.h @@ -250,6 +250,7 @@ int __connman_ipconfig_load(struct connman_ipconfig *

[PATCH dhcpv6-sf v1 01/10] inet: Return router advertisement packet length in callback.

2011-11-01 Thread Jukka Rissanen
The length of the RA packet must be returned in callback, otherwise callback cannot check RA options. The prefix length RA option is needed in stateful DHCPv6 implementation. --- src/6to4.c|5 +++-- src/connman.h |2 +- src/inet.c|8 +--- src/network.c |3 ++- 4 files c

[PATCH dhcpv6-sf v1 02/10] inet: Get router advertisement prefix option information.

2011-11-01 Thread Jukka Rissanen
--- src/connman.h |2 ++ src/inet.c| 50 ++ 2 files changed, 52 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 97cd81b..efa38f4 100644 --- a/src/connman.h +++ b/src/connman.h @@ -137,6 +137,8 @@ typedef void

[PATCH dhcpv6-sf v1 04/10] dhcpv6: Initial stateful DHCPv6 support.

2011-11-01 Thread Jukka Rissanen
This patch contains solicitation message support. --- gdhcp/client.c | 419 ++-- gdhcp/common.c | 25 gdhcp/common.h |2 + gdhcp/gdhcp.h | 15 ++ src/connman.h |2 + src/dhcpv6.c | 324 ++

Re: [PATCH 01/10] ipconfig: Use DBG instead of connman_info for debug messages

2011-11-07 Thread Jukka Rissanen
Hi Arron, I would like to say NAK to this patch and the dnsproxy one also. I think we want to get information about these events and not hide them behind debug switch. Your -q option patch would suit perhaps you better if you want to avoid all printing. Cheers, Jukka On 11/07/2011 08:33 AM

Re: [PATCH] network: Call indicate error function in error case

2011-11-15 Thread Jukka Rissanen
Hi Daniel, the patch looks good to me so ACK. On 11/15/2011 11:34 AM, Daniel Wagner wrote: From: Daniel Wagner Setting only one ipconfig type e.g. IPv4 is not enough. service.c:combine_state() will stay in associating state: src/service.c:service_indicate_state() service 0x6b1a60 old associat

[PATCH l2tp/pptp v4 00/19] L2TP/PPTP support

2011-11-15 Thread Jukka Rissanen
Hi, this 4th version contains following changes: - rebase because of changes in upstream code - added support for saving vpn config Cheers, Jukka Jukka Rissanen (13): vpn: Add null checks. l2tp: Add l2tp makefile and configure file. pptp: Add pptp makefile and configure file. scripts

[PATCH l2tp/pptp v4 02/19] vpn: Add null checks.

2011-11-15 Thread Jukka Rissanen
--- plugins/vpn.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/plugins/vpn.c b/plugins/vpn.c index 7d55d81..226fabe 100644 --- a/plugins/vpn.c +++ b/plugins/vpn.c @@ -78,6 +78,9 @@ static int stop_vpn(struct connman_provider *provider)

[PATCH l2tp/pptp v4 01/19] vpn: Add support to allow ppp tunnelling.

2011-11-15 Thread Jukka Rissanen
prepared by Jukka Rissanen and it contains Mohamed Abbas original patch + fixes suggested by Daniel Wagner. Jukka fixed memory leak in vpn_set_ifname(). --- plugins/vpn.c | 122 ++--- plugins/vpn.h |4 ++ 2 files changed, 94 insertions(+), 32

[PATCH l2tp/pptp v4 03/19] task: Allow vpn plugins to send reply.

2011-11-15 Thread Jukka Rissanen
From: Mohamed Abbas Change task notify to allow client to send dbus reply. This will allow vpn plugin to send requested user/password info. --- include/task.h |2 +- plugins/vpn.c |8 +--- src/task.c | 30 +- 3 files changed, 23 insertions(+), 17 de

[PATCH l2tp/pptp v4 04/19] pptp: Add pptp vpn support

2011-11-15 Thread Jukka Rissanen
From: Mohamed Abbas Initial revision. --- plugins/pptp.c | 313 1 files changed, 313 insertions(+), 0 deletions(-) create mode 100644 plugins/pptp.c diff --git a/plugins/pptp.c b/plugins/pptp.c new file mode 100644 index 000..6b2838

[PATCH l2tp/pptp v4 05/19] pptp: Add ppp plugin library.

2011-11-15 Thread Jukka Rissanen
From: Mohamed Abbas pppd will use this library to talk with connman vpn plugin. Original patch comes from Mohamed Abbas. Prepared for inclusion by Jukka Rissanen, also changed the pptp function prefix to ppp as the plugin is used by both pptp and l2tp plugins. --- scripts/libppp-plugin.c

[PATCH l2tp/pptp v4 06/19] l2tp: Add l2tp vpn support.

2011-11-15 Thread Jukka Rissanen
From: Mohamed Abbas Initial revision. --- plugins/l2tp.c | 509 1 files changed, 509 insertions(+), 0 deletions(-) create mode 100644 plugins/l2tp.c diff --git a/plugins/l2tp.c b/plugins/l2tp.c new file mode 100644 index 000..fce890

[PATCH l2tp/pptp v4 07/19] test: Add test script support for pptp/l2tp.

2011-11-15 Thread Jukka Rissanen
From: Mohamed Abbas Modify connect-vpn script to handle pptp/l2tp connection. --- test/connect-vpn | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/test/connect-vpn b/test/connect-vpn index 4e1fc7c..15128c8 100755 --- a/test/connect-vpn +++ b/test/conne

[PATCH l2tp/pptp v4 08/19] l2tp: Add l2tp makefile and configure file.

2011-11-15 Thread Jukka Rissanen
--- Makefile.plugins | 18 ++ configure.ac | 22 ++ 2 files changed, 40 insertions(+), 0 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index bb3a90b..64bd8e7 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -137,6 +137,24 @@ plugi

[PATCH l2tp/pptp v4 09/19] pptp: Add pptp makefile and configure file.

2011-11-15 Thread Jukka Rissanen
--- Makefile.plugins | 19 +++ configure.ac | 22 ++ 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index 64bd8e7..c029111 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -155,6 +155,25 @@ plug

[PATCH l2tp/pptp v4 10/19] scripts: Compile libppp-plugin.so properly.

2011-11-15 Thread Jukka Rissanen
--- Makefile.plugins | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index c029111..58b0494 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -3,6 +3,8 @@ plugin_cflags = -fvisibility=hidden -I$(srcdir)/gdbus \

[PATCH l2tp/pptp v4 12/19] l2tp: Check authentication error properly.

2011-11-15 Thread Jukka Rissanen
--- plugins/l2tp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/l2tp.c b/plugins/l2tp.c index fce8902..78b8e37 100644 --- a/plugins/l2tp.c +++ b/plugins/l2tp.c @@ -158,6 +158,9 @@ static int l2tp_notify(DBusMessage *msg, struct connman_provider *provider)

[PATCH l2tp/pptp v4 11/19] scripts: Report authentication error to connman.

2011-11-15 Thread Jukka Rissanen
The ppp plugin now checks ppp authentication error and report it to correct connman plugin. --- scripts/libppp-plugin.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/scripts/libppp-plugin.c b/scripts/libppp-plugin.c index ba79db0..911551c 100644 --- a/scripts

[PATCH l2tp/pptp v4 13/19] pptp: Return authentication errors properly.

2011-11-15 Thread Jukka Rissanen
--- plugins/pptp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/plugins/pptp.c b/plugins/pptp.c index 6b2838c..814be99 100644 --- a/plugins/pptp.c +++ b/plugins/pptp.c @@ -120,6 +120,9 @@ static int pptp_notify(DBusMessage *msg, struct connman_provider *provider)

[PATCH l2tp/pptp v4 14/19] pptp: Do not put password in command line options.

2011-11-15 Thread Jukka Rissanen
--- plugins/pptp.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/plugins/pptp.c b/plugins/pptp.c index 814be99..f969d1b 100644 --- a/plugins/pptp.c +++ b/plugins/pptp.c @@ -56,7 +56,6 @@ struct { int type; } pptp_options[] = { { "PPTP.User", "user", NULL

[PATCH l2tp/pptp v4 15/19] readme: Add l2tp and pptp information.

2011-11-15 Thread Jukka Rissanen
--- README | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/README b/README index 0cec62b..532e327 100644 --- a/README +++ b/README @@ -41,6 +41,21 @@ To compile and install run: make && make install +VPN +=== + +In order to compile pptp and l2tp

[PATCH l2tp/pptp v4 17/19] todo: Mark l2tp and pptp as done.

2011-11-15 Thread Jukka Rissanen
--- TODO | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/TODO b/TODO index ed2357d..74bbcdc 100644 --- a/TODO +++ b/TODO @@ -137,20 +137,6 @@ Cellular VPN === -- l2tp support - - Priority: Low - Complexity: C2 - Owner: Mohamed Abbas - - -- pptp sup

[PATCH l2tp/pptp v4 16/19] task: Make sure the process is eventually killed.

2011-11-15 Thread Jukka Rissanen
If a task refuses to kill itself, then wait two secs before trying again and if that does not help then forcefully kill it. --- src/task.c | 44 +++- 1 files changed, 43 insertions(+), 1 deletions(-) diff --git a/src/task.c b/src/task.c index d26d617..8be

[PATCH l2tp/pptp v4 19/19] l2tp: Config save support added.

2011-11-15 Thread Jukka Rissanen
--- plugins/l2tp.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/plugins/l2tp.c b/plugins/l2tp.c index 78b8e37..2dd415a 100644 --- a/plugins/l2tp.c +++ b/plugins/l2tp.c @@ -240,6 +240,23 @@ static int l2tp_notify(DBusMessage *msg, struct connman_provid

[PATCH l2tp/pptp v4 18/19] pptp: Config save support added.

2011-11-15 Thread Jukka Rissanen
--- plugins/pptp.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/plugins/pptp.c b/plugins/pptp.c index f969d1b..37e8459 100644 --- a/plugins/pptp.c +++ b/plugins/pptp.c @@ -201,6 +201,23 @@ static int pptp_notify(DBusMessage *msg, struct connman_provid

Re: [PATCH] network: Call indicate error function in error case

2011-11-15 Thread Jukka Rissanen
Hi Daniel, On 11/15/2011 12:49 PM, Daniel Wagner wrote: Hi Jukka, On 15.11.2011 11:27, Jukka Rissanen wrote: At some point we might also need to fix the service.c:combine_state(). Something like this might do the trick (not tested at all): diff --git a/src/service.c b/src/service.c index

Re: [PATCH l2tp/pptp v4 00/19] L2TP/PPTP support

2011-11-16 Thread Jukka Rissanen
Hi Ian, On 11/16/2011 02:29 PM, Ian Geiser wrote: -Original Message- From: connman-boun...@connman.net [mailto:connman-boun...@connman.net] On Behalf Of Jukka Rissanen Sent: Tuesday, November 15, 2011 6:06 AM To: connman@connman.net Subject: [PATCH l2tp/pptp v4 00/19] L2TP/PPTP support

[PATCH 0/2] IPv6 autoconfigured nameservers

2011-11-17 Thread Jukka Rissanen
/show_bug.cgi?id=24196 for more details. Cheers, Jukka Jukka Rissanen (2): resolver: Add notifier support. service: Support automatically inserted nameservers. src/connman.h | 10 + src/resolver.c | 79 src/service.c | 109

[PATCH 1/2] resolver: Add notifier support.

2011-11-17 Thread Jukka Rissanen
--- src/connman.h | 10 +++ src/resolver.c | 79 2 files changed, 89 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 906483a..46c6a61 100644 --- a/src/connman.h +++ b/src/connman.h @@ -145,6 +145,16 @

[PATCH 2/2] service: Support automatically inserted nameservers.

2011-11-17 Thread Jukka Rissanen
IPv6 autoconfigured nameservers can be added to resolver via netlink messages in rtnl.c. Because of this they are not seen in service object so we need to get those auto added nameserver to be notified in service.c so that service can show them to user if necessary. Fixes BMC#24196 --- src/servic

Re: [PATCH]Bearer Hash Implementation for sessions

2011-11-21 Thread Jukka Rissanen
Hi Daniel, On 11/21/2011 02:19 PM, Daniel Wagner wrote: Hi Tomasz, On 21.11.2011 12:52, Tomasz Bursztyka wrote: Hi, + /* + placeholder for the delay and passing + the info to remaining session after a +

[PATCH] service: Support automatically added nameservers.

2011-11-21 Thread Jukka Rissanen
IPv6 autoconfigured nameservers can be added to resolver via netlink messages in rtnl.c. Because of this they are not seen in service object so we need to get those auto added nameserver to be added in service.c so that service can show them to user if necessary. Fixes BMC#24196 --- Hi, this is

valgrind suppression file

2011-11-21 Thread Jukka Rissanen
Hi Daniel, here is the latest valgrind suppression file that I am using. After looking through it more carefully there is nothing about ns_resolv, most of the suppressions seem to be about memory leaks in system libraries. Cheers, Jukka { Memcheck:Cond obj:/lib/libc-*.so ...

[PATCH] dnsproxy: One extra garbage byte was sent at the end of the message.

2011-11-22 Thread Jukka Rissanen
Fixes BMC#24253 --- src/dnsproxy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 960207f..ab74618 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -393,7 +393,7 @@ static int ns_resolv(struct server_data *server, struct request_

[PATCH 1/3] dnsproxy: One extra garbage byte was sent at the end of the message.

2011-11-23 Thread Jukka Rissanen
Fixes BMC#24253 --- src/dnsproxy.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 960207f..1d7a215 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -387,13 +387,13 @@ static int ns_resolv(struct server_data *server, struct requ

[PATCH 0/3] dnsproxy fixes

2011-11-23 Thread Jukka Rissanen
). Cheers, Jukka Jukka Rissanen (3): dnsproxy: One extra garbage byte was sent at the end of the message. dnsproxy: Get rid of extra strlen() calls. dnsproxy: Do not copy two extra bytes if using TCP src/dnsproxy.c | 25 ++--- 1 files changed, 14 insertions(+), 11

[PATCH 3/3] dnsproxy: Do not copy two extra bytes if using TCP

2011-11-23 Thread Jukka Rissanen
--- src/dnsproxy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 24aad91..21512c6 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -387,7 +387,7 @@ static int ns_resolv(struct server_data *server, struct request_data *req,

[PATCH 2/3] dnsproxy: Get rid of extra strlen() calls.

2011-11-23 Thread Jukka Rissanen
--- src/dnsproxy.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 1d7a215..24aad91 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -279,6 +279,7 @@ static int append_query(unsigned char *buf, unsigned int size,

[PATCH] service: Support automatically added nameservers.

2011-11-23 Thread Jukka Rissanen
IPv6 autoconfigured nameservers can be added to resolver via netlink messages in rtnl.c. Because of this they are not seen in service object so we need to get those auto added nameserver to be added in service.c so that service can show them to user if necessary. Fixes BMC#24196 --- Hi, this is t

Re: [PATCH 2/2] service: recompute which service might be online

2011-11-24 Thread Jukka Rissanen
Hi Tomasz, some comments below On 11/24/2011 02:41 PM, Tomasz Bursztyka wrote: When a service gets online or it will need to know wether or not it supersedes a previous service which might be already online. Same when it disconnects, it will need to know whether a previous service might go back

Re: [PATCH v1 02/12] meego: Use system timeserver APIs to add/remove timeservers.

2011-11-24 Thread Jukka Rissanen
Hi Alok, On 11/24/2011 03:28 PM, Alok Barsode wrote: From: Alok Barsode --- plugins/meego.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/meego.c b/plugins/meego.c index 717b220..f8d2f0f 100644 --- a/plugins/meego.c +++ b/plugins/meego.c @@ -31,12 +31,12

Re: [PATCH] inotify: Change inotify mask.

2011-11-24 Thread Jukka Rissanen
Hi Alok, On 11/24/2011 03:31 PM, Alok Barsode wrote: From: Alok Barsode Use IN_CLOSE_WRITE instead of IN_MODIFY so the notifier is called once only after all the changes are written. Fixes BCM#23741. Typo here, should be BMC. Same thing also in other patches. Cheers, Jukka

Re: [PATCH v1 06/12] Add __connman_timerserver_sync() to resolve a list of timeservers.

2011-11-24 Thread Jukka Rissanen
Hi Alok, On 11/24/2011 03:28 PM, Alok Barsode wrote: From: Alok Barsode __connman_timerserver_sync() resolves system timeservers one at a time and queries the resolved server or the 1st of the resolved servers for time correction. If the resolution fails it resolves the next one. __connman_tim

[PATCH] ipconfig: Remove ipconfig from ipconfig_list

2011-11-25 Thread Jukka Rissanen
It is possible that ipdevice does not contain ipconfig for some reason. If that happens, then ipconfig is not removed from ipconfig_list which will then escalate into freed memory access when interface is taken down. The problem was seen with valgrind when tethering was enabled and then disabled fo

[PATCH] wifi: Add debugging in order to find memory problems.

2011-11-25 Thread Jukka Rissanen
--- Hi, this is small issue but helpfull when trying to find out problems. Jukka plugins/wifi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index f7f5216..2fe1479 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -179,7 +179,7 @@

[PATCH] wifi: The remove interface callback used stale pointer.

2011-11-25 Thread Jukka Rissanen
When a wlan interface is removed we call proper method in supplicant dbus interface. As the return message from supplicant might come very late, we must not use the wifi pointer as user data in interface remove callback. This is because the wifi pointer might be removed before the answer comes from

[PATCH] tethering: Avoid removing dhcp server twice.

2011-11-25 Thread Jukka Rissanen
The tethering_dhcp_server pointer needs to be cleared as otherwise the __connman_tethering_cleanup() will call it again. --- src/tethering.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/tethering.c b/src/tethering.c index 8d6532b..0164695 100644 --- a/src/tethering

[PATCH] service: Refactor timeserver removal function.

2011-12-02 Thread Jukka Rissanen
There is a memory leak in __connman_service_timeserver_remove() so refactoring it to look more like nameserver removal func. --- src/service.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/src/service.c b/src/service.c index 76b9294..82d4652 100644

[PATCH] service: Memory leak in timeservers

2011-12-02 Thread Jukka Rissanen
--- src/service.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 0ab313c..76b9294 100644 --- a/src/service.c +++ b/src/service.c @@ -3510,6 +3510,7 @@ static void service_free(gpointer user_data) g_strfreev(service->nameservers)

[PATCH dns cache v5 0/2] Implement DNS caching

2011-12-08 Thread Jukka Rissanen
Hi, this 5th version is rebased against current head and adds checks so that we do not remove the cache hash too early. Regards, Jukka Jukka Rissanen (2): dnsproxy: Implement A and DNS record caching. TODO: DNS caching TODO |9 - src/dnsproxy.c | 790

[PATCH dns cache v5 1/2] dnsproxy: Implement A and AAAA DNS record caching.

2011-12-08 Thread Jukka Rissanen
--- src/dnsproxy.c | 790 +++- 1 files changed, 781 insertions(+), 9 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 21512c6..f67fe18 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -32,6 +32,7 @@ #include #include #inc

[PATCH dns cache v5 2/2] TODO: DNS caching

2011-12-08 Thread Jukka Rissanen
--- TODO |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 74bbcdc..0f80ca7 100644 --- a/TODO +++ b/TODO @@ -26,15 +26,6 @@ Core See http://www.mail-archive.com/connman@connman.net/msg01653.html -- DNS caching - - Priority: Low - Complex

[PATCH] resolver: Fix memory leak when resolver is stopped.

2011-12-08 Thread Jukka Rissanen
--- Hi, I am resending this patch that has been pending a long time. The resolver memory is not released when using -r connman option (dnsproxy is disabled). Jukka src/resolver.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/src/resolve

[PATCH] doc: valgrind suppression file

2011-12-08 Thread Jukka Rissanen
The suppression file tries to ignore the problems in glib and dbus libraries so that we can concentrate to real problems in connman. --- doc/valgrind.suppressions | 235 + 1 files changed, 235 insertions(+), 0 deletions(-) create mode 100644 doc/valgri

[PATCH dhcpv6-sl v3 0/2] dhcpv6: Support stateless DHCPv6

2011-12-08 Thread Jukka Rissanen
Hi, this version is rebased against head and has the fixes discovered by Patrik. Cheers, Jukka Jukka Rissanen (2): gdhcp: Generic stateless DHCPv6 support. dhcpv6: Support stateless DHCPv6 Makefile.am|2 +- gdhcp/client.c | 537

[PATCH dhcpv6-sl v3 2/2] dhcpv6: Support stateless DHCPv6

2011-12-08 Thread Jukka Rissanen
See relevant parts from these RFCs: RFC 3315 - DHCP for IPv6 RFC 3646 - DNS configuration options for DHCP for IPv6 RFC 3736 - Stateless DHCP service for IPv6 RFC 4075 - SNTP configuration option for DHCPv6 The patch does not support authenticated information messages. --- Makefile.am|2 +

[PATCH dhcpv6-sl v3 1/2] gdhcp: Generic stateless DHCPv6 support.

2011-12-08 Thread Jukka Rissanen
The patch adds support for information-request DHCPv6 message. --- gdhcp/client.c | 503 gdhcp/common.c | 202 ++- gdhcp/common.h | 43 +- gdhcp/gdhcp.h | 24 +++- gdhcp/server.c |2 +- 5 files changed, 734

[PATCH dhcpv6-sf v2 00/10] dhcpv6: Support stateful DHCPv6

2011-12-08 Thread Jukka Rissanen
Hi, this version is rebased against current head. Cheers, Jukka Jukka Rissanen (10): inet: Return router advertisement packet length in callback. inet: Get router advertisement prefix option information. ipconfig: Return IPv6 privacy status. dhcpv6: Initial stateful DHCPv6 support

[PATCH dhcpv6-sf v2 01/10] inet: Return router advertisement packet length in callback.

2011-12-08 Thread Jukka Rissanen
The length of the RA packet must be returned in callback, otherwise callback cannot check RA options. The prefix length RA option is needed in stateful DHCPv6 implementation. --- src/6to4.c|5 +++-- src/connman.h |2 +- src/inet.c|8 +--- src/network.c |3 ++- 4 files c

[PATCH dhcpv6-sf v2 02/10] inet: Get router advertisement prefix option information.

2011-12-08 Thread Jukka Rissanen
--- src/connman.h |2 ++ src/inet.c| 50 ++ 2 files changed, 52 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index a2e9e28..5295a5a 100644 --- a/src/connman.h +++ b/src/connman.h @@ -137,6 +137,8 @@ typedef void

[PATCH dhcpv6-sf v2 03/10] ipconfig: Return IPv6 privacy status.

2011-12-08 Thread Jukka Rissanen
--- src/connman.h |1 + src/ipconfig.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 5295a5a..f86f4ea 100644 --- a/src/connman.h +++ b/src/connman.h @@ -252,6 +252,7 @@ int __connman_ipconfig_load(struct connman_ipconfig *

[PATCH dhcpv6-sf v2 04/10] dhcpv6: Initial stateful DHCPv6 support.

2011-12-08 Thread Jukka Rissanen
This patch contains solicitation message support. --- gdhcp/client.c | 419 ++-- gdhcp/common.c | 25 gdhcp/common.h |2 + gdhcp/gdhcp.h | 15 ++ src/connman.h |2 + src/dhcpv6.c | 322 ++

[PATCH dhcpv6-sf v2 05/10] dhcpv6: Request message implemented.

2011-12-08 Thread Jukka Rissanen
--- gdhcp/client.c | 36 - gdhcp/gdhcp.h |8 src/dhcpv6.c | 123 3 files changed, 166 insertions(+), 1 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index f2dcff7..538cadb 100644 --- a/gdhcp/client

[PATCH dhcpv6-sf v2 06/10] dhcpv6: Renew message implemented.

2011-12-08 Thread Jukka Rissanen
--- gdhcp/client.c | 46 - gdhcp/gdhcp.h |5 ++- src/connman.h |2 + src/dhcpv6.c | 125 +++- src/network.c |2 + 5 files changed, 177 insertions(+), 3 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/clie

[PATCH dhcpv6-sf v2 07/10] dhcpv6: Rebind message implemented.

2011-12-08 Thread Jukka Rissanen
--- gdhcp/client.c | 48 - gdhcp/gdhcp.h |4 ++- src/dhcpv6.c | 107 --- 3 files changed, 150 insertions(+), 9 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index 0a46d48..b85d986 100644 --- a/gdhcp/

[PATCH dhcpv6-sf v2 08/10] dhcpv6: Handle address expiration by restarting the stack.

2011-12-08 Thread Jukka Rissanen
--- gdhcp/client.c | 18 ++- gdhcp/gdhcp.h |4 ++- src/dhcpv6.c | 65 +++ src/network.c | 28 +-- 4 files changed, 100 insertions(+), 15 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c inde

[PATCH dhcpv6-sf v2 09/10] dhcpv6: Release message implemented.

2011-12-08 Thread Jukka Rissanen
--- gdhcp/client.c | 31 +++ gdhcp/gdhcp.h |1 + src/connman.h |2 + src/dhcpv6.c | 64 src/network.c | 17 ++- 5 files changed, 114 insertions(+), 1 deletions(-) diff --git a/gdhcp/cli

[PATCH dhcpv6-sf v2 10/10] dhcpv6: Allow address setting in IPv6 auto mode.

2011-12-08 Thread Jukka Rissanen
The DHCPv6 is used when doing autoconfiguration so we must allow address setting/unsetting in auto mode. --- src/ipconfig.c |6 +++--- src/network.c |4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 76768f0..70f13d2 100644 --- a/

[PATCH] ipconfig: Make IPv6 method AUTO by default

2011-12-09 Thread Jukka Rissanen
This is done so that if the method is not found in settings file, then we enable IPv6 by default. --- src/ipconfig.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index f817699..4a83efb 100644 --- a/src/ipconfig.c +++ b/src/ipcon

[PATCH] dnsproxy: Fix format specifier so that source compiles.

2011-12-20 Thread Jukka Rissanen
--- Hi Samuel, did you forgot to push the print format specifier problem in dnsproxy, currently connman does not compile :) Anyway, here is a patch that fixes the issue. I am sorry about this problem, for some mysterious reason I did not see it when I compiled the sources earlier. Cheers, Jukka

Re: [PATCH 2/3] store: Use technology name Cellular instead 3G

2011-12-22 Thread Jukka Rissanen
Hi Daniel, the patch set looks good to me. I noticed a typo below: On 12/21/2011 06:14 PM, Daniel Wagner wrote: From: Daniel Wagner --- src/storage.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/storage.c b/src/storage.c index 51404c8..1604ecc 100644 -

Re: [PATCH 0/5] [RFC] implement 'unavailable' services and service removal

2011-12-22 Thread Jukka Rissanen
Hi Daniel, On 12/21/2011 10:21 PM, Daniel Mack wrote: Here are some patches that implement the interface for 'unavailable' services I was asking about the other day. The principle is that all services are read from disk upon startup, and a new 'available' flag is set to FALSE. All services are

[PATCH] device: Disconnect service when disabling device

2011-12-29 Thread Jukka Rissanen
We should disconnect service instead of disconnecting network when device is disabled. Otherwise service might still have a pointer to network that is no longer valid. Fixes BMC#24592 --- src/device.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/device.c

Re: [QUESTION] connman 0.78 and wpa_supplicant 0.73 can not work together?

2011-12-30 Thread Jukka Rissanen
Hi, On 12/30/2011 10:58 AM, AireadFan wrote: Hi all, My work environment is Ubuntu 10.04 at first, I run the wpa_supplicant (0.73) with `sudo ./wpa_supplicant -u -d`, then I run connman with `sudo ./connmand -c -n -d. -c option is not needed (it is marked obsolete anyway) results: in con

[PATCH] ipconfig: Address list for duplicates does not need gateway info.

2012-01-03 Thread Jukka Rissanen
The ipdevice address list is only used for detecting duplicate addresses so there is no need to copy the gateway information into the list. The same gateway data was actually used in every list element which is not a correct thing to do as there would be different gateways in IPv4 and IPv6 anyway.

[PATCH 0/3] IPv6 wispr fixes

2012-01-03 Thread Jukka Rissanen
, Jukka Jukka Rissanen (3): ipconfig: Have separate callbacks for route changes. wispr: Retry online check for IPv6 service: Return all system defined nameservers when asked include/ipconfig.h |2 + plugins/pacrunner.c |1 + src/connman.h |2 + src/ipconfig.c |8

[PATCH 1/3] ipconfig: Have separate callbacks for route changes.

2012-01-03 Thread Jukka Rissanen
Route changes should not trigger ip_bound or ip_release callbacks in service.c as that can cause too early transition into IPv6 ready state. The ip_bound (in __connman_ipconfig_newaddr()) and ip_release (in __connman_ipconfig_deladdr()) are enough to trigger a transition in IPv6 state. This also p

[PATCH 2/3] wispr: Retry online check for IPv6

2012-01-03 Thread Jukka Rissanen
Because IPv6 RA messages can come at any point when connection is established, we might do wispr check before possible IPv6 DNS RA is received so in that case wispr check could fail. If wispr check fails for IPv6 we try to do the check once (after waiting one second timeout) in a hope that system i

[PATCH 3/3] service: Return all system defined nameservers when asked

2012-01-03 Thread Jukka Rissanen
The connman_service_get_nameservers() is changed to return all system defined nameservers. This means that the function now returns an allocated array of all nameservers and caller must deallocate the returned array. The change is needed so that we can combine the nameservers that are set by DHCP

[PATCH dhcpv6-sl v4 1/2] gdhcp: Generic stateless DHCPv6 support.

2012-01-05 Thread Jukka Rissanen
The patch adds support for information-request DHCPv6 message. --- gdhcp/client.c | 503 gdhcp/common.c | 202 ++- gdhcp/common.h | 43 +- gdhcp/gdhcp.h | 24 +++- gdhcp/server.c |2 +- 5 files changed, 734

[PATCH dhcpv6-sl v4 0/2] dhcpv6: Support stateless DHCPv6

2012-01-05 Thread Jukka Rissanen
Hi, this version is rebased against current head. Cheers, Jukka Jukka Rissanen (2): gdhcp: Generic stateless DHCPv6 support. dhcpv6: Support stateless DHCPv6 Makefile.am|2 +- gdhcp/client.c | 537 +--- gdhcp/common.c | 202

[PATCH dhcpv6-sl v4 2/2] dhcpv6: Support stateless DHCPv6

2012-01-05 Thread Jukka Rissanen
See relevant parts from these RFCs: RFC 3315 - DHCP for IPv6 RFC 3646 - DNS configuration options for DHCP for IPv6 RFC 3736 - Stateless DHCP service for IPv6 RFC 4075 - SNTP configuration option for DHCPv6 The patch does not support authenticated information messages. --- Makefile.am|2 +

Re: [PATCH] device: Disconnect service when disabling device

2012-01-05 Thread Jukka Rissanen
On 01/05/2012 12:06 PM, Daniel Wagner wrote: Hi Jukka, On Thu, Dec 29, 2011 at 02:50:21PM +0200, Jukka Rissanen wrote: We should disconnect service instead of disconnecting network when device is disabled. Otherwise service might still have a pointer to network that is no longer valid. Fixes

Re: [PATCH dhcpv6-sf v2 00/10] dhcpv6: Support stateful DHCPv6

2012-01-05 Thread Jukka Rissanen
On 01/05/2012 10:55 AM, Daniel Wagner wrote: Hi Jukka, On Thu, Dec 08, 2011 at 04:50:46PM +0200, Jukka Rissanen wrote: this version is rebased against current head. Sorry, for the delay, but it doesn't apply anymore... Could you update it please? cheers, daniel This will apply pro

[PATCH] device: Disconnect service when disabling device

2012-01-05 Thread Jukka Rissanen
We should disconnect service instead of disconnecting network when device is disabled. Otherwise service might still have a pointer to network that is no longer valid. Fixes BMC#24592 --- Hi, this is version 2 of the patch. It changes the service variable name to same as in other functions. Chee

[PATCH dhcpv6-sf v3 00/10] dhcpv6: Support stateful DHCPv6

2012-01-05 Thread Jukka Rissanen
Hi, this version is rebased against current head. I also fixed format specifier in icmpv6_recv() in patch #1 (gcc 4.6 complains about it). Cheers, Jukka Jukka Rissanen (10): inet: Return router advertisement packet length in callback. inet: Get router advertisement prefix option

[PATCH dhcpv6-sf v3 01/10] inet: Return router advertisement packet length in callback.

2012-01-05 Thread Jukka Rissanen
The length of the RA packet must be returned in callback, otherwise callback cannot check RA options. The prefix length RA option is needed in stateful DHCPv6 implementation. --- src/6to4.c|5 +++-- src/connman.h |2 +- src/inet.c|8 +--- src/network.c |3 ++- 4 files c

[PATCH dhcpv6-sf v3 02/10] inet: Get router advertisement prefix option information.

2012-01-05 Thread Jukka Rissanen
--- src/connman.h |2 ++ src/inet.c| 50 ++ 2 files changed, 52 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 7637c0f..d140dbb 100644 --- a/src/connman.h +++ b/src/connman.h @@ -141,6 +141,8 @@ typedef void

[PATCH dhcpv6-sf v3 03/10] ipconfig: Return IPv6 privacy status.

2012-01-05 Thread Jukka Rissanen
--- src/connman.h |1 + src/ipconfig.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index d140dbb..1b57adf 100644 --- a/src/connman.h +++ b/src/connman.h @@ -256,6 +256,7 @@ int __connman_ipconfig_load(struct connman_ipconfig *

[PATCH dhcpv6-sf v3 04/10] dhcpv6: Initial stateful DHCPv6 support.

2012-01-05 Thread Jukka Rissanen
This patch contains solicitation message support. --- gdhcp/client.c | 419 ++-- gdhcp/common.c | 25 gdhcp/common.h |2 + gdhcp/gdhcp.h | 15 ++ src/connman.h |2 + src/dhcpv6.c | 322 ++

[PATCH dhcpv6-sf v3 05/10] dhcpv6: Request message implemented.

2012-01-05 Thread Jukka Rissanen
--- gdhcp/client.c | 36 - gdhcp/gdhcp.h |8 src/dhcpv6.c | 123 3 files changed, 166 insertions(+), 1 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index 425f1cb..a8fedb1 100644 --- a/gdhcp/client

[PATCH dhcpv6-sf v3 06/10] dhcpv6: Renew message implemented.

2012-01-05 Thread Jukka Rissanen
--- gdhcp/client.c | 46 - gdhcp/gdhcp.h |5 ++- src/connman.h |2 + src/dhcpv6.c | 125 +++- src/network.c |2 + 5 files changed, 177 insertions(+), 3 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/clie

[PATCH dhcpv6-sf v3 07/10] dhcpv6: Rebind message implemented.

2012-01-05 Thread Jukka Rissanen
--- gdhcp/client.c | 48 - gdhcp/gdhcp.h |4 ++- src/dhcpv6.c | 107 --- 3 files changed, 150 insertions(+), 9 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index a1f0309..cd428cf 100644 --- a/gdhcp/

[PATCH dhcpv6-sf v3 08/10] dhcpv6: Handle address expiration by restarting the stack.

2012-01-05 Thread Jukka Rissanen
--- gdhcp/client.c | 18 ++- gdhcp/gdhcp.h |4 ++- src/dhcpv6.c | 65 +++ src/network.c | 28 +-- 4 files changed, 100 insertions(+), 15 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c inde

<    1   2   3   4   5   6   7   8   9   10   >