Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] wispr: Prevent a crash when freeing wispr routes
(VAUTRIN Emmanuel (Canal Plus Prestataire))
2. Re: [PATCH] service: Fix autoconnect after rejection
(VAUTRIN Emmanuel (Canal Plus Prestataire))
----------------------------------------------------------------------
Date: Wed, 13 Jan 2021 18:41:35 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: Re: [PATCH] wispr: Prevent a crash when freeing wispr routes
To: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb47944af88e4d470bf6898b2293...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: multipart/alternative; boundary="_000_PR1PR02MB47944A
F88E4D470BF6898B2293A90PR1PR02MB4794eurp_"
--_000_PR1PR02MB47944AF88E4D470BF6898B2293A90PR1PR02MB4794eurp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Hi Daniel,
> The real change is the check here. But I would like to understand why
> we need to check if the pointer is not NULL. This change seems to be a
> workaround. Why do we get in a noise environment this problem. Sounds
> like we have some sort of race going on. Could you eloborate a bit on
> this?
I agree that this patch is useless.
B.R.
Emmanuel
--_000_PR1PR02MB47944AF88E4D470BF6898B2293A90PR1PR02MB4794eurp_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
Hi Daniel,<br>
<br>
> The real change is the check here. But I would like to understand why<=
br>
> we need to check if the pointer is not NULL. This change seems to be a=
<br>
> workaround. Why do we get in a noise environment this problem. Sounds<=
br>
> like we have some sort of race going on. Could you eloborate a bit on<=
br>
> this?<br>
I agree that this patch is useless.<br>
<br>
<br>
B.R.<br>
<br>
Emmanuel<br>
</div>
</body>
</html>
--_000_PR1PR02MB47944AF88E4D470BF6898B2293A90PR1PR02MB4794eurp_--
------------------------------
Date: Wed, 13 Jan 2021 19:00:18 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: Re: [PATCH] service: Fix autoconnect after rejection
To: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb47940094a3b9c5a05051f58f93...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
Hi Daniel,
I have been able to reproduce this issue, in a wifi environment with only 1 AP,
that I turn off during the association step, to set the service in failure
state. ("State": "failure",
"Error": "blocked" or "Error": "connect-failed"). In this case, it stays
blocked in this state.
> IIRC, the reason why we don't have this in ConnMan already, is the
> case, where you want to connect to a network with outdated
> credentials. In this case your account could be blocked. Or at least
> that is what I remember.
I have followed your recommandation, and propose the following patch, fixing it:
-----------------------------------------------------------------------------------------
>From 9df3909aa487eb1f8c8796d82b0ee09adcead36b Mon Sep 17 00:00:00 2001
From: Emmanuel VAUTRIN <emmanuel.vaut...@cpexterne.org>
Date: Wed, 13 Jan 2021 18:19:55 +0100
Subject: [PATCH] service: Fix autoconnection of a service in failure state
Prevents a service to be blocked in failure state, when its
autoconnection fails.
---
src/service.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/service.c b/src/service.c
index 5a582cdf..64ee1f44 100644
--- a/src/service.c
+++ b/src/service.c
@@ -4186,6 +4186,12 @@ static bool auto_connect_service(GList *services,
return autoconnecting;
}
+ if (service->state == CONNMAN_SERVICE_STATE_FAILURE) {
+ /* Back to idle to unblock next autoconnection. */
+ service->state = CONNMAN_SERVICE_STATE_IDLE;
+ continue;
+ }
+
if (is_ignore(service) || service->state !=
CONNMAN_SERVICE_STATE_IDLE)
continue;
--
2.25.1
-----------------------------------------------------------------------------------------
B.R.
Emmanuel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- connman@lists.01.org
To unsubscribe send an email to connman-le...@lists.01.org
------------------------------
End of connman Digest, Vol 63, Issue 3
**************************************
