Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. RE: [PATCH] timeserver: Reset synchro on system timeserver update
(VAUTRIN Emmanuel (Canal Plus Prestataire))
2. RE: [PATCH] timeserver: Fix time update manual->auto at startup
(VAUTRIN Emmanuel (Canal Plus Prestataire))
3. RE: [PATCH] timeserver: Fix time update manual->auto at startup
(VAUTRIN Emmanuel (Canal Plus Prestataire))
----------------------------------------------------------------------
Date: Wed, 3 Feb 2021 13:04:11 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] timeserver: Reset synchro on system timeserver
update
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <db7pr02mb4791101e888593db168ff77793...@db7pr02mb4791.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
It is necessary to reset time synchronization when system timeserver
configuration is updated, moreover when it is not available via current
service (no timeserver, no responses...).
---
src/timeserver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/timeserver.c b/src/timeserver.c
index d82fb42d..678d11c9 100644
--- a/src/timeserver.c
+++ b/src/timeserver.c
@@ -506,7 +506,7 @@ int __connman_timeserver_system_set(char **servers)
save_timeservers(servers);
service = connman_service_get_default();
- __connman_timeserver_conf_update(service);
+ ts_reset(service);
return 0;
}
--
2.25.1
------------------------------
Date: Wed, 3 Feb 2021 15:36:42 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] timeserver: Fix time update manual->auto at
startup
To: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <db7pr02mb4791c52d82216b434e4e155d93...@db7pr02mb4791.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
When resetting the time synchronization, always set the associated
service, even when the timeserver list is empty, to enable future
synchronization, when switching time update from manual to auto.
---
src/timeserver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/timeserver.c b/src/timeserver.c
index 678d11c9..2c6c8dd4 100644
--- a/src/timeserver.c
+++ b/src/timeserver.c
@@ -386,6 +386,8 @@ static void ts_reset(struct connman_service *service)
__connman_service_timeserver_changed(service, timeservers_list);
+ ts_service = service;
+
if (!timeservers_list) {
DBG("No timeservers set.");
return;
@@ -393,7 +395,6 @@ static void ts_reset(struct connman_service *service)
ts_recheck_enable();
- ts_service = service;
timeserver_sync_start();
}
--
2.25.1
------------------------------
Date: Wed, 3 Feb 2021 17:05:08 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] timeserver: Fix time update manual->auto at
startup
To: KeithG <ys3al...@gmail.com>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <db7pr02mb4791a43522bf88d18dcae88693...@db7pr02mb4791.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
Hi Keith,
> As a clarification, is this set of patches to 'fix' the systemd-timesyncd
> problem where when a device is booted, it may not know what time it is and
> then > stops any communication because the DNSSEC time stamps do not match
> between it and the DNS server?
I have no idea about the systemd-timesyncd problem, but, this set (3 patches I
have sent today on the subject time synchronization) is effectively to fix
some corner cases and improve time synchronization. We add some workarounds in
higher layers to ensure time synchronization, the goal was to remove them and
rely only on ConnMan.
According to your explanation, if there is a relevant default timestamp
(/etc/timestamp) in the rootfs, you can encounter this mismatch with DNS server
when no time synchronization is applied. So, maybe it solves your problem. The
best will be to check when integrated. If it is not the case, what is the
device time (default /etc/timestamp) in your case and the clock properties
(with the TimeserverSynced new property) when booting?
Best Regards,
Emmanuel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- connman@lists.01.org
To unsubscribe send an email to connman-le...@lists.01.org
------------------------------
End of connman Digest, Vol 64, Issue 3
**************************************
