Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH 1/3] dhcp: Cleanup of VendorClassID config option
(Daniel Wagner)
2. Re: [PATCH 2/3] wispr: Add online check url config options
(Daniel Wagner)
3. Re: [PATCH 3/3] wispr: Support of common redirection status codes
(Daniel Wagner)
----------------------------------------------------------------------
Date: Wed, 5 May 2021 08:38:44 +0200
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH 1/3] dhcp: Cleanup of VendorClassID config option
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <20210505063844.xegdvm2xvolis...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
Hi Emmanual,
Okay, I think I get your idea to streamline the naming for the
function. So, could you please just rename connman_option_get_string()
to connman_setting_get_string() and update the two call sites. And
please add a commit message why you are doing it.
Thanks,
Daniel
------------------------------
Date: Wed, 5 May 2021 08:53:53 +0200
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH 2/3] wispr: Add online check url config options
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <20210505065353.3gvkcnhkzjgxo...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
Hi Emmanuel,
On Wed, Apr 28, 2021 at 07:41:29AM +0000, VAUTRIN Emmanuel (Canal Plus
Prestataire) wrote:
> Global config options, which allow to set the urls (IPv4 and IPv6
> respectively) used during the online status check.
> WARNING: The server shall respond with 200 status code and
> X-ConnMan-Status: online header.
> Default values are http://ipv4.connman.net/online/status.html and
> http://ipv6.connman.net/online/status.html respectively.
> ---
> doc/connman.conf.5.in | 7 +++++++
> src/main.c | 33 +++++++++++++++++++++++++++++++++
> src/main.conf | 8 ++++++++
> src/wispr.c | 14 +++++++++-----
> 4 files changed, 57 insertions(+), 5 deletions(-)
>
> diff --git a/doc/connman.conf.5.in b/doc/connman.conf.5.in
> index 2e06b3ef1f3c..499e019f15a6 100644
> --- a/doc/connman.conf.5.in
> +++ b/doc/connman.conf.5.in
> @@ -167,6 +167,13 @@ transitioned to ONLINE state.
> If this setting is false, the default service will remain in READY state.
> Default value is true.
> .TP
> +.BI OnlineCheckIpv4Url= url, OnlineCheckIpv6Url= url
As IPv4, IPv6 and URL are known abbreviations I would prefer to have
OnlineCheckIPv4URL and OnlineCheckIPv6URL as variable names. At least I
can read it better. And we have already VendorClassID which has this
pattern.
> +Urls (IPv4 and IPv6 respectively) used during the online status check.
> +WARNING: The server shall respond with 200 status code and
> +X-ConnMan-Status: online header.
Instead adding notes into the conf file, please extend the documentation
on the expected protocol between ConnMan and the web server. There is a
section in the README file. I suggest to move this part into new
document in the doc directory and extend it if necessary. And then here
you just point to the documentation.
And if you are going down the road are you going to share your server
setup? These days I suspect it would be something with kubernetes :)
Thanks,
Daniel
------------------------------
Date: Wed, 5 May 2021 08:54:40 +0200
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH 3/3] wispr: Support of common redirection status
codes
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <20210505065440.5npacgms6up4d...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
Hi Emmanuel,
On Wed, Apr 28, 2021 at 07:42:09AM +0000, VAUTRIN Emmanuel (Canal Plus
Prestataire) wrote:
> The portal web result processing shall support common redirection
> status codes, not only 302.
Patch applied.
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- connman@lists.01.org
To unsubscribe send an email to connman-le...@lists.01.org
------------------------------
End of connman Digest, Vol 67, Issue 1
**************************************
