Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. RE: [PATCH 2/2] wispr: Update service state on connection loss
(VAUTRIN Emmanuel (Canal Plus Prestataire))
2. RE: [PATCH] service: Restart online chek after connection loss
(VAUTRIN Emmanuel (Canal Plus Prestataire))
3. Re: [PATCH] service: Restart online chek after connection loss
(Daniel Wagner)
4. RE: [PATCH] service: Restart online chek after connection loss
(VAUTRIN Emmanuel (Canal Plus Prestataire))
----------------------------------------------------------------------
Date: Fri, 5 Feb 2021 09:55:32 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH 2/2] wispr: Update service state on connection
loss
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb4794b2f124d02efe6efe84f593...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
Daniel,
> Okay, this is unfortunately a touchy topic. So we forgot to add the
> state transition from Online to Ready in ('Service states' in
> doc/overview-api.txt). You are not the first who wants to have this
> added but we have users who do not want the API to change as it might
> result in a lot of troubles in their UI as it does not expect this
> transition. Also ConnMan might not be able to handle it correctly:
> I am not against such a feature but it really needs to opt-in and it
> needs a lot of testing.
I totally agree.
By our side, on set-top-boxes, it is the contrary, we need to detect this
transition
quickly to propose a reactive solution, for a better end-user experience.
Of course, it is a touchy subject and ConnMan architecture was not designed to
support this case. So the situation is the following:
By our side, we will keep using this patch, and if you think you may integrate
it in the future,
I can modify it following your recommendations, the first one will probably be
to add
a configuration option, disabled by default, to activate this feature, as it
was done in the
other patch proposal ("Propose patch for perpetual online check for connected
services").
B.R.
Emmanuel
------------------------------
Date: Fri, 5 Feb 2021 10:18:52 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] service: Restart online chek after connection
loss
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb479415ddb9ea873ef8a2c75093...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
Daniel,
> default_changed() is the wrong place for such code.
>
> WISPr should be restarted when the online check fails, the IP
> configuration changes via D-Bus or a new IP set:
>
> __connman_service_online_check_failed
> redo_wispr_ipv4
> redo_wispr_ipv6
> redo_wispr
> __connman_wispr_start
>
> __connman_service_reset_ipconfig
> address_updated
> start_online_check
>
> service_ip_bound
> address_updated
> start_online_check
>
> So the last call chain should handle the situation you describe.
In fact, as for the other patch proposal, by connection loss, I did not
mean disconnection, but Internet connection loss, offline, which is not
covered already, if I am not wrong.
B.R.
Emmanuel
------------------------------
Date: Fri, 5 Feb 2021 15:03:28 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH] service: Restart online chek after connection
loss
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <20210205140328.wc5anlybwjzu5...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
On Fri, Feb 05, 2021 at 10:18:52AM +0000, VAUTRIN Emmanuel (Canal Plus
Prestataire) wrote:
> > So the last call chain should handle the situation you describe.
> In fact, as for the other patch proposal, by connection loss, I did not
> mean disconnection, but Internet connection loss, offline, which is not
> covered already, if I am not wrong.
I see, so this patches makes only sense together with the 'Update
service state on connection loss' patch.
------------------------------
Date: Fri, 5 Feb 2021 14:48:56 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] service: Restart online chek after connection
loss
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb4794d26304efb55138888bc793...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
> I see, so this patches makes only sense together with the 'Update
> service state on connection loss' patch.
Indeed, it is the same activity, but, this one is still useful with current
state machine, that is why I have separated both patches.
For example:
1. Start with Eth plugged and connect at least one Wifi service
-> Eth online / Wifi ready
2. Unplug Eth
-> Eth disconnected, then idle / Wifi ready
This patch enables the current Wifi service to switch to online.
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- connman@lists.01.org
To unsubscribe send an email to connman-le...@lists.01.org
------------------------------
End of connman Digest, Vol 64, Issue 6
**************************************
