StringBuXXXXX spec cleanup

2008-07-22 Thread Martin Buchholz
Here's a set of cleanup fixes for the spec for our friends StringBuffer and StringBuilder. I don't think they change the spec in a substantive way, but y'all Sun folk might want to submit them to CCC together with the substantive changes. We really need BlenderRevs of these to be able to do a prop

StringBuXXXXX.append(char str[], int offset, int len)

2008-07-22 Thread Martin Buchholz
This is a bug report with fix. StringBuilder, AbstractStringBuilder, and StringBuffer fail to specify IndexOutOfBoundsException for append(char str[], int offset, int len) although other methods in these classes are careful to do so. Here's the fix: diff --git a/src/share/classes/java/lang/Abstr

hg: jdk7/tl/langtools: 3 new changesets

2008-07-22 Thread tim . bell
Changeset: c5965e789eb6 Author:xdono Date: 2008-07-17 11:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c5965e789eb6 Added tag jdk7-b31 for changeset 07c916ecfc71 ! .hgtags Changeset: 74fbb87d5965 Author:tbell Date: 2008-07-18 11:25 -0700 URL: http:/

Re: StringBuilder.append cannot throw IndexOutOfBoundsException

2008-07-22 Thread Martin Buchholz
Iris, Yes, please take care of CCC. Hopefully the process for minor spec changes will be externalized soon. There are other, non-spec improvements to String javadoc to come. It would be nice if someone (or a bot) at Sun could generate BlenderRevs on demand. Thanks, Martin On Tue, Jul 22, 2008

Re: StringBuilder.append cannot throw IndexOutOfBoundsException

2008-07-22 Thread Iris Clark
Hi, Martin. I take it that you're going to need a review, ccc, etc. for this change? If you do, then as the owner of String* I'd be happy to handle it. Let me know. iris Martin Buchholz wrote: This message contains bug report + fix. The spec for StringBuilder.append has an erroneous @thr

Re: StringBuilder.append cannot throw IndexOutOfBoundsException

2008-07-22 Thread Alan Bateman
Martin Buchholz wrote: This message contains bug report + fix. The spec for StringBuilder.append has an erroneous @throws IndexOutOfBoundsException. (StringBuffer.append does not have the same problem) Here's the easy (except for the paperwork) fix: diff --git a/src/share/classes/java/lang/