Re: Review request for 6829503

2009-04-19 Thread David Holmes - Sun Microsystems
Alan, 2. File#deleteOnExit doesn't allow IllegalStateException to be thrown so maybe we should change DeleteOnExit#add to be a no-op if its shutdown hook is running. If an application is attempting to register files to be deleted during shutdown it will always be a timing issue if the file is

Re: Review request for 6829503

2009-04-19 Thread Alan Bateman
David Holmes - Sun Microsystems wrote: : But a runtime exception is better than silent failure when the file will not be deleted. And the exception here is not new. Is this a flaw in the File#deleteOnExit API - because it gives the illusion that it can always succeed when in fact the code req

Re: Review request for 6829503

2009-04-19 Thread Rémi Forax
Martin Buchholz a écrit : ... It seems to me there is an inherent race condition with such a check-then-act sequence, unless there is a mechanism for the application to hold some kind of shutdown hook lock. Martin I don't think so. The idea is just to prevent users to use some methods in a s

Re: Review request for 6829503

2009-04-19 Thread David Holmes - Sun Microsystems
Hi Alan, Alan Bateman said the following on 04/20/09 00:00: As it happens, there was a bug in that code (6526376) that caused NPE to be thrown so jdk7 b10 is the first build where IllegalStateException is possible. Ah I see. Seems to me that 6526376 took the easy fix and ignored the underlyi

hg: jdk7/tl: 2 new changesets

2009-04-19 Thread tim . bell
Changeset: aea0ace7a1e4 Author:xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/aea0ace7a1e4 Added tag jdk7-b54 for changeset 2ef382b1bbd5 ! .hgtags Changeset: ba12117a5e6c Author:xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.openjd

hg: jdk7/tl/corba: 2 new changesets

2009-04-19 Thread tim . bell
Changeset: 7a869f16ba83 Author:xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/7a869f16ba83 Added tag jdk7-b54 for changeset 8130ac858d67 ! .hgtags Changeset: 553a664b807b Author:xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.

hg: jdk7/tl/hotspot: 36 new changesets

2009-04-19 Thread tim . bell
Changeset: c89f86385056 Author:jrose Date: 2009-03-20 23:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c89f86385056 6814659: separable cleanups and subroutines for 6655638 Summary: preparatory but separable changes for method handles Reviewed-by: kvn, never ! src/cpu

hg: jdk7/tl/jaxp: 2 new changesets

2009-04-19 Thread tim . bell
Changeset: 039945fba683 Author:xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/039945fba683 Added tag jdk7-b54 for changeset 946a9f0c4932 ! .hgtags Changeset: c197c6801271 Author:xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.o

hg: jdk7/tl/jaxws: 3 new changesets

2009-04-19 Thread tim . bell
Changeset: e0eebd978b83 Author:xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/e0eebd978b83 Added tag jdk7-b54 for changeset 50ea00dc5f14 ! .hgtags Changeset: 0f7fbf85f7a1 Author:xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.

hg: jdk7/tl/langtools: 6 new changesets

2009-04-19 Thread tim . bell
Changeset: 2734c6a91b8b Author:xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2734c6a91b8b Added tag jdk7-b54 for changeset 197a7f881937 ! .hgtags Changeset: 143956db282e Author:tbell Date: 2009-04-10 15:31 -0700 URL: http:/

Re: Review request 6830721

2009-04-19 Thread Xueming Shen
looks fine. Alan Bateman wrote: 6830721: (fc) test/java/nio/channels/AsynchronousFileChannel/Basic.java intermittent failure Sherman - this is another intermittent failure of this test. The cancel sub-test isn't correctly handling the case that the write completes before it is cancelled. It