hg: jdk7/tl/corba: 6372405: Server thread hangs when fragments don't complete because of connection abort; ...

2009-04-20 Thread tim . bell
Changeset: 4906dae0c5fa Author:tbell Date: 2009-04-20 00:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/4906dae0c5fa 6372405: Server thread hangs when fragments don't complete because of connection abort 5104239: Java: thread deadlock 6191561: JCK15: api/org_omg/Portab

hg: jdk7/tl/jdk: 6830721: (fc) test/java/nio/channels/AsynchronousFileChannel/Basic.java intermittent failure

2009-04-20 Thread alan . bateman
Changeset: ccd08d4b19cf Author:alanb Date: 2009-04-20 09:30 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ccd08d4b19cf 6830721: (fc) test/java/nio/channels/AsynchronousFileChannel/Basic.java intermittent failure Reviewed-by: sherman ! test/java/nio/channels/AsynchronousFil

Re: Review request for 6829503

2009-04-20 Thread Alan Bateman
David Holmes - Sun Microsystems wrote: Hi Alan, Alan Bateman said the following on 04/20/09 00:00: As it happens, there was a bug in that code (6526376) that caused NPE to be thrown so jdk7 b10 is the first build where IllegalStateException is possible. Ah I see. Seems to me that 6526376 too

Re: Review request 6831461

2009-04-20 Thread Christopher Hegarty - Sun Microsystems Ireland
Looks fine. -Chris. On 04/17/09 15:52, Alan Bateman wrote: 6831461: (sample) Copy -r fails with IllegalArgumentexception: 'maxDepth' is negative Sherman - this is bug in the Copy sample code that one of the tech writers ran into. For the -r option the sample code is calling walkFileTree wit

hg: jdk7/tl/jdk: 6831461: (sample) Copy -r fails with IllegalArgumentexception: 'maxDepth' is negative

2009-04-20 Thread alan . bateman
Changeset: e281812be4ce Author:alanb Date: 2009-04-20 13:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e281812be4ce 6831461: (sample) Copy -r fails with IllegalArgumentexception: 'maxDepth' is negative Reviewed-by: chegar ! src/share/sample/nio/file/Copy.java

BigInteger and MutableBigInteger should use Integer bit-twiddling methods

2009-04-20 Thread Christian Thalinger
Hi! Could someone take care about CR 6832035? -- Christian

Re: Review request for 6829503

2009-04-20 Thread Mandy Chung
Alan, Thanks for the review and comments. Here is the revised webrev incorporating your comments. See below for my inlined reply. http://cr.openjdk.java.net/~mchung/6829503/webrev.01/ Alan Bateman wrote: Good work! It mostly looks good to me and I've only a few comments: 1. I see that re

REVIEW 6511515: poor performance of LogRecord.inferCaller depending on java.lang.Throwable.getStackTraceElement

2009-04-20 Thread Martin Buchholz
Hi java.util.logging maintainers, Here is a patch to improve the performance of LogRecord.inferCaller. This improves the performance of the microbenchmark in 6511515 by 5x. Swamy, please review. Contributed by Jeremy Manson. http://cr.openjdk.java.net/~martin/inferCaller As a followon, it makes

Re: REVIEW 6511515: poor performance of LogRecord.inferCaller depending on java.lang.Throwable.getStackTraceElement

2009-04-20 Thread David Holmes - Sun Microsystems
Hi Martin, Jeremy, I'm assuming inferCaller always expects to find a caller, or at least that would be the common case - yes? If so then this might be a case where it is quicker to forego the getStackTraceDepth() call and simply catch the potential exception if we reach the end. Aside: we re

webrev Re: REVIEW 6511515: poor performance of LogRecord.inferCaller depending on java.lang.Throwable.getStackTraceElement

2009-04-20 Thread Tim Bell
David wrote: Aside: we really must get webrev or something like it available. These simple diffs are really hard to evaluate in isolation. The webrev script we are using for OpenJDK is available to anyone here: http://blogs.sun.com/jcc/resource/webrev I understand that it is easy to send a

hg: jdk7/tl/jdk: 3 new changesets

2009-04-20 Thread martinrb
Changeset: 697bf0cf039b Author:martin Date: 2009-04-20 21:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/697bf0cf039b 6830220: Logging issues due to regression from bug fix 6797480 Reviewed-by: swamyv Contributed-by: jeremyman...@google.com ! src/share/classes/java/util/l

hg: jdk7/tl/jaxp: 2 new changesets

2009-04-20 Thread tim . bell
Changeset: b56d870cb5c8 Author:tbell Date: 2009-04-20 22:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/b56d870cb5c8 6738894: Merge jaxp fixes from 6 update train into OpenJDK 6 and 7 6573268: Four JCK-devtools-6a tests report OOM: Java Heap space since JDK7 b14 Reviewed-

Re: REVIEW 6511515: poor performance of LogRecord.inferCaller depending on java.lang.Throwable.getStackTraceElement

2009-04-20 Thread Martin Buchholz
On Mon, Apr 20, 2009 at 18:39, David Holmes - Sun Microsystems wrote: > Hi Martin, Jeremy, > > I'm assuming inferCaller always expects to find a caller, or at least that > would be the common case - yes? When I was looking at this, I wondered when a caller could not be found. I think it can happe

Re: REVIEW 6511515: poor performance of LogRecord.inferCaller depending on java.lang.Throwable.getStackTraceElement

2009-04-20 Thread Tim Bell
Hi Martin: It would be good for me to generate webrevs. But the webrev tools should support mq out of the box. I want a single supported command that will turn a mq patch into a webrev on cr.openjdk.java.net. Thanks, I am always looking for feedback on the cr.ojn server. That is a worthy goa