Re: Review request for 5049299

> You write "It's all the same "clone" code in the kernel." > and that may be true, but I'm thinking about the glibc wrappers around them. I only made that point in response to your contrasts between "a dedicated vfork syscall number" and "a clone call passed CLONE_VFORK | CLONE_VM | SIGCHLD", for

Re: timsort

2009/6/30 Martin Buchholz : > > > On Tue, Jun 30, 2009 at 09:24, Andrew John Hughes > wrote: >> >> 2009/6/30 Martin Buchholz : >> >> > (There is the deeper governance issue of who gets to make >> > such decisions.  I would like most of such decisions to be made >> > by the "group" of engineers who

Re: Review request for 5049299

On Jun 30, 4:39pm, marti...@google.com (Martin Buchholz) wrote: -- Subject: Re: Review request for 5049299 | In the JDK... | We close all non-relevant file descriptors in the child instead of relying | on | having the FD_CLOEXEC bit set properly for every fd in the parent. | | The technique of c

Re: Review request for 5049299

Roland, You write "It's all the same "clone" code in the kernel." and that may be true, but I'm thinking about the glibc wrappers around them. In particular, it seems to me that vfork and clone(CLONE_VM|CLONE_VFORK) should have similar assembly wrappers around them. But the vfork code uses SAVE_P

posix_spawn should use vfork() in more cases than presently

I just filed glibc bug posix_spawn should use vfork() in more cases than presently http://sources.redhat.com/bugzilla/show_bug.cgi?id=10354 glibc posix_spawn uses vfork() in some cases, fork() in others. Currently it is rather conservative in this regard. For example, if there are any file action

Re: Review request for 5049299

[+libc-alpha] I just filed glibc bug http://sources.redhat.com/bugzilla/show_bug.cgi?id=10353 Methods for deleting all file descriptors greater than given integer In the JDK... We close all non-relevant file descriptors in the child instead of relying on having the FD_CLOEXEC bit set properly for

Re: Faster HashMap implementation

Inspired by the combination of Alex's efforts and ongoing work on concurrent caches, I put together a version of HashMap (called HashMapV2 for now) with a snapshot at http://gee.cs.oswego.edu/dl/wwwtmp/HashMapV2.java (This retains the openjdk GPL header etc.) There are a few remaining things t

Re: timsort

On Tue, Jun 30, 2009 at 11:32, Andrew Haley wrote: > Martin Buchholz wrote: > > > Right. There is a problem when different sets of contributors have > > different objectives for things like compatibility, portability, > > stability, benchmark performance > > > It might be that a significant

Re: timsort

Martin Buchholz wrote: > > > On Tue, Jun 30, 2009 at 09:24, Andrew John Hughes > mailto:gnu_and...@member.fsf.org>> wrote: > > 2009/6/30 Martin Buchholz >: > > > (There is the deeper governance issue of who gets to make > > such decisions. I would l

Re: timsort

Martin Buchholz wrote: : As you suggested, I added the Classpath exception wording to TimSort.java and ComparableTimSort.java. I excised the old mergesort code from Arrays.java. webrev regenerated. Thanks for doing this. Adding all-or-nothing wording would be good to add, perhaps to the cla

Re: timsort

On Tue, Jun 30, 2009 at 10:03, Jason Mehrens wrote: > Martin, > > Regarding this IAE issue, another approach might be given non > null Comparator 'c': > > if(c.getClass().desiredAssertionStatus()) { > throw new AssertionError("."); > } > > Then there is no compatibility problem,no need to a

Re: timsort

On Tue, Jun 30, 2009 at 09:24, Andrew John Hughes wrote: > 2009/6/30 Martin Buchholz : > > > (There is the deeper governance issue of who gets to make > > such decisions. I would like most of such decisions to be made > > by the "group" of engineers who do the work. For > collections/concurrenc

RE: timsort

Martin, Regarding this IAE issue, another approach might be given non null Comparator 'c': if(c.getClass().desiredAssertionStatus()) { throw new AssertionError("."); } Then there is no compatibility problem,no need to add a new switch to the JDK, and the coder gets smacked wi

Re: timsort

2009/6/30 Andrew Haley : > Martin Buchholz wrote: >> Thanks, Alan.  You're a good reviewer. >> >> As you suggested, I added the Classpath exception wording >> to TimSort.java and ComparableTimSort.java. >> >> I excised the old mergesort code from Arrays.java. >> >> webrev regenerated. >> >> Adding

Re: timsort

Martin Buchholz wrote: > Thanks, Alan. You're a good reviewer. > > As you suggested, I added the Classpath exception wording > to TimSort.java and ComparableTimSort.java. > > I excised the old mergesort code from Arrays.java. > > webrev regenerated. > > Adding all-or-nothing wording would be g

Re: timsort

2009/6/30 Martin Buchholz : > Thanks, Alan.  You're a good reviewer. > > As you suggested, I added the Classpath exception wording > to TimSort.java and ComparableTimSort.java. > > I excised the old mergesort code from Arrays.java. > > webrev regenerated. > > Adding all-or-nothing wording would be

Re: timsort

Thanks, Alan. You're a good reviewer. As you suggested, I added the Classpath exception wording to TimSort.java and ComparableTimSort.java. I excised the old mergesort code from Arrays.java. webrev regenerated. Adding all-or-nothing wording would be good to add, perhaps to the class-level java

hg: jdk7/tl/jdk: 2 new changesets

Changeset: b22f9e823be7 Author:alanb Date: 2009-06-30 11:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b22f9e823be7 6843003: Windows Server 2008 R2 system recognition Reviewed-by: ohair, sherman ! src/windows/native/java/lang/java_props_md.c Changeset: d57c10cf07c5 Auth

Re: timsort

Martin Buchholz wrote: Hi sort team! Google would like to contribute a new implementation for sorting of Object arrays, which has much better performance for input that is already partially sorted, based on Tim Peter's sort used in Python. This sort is already being used in the java.util. th

Re: Review request for 5049299

Roland McGrath wrote: But...posix_spawn doesn't give you any way to delete *all* file descriptors and if you try to collect them before spawning, there is a race in a multithreaded program. This is something you should never want to do. There is notoriously no good way to do it on some sy