Re: Code review request for 6857789: (reflect) Create common superclass of reflective exceptions

2009-07-10 Thread Joseph D. Darcy
Martin Buchholz wrote: Thanks for this; I had a chance to use it in the past week, if it had been there. - typo + * Conqstructs a new exception with {...@code null} as its detail I caught this, but neglected to recreate the patch before sending the email. I've spellchecked all the o

Re: Code review request for 6857789: (reflect) Create common superclass of reflective exceptions

2009-07-10 Thread Rémi Forax
Joseph D. Darcy a écrit : Rémi Forax wrote: This request seems dangerous, InvocationTargetException should not be retrofitted because usually its catch block is different from the others. As is, this patch will introduce more burden than it tries to revolve. If needed InvocationTargetException

Re: Code review request for 6857789: (reflect) Create common superclass of reflective exceptions

2009-07-10 Thread Joseph D. Darcy
Jason Mehrens wrote: Joe, Wouldn't LinkageException be a better fit than ReflectiveOperationException? Shorter name and it would mimic the LinkageError inheritance tree introduced in JDK1.0. I.E. LinkageError -> NoClassDefFoundError, LinkageException -> ClassNotFoundException "LinkageExc

Re: Code review request for 6857789: (reflect) Create common superclass of reflective exceptions

2009-07-10 Thread Joseph D. Darcy
Rémi Forax wrote: This request seems dangerous, InvocationTargetException should not be retrofitted because usually its catch block is different from the others. As is, this patch will introduce more burden than it tries to revolve. If needed InvocationTargetException can continue to have a sep

Re: patch to address sun bug 6562614

2009-07-10 Thread Martin Buchholz
On Fri, Jul 10, 2009 at 08:23, Andrew John Hughes wrote: > > Ping! Can we commit this to tl? Getting changes into openjdk is complicated. Different forest maintainers have different rules, at different times. Right now, for tl, once you have a reviewer approval, you can "simply" commit. Your

Re: Code review request for 6857789: (reflect) Create common superclass of reflective exceptions

2009-07-10 Thread Rémi Forax
Jason Mehrens a écrit : Joe, Wouldn't LinkageException be a better fit than ReflectiveOperationException? Shorter name and it would mimic the LinkageError inheritance tree introduced in JDK1.0. I.E. LinkageError -> NoClassDefFoundError, LinkageException -> ClassNotFoundException > This r

Re: patch to address sun bug 6562614

2009-07-10 Thread Andrew John Hughes
2009/7/9 Andrew John Hughes : > 2009/7/9 Jon VanAlten : >> Hi, >> >> I've put up a webrev at >> http://icedtea.classpath.org/~vanaltj/webrevs/tl/patch1/index.html to >> address http://bugs.sun.com/view_bug.do?bug_id=6562614, also referenced on >> Icedtea bugzilla as >> http://icedtea.classpath.

RE: Code review request for 6857789: (reflect) Create common superclass of reflective exceptions

2009-07-10 Thread Jason Mehrens
Joe, Wouldn't LinkageException be a better fit than ReflectiveOperationException? Shorter name and it would mimic the LinkageError inheritance tree introduced in JDK1.0. I.E. LinkageError -> NoClassDefFoundError, LinkageException -> ClassNotFoundException > This request seems dangerou

hg: jdk7/tl/jdk: 6852744: PIT b61: PKI test suite fails because self signed certificates are beingrejected

2009-07-10 Thread xuelei . fan
Changeset: 6f26e2e5f4f3 Author:xuelei Date: 2009-07-10 17:27 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6f26e2e5f4f3 6852744: PIT b61: PKI test suite fails because self signed certificates are beingrejected Summary: make the builder aware of SKID/AKID, break the internal