Re: Review Request for 6879044

2009-09-14 Thread Oleg Sukhodolsky
On Mon, Sep 14, 2009 at 9:19 PM, Mandy Chung wrote: > Oleg Sukhodolsky wrote: >> >> On Mon, Sep 14, 2009 at 5:32 AM, Mandy Chung wrote: >>> >>> 6879044: Eliminate the dependency of logging from the JRE core/awt/swing >>> classes >>> >>> Webrev: >>>  http://cr.openjdk.java.net/~mchung/6879044/webr

hg: jdk7/tl/jdk: 2 new changesets

2009-09-14 Thread daniel . daugherty
Changeset: f0182203084a Author:dcubed Date: 2009-09-14 18:45 -0600 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f0182203084a 6862295: JDWP threadid changes during debugging session (leading to ingored breakpoints) Summary: New test for the above fix. Reviewed-by: tbell + test/c

hg: jdk7/tl/langtools: 6881317: regression: NPE in CloseableURLClassLoader

2009-09-14 Thread jonathan . gibbons
Changeset: f8be8bf150c3 Author:jjg Date: 2009-09-14 17:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f8be8bf150c3 6881317: regression: NPE in CloseableURLClassLoader Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/file/CloseableURLClassLoader.java

Re: Replacement of Quicksort in java.util.Arrays with Dual-Pivot Quicksort: improvements

2009-09-14 Thread Joshua Bloch
Leonid, I don't think Dual Pivot Quicksort for List is necessary or appropriate. Recall that Arrays.sort and Collections.sort are defined to be stable sorts, which Quicksort is not. Also, I just replaced them with TimSort, which gives a very healthy performance boost. I do think it would be an i

hg: jdk7/tl/jdk: 2 new changesets

2009-09-14 Thread mandy . chung
Changeset: c7e469ae3edb Author:mchung Date: 2009-09-14 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c7e469ae3edb 6878481: Add performance counters in the JDK Summary: Added new performance counters in the JDK to track performance metrics Reviewed-by: alanb, dholmes, i

Re: [OpenJDK 2D-Dev] Review Request for 6879044

2009-09-14 Thread Andrew John Hughes
2009/9/14 Mandy Chung : > 6879044: Eliminate the dependency of logging from the JRE core/awt/swing > classes > > Webrev: >  http://cr.openjdk.java.net/~mchung/6879044/webrev.00/ > > Summary: > 1. A new sun.util.logging.PlatformLogger class that will handle the log > messages in a similar way as Log

Re: Replacement of Quicksort in java.util.Arrays with Dual-Pivot Quicksort: improvements

2009-09-14 Thread Leonid Geller
Remarkable performance improvements! The next step to make this "jdk" material is to implement the DPQ using collections and generics. Then offer an API to pass a comparator class or insure the sortable data structure implements comparable interface.

hg: jdk7/tl/jdk: 6842838: 64-bit failure in handling invalid manifest in launcher.

2009-09-14 Thread kevin . walls
Changeset: eb19c5dc52bf Author:kevinw Date: 2009-09-14 20:55 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb19c5dc52bf 6842838: 64-bit failure in handling invalid manifest in launcher. Summary: Don't compare with hard-coded 32-bit -1 when checking zip fields. Reviewed-by: k

Re: Review Request for 6879044

2009-09-14 Thread Mandy Chung
Oleg Sukhodolsky wrote: On Mon, Sep 14, 2009 at 5:32 AM, Mandy Chung wrote: 6879044: Eliminate the dependency of logging from the JRE core/awt/swing classes Webrev: http://cr.openjdk.java.net/~mchung/6879044/webrev.00/ Summary: 1. A new sun.util.logging.PlatformLogger class that will handle

hg: jdk7/tl/jdk: 2 new changesets

2009-09-14 Thread alan . bateman
Changeset: 060c4c7082ef Author:alanb Date: 2009-09-14 15:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/060c4c7082ef 6529758: JVMTI Waiters demo crashes. Double free. Reviewed-by: ohair, tbell ! src/share/demo/jvmti/waiters/Agent.cpp ! src/share/demo/jvmti/waiters/Agent.h

Re: Date precision on Windows

2009-09-14 Thread Osvaldo Doederlein
Windows 7 seems to be better, check my last comente here: http://javafx-jira.kenai.com/browse/JFXC-3357 A+ Osvaldo 2009/9/14 Jeroen Frijters > Andrew Haley wrote: > > Please, someone tell me Windows isn't still using the old 18.2 Hz DOS > > timer for its system clock. No > > Not that i

Re: Review Request for 6879044

2009-09-14 Thread Yuri Nesterenko
Artem Ananiev wrote: Mandy Chung wrote: 6879044: Eliminate the dependency of logging from the JRE core/awt/swing classes ... I have quickly looked through AWT/2D changes and haven't found anything suspicious. A funny typo is noticed in X11 key logging (see XToolkit or XWindow for examples

Re: Review Request for 6879044

2009-09-14 Thread Artem Ananiev
Mandy Chung wrote: 6879044: Eliminate the dependency of logging from the JRE core/awt/swing classes Webrev: http://cr.openjdk.java.net/~mchung/6879044/webrev.00/ Summary: 1. A new sun.util.logging.PlatformLogger class that will handle the log messages in a similar way as Logger but it will

Re: Replacement of Quicksort in java.util.Arrays with Dual-Pivot Quicksort: improvements

2009-09-14 Thread Vladimir Yaroslavskiy
Hi Team, Thank you very much for your feedback and comments! I collect here all hints and tips for improvement of the new algorithm. New version of Quicksort is attached. And now my investigations: 1. [Jon Bentley] > Use the median of 2k+1 elements for pivots. > We can choose a sample of five el

Re: Date precision on Windows

2009-09-14 Thread Alan Bateman
Max (Weijun) Wang wrote: Hi All Recently one of my Kerberos tests always reports "replay detected" error. Turns out the time precision on Windows is quite low. I've written this tiny program. It calls new Date().getTime() as fast as possible and try to see if the output is continuous: clas

RE: Date precision on Windows

2009-09-14 Thread Jeroen Frijters
Andrew Haley wrote: > Please, someone tell me Windows isn't still using the old 18.2 Hz DOS > timer for its system clock. No Not that it is true, but why would that be bad? By default (most) multi core/cpu Windows systems run at a 15 ms timer interrupt interval (10 ms for single cpu/cor

Re: Date precision on Windows

2009-09-14 Thread Andrew Haley
Max (Weijun) Wang wrote: > Recently one of my Kerberos tests always reports "replay detected" > error. Turns out the time precision on Windows is quite low. > > I've written this tiny program. It calls new Date().getTime() as fast as > possible and try to see if the output is continuous: > > cla

Date precision on Windows

2009-09-14 Thread Max (Weijun) Wang
Hi All Recently one of my Kerberos tests always reports "replay detected" error. Turns out the time precision on Windows is quite low. I've written this tiny program. It calls new Date().getTime() as fast as possible and try to see if the output is continuous: class A { public static vo

Re: Review Request for 6879044

2009-09-14 Thread Alan Bateman
Mandy Chung wrote: 6879044: Eliminate the dependency of logging from the JRE core/awt/swing classes Webrev: http://cr.openjdk.java.net/~mchung/6879044/webrev.00/ The approach seems reasonable to me. It is a bit strange to redirect the platform logging to j.u.logging if something up the stack