[+ Brandon]
Sherman,
Here are some review comments on "take1"
Overall, looks good.
This low-level API will be annoying to use,
but that's mostly unavoidable.
typos: @linke sinze
source files contain TABs, no longer permitted
is denigrated in favor of @code
I don't think you
Joe Darcy wrote:
Stephen Colebourne wrote:
Joe Darcy wrote:
What other utility methods would have broad enough use and
applicability to go into a common java.util class?
Joe,
You've asked for a call for ideas, but not given any indication of
process. Are you going to evaluate everything that
Changeset: bbb543254c63
Author:martin
Date: 2009-09-22 18:30 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bbb543254c63
4245470: algorithm of java.lang.Byte.hashCode() is not specified
Summary: Specify some hashCode methods are equivalent to intValue
Reviewed-by: darcy
! sr
Hi Rob,
Rob Leland wrote:
..Mandy,
Three questions.
-import java.util.logging.Logger;
+import sun.util.logging.PlatformLogger;
It seems counter intuitive that a dependency would be change
from a java.* -> sun.* since this the OpenJDK ,why not add it to
java.util.log.* ?
Alan answered this
Changeset: c715b68cdcaf
Author:darcy
Date: 2009-09-22 16:11 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c715b68cdcaf
6468534: (reflect) Exception types cannot be parameterized, rephrase
getGenericExceptionTypes.
Reviewed-by: alanb
! src/share/classes/java/lang/reflect/Co
Thanks Alan!
The webrev has been updated accordingly to address your comments (use
syncFlush instead of
doSyncFlush and those suggestions for Deflater.java).
http://cr.openjdk.java.net/~sherman/zipflush/webrev
Sherman
PS. There was a "take2" for DOS that I think might be more consistent
wi
Joe Darcy wrote:
Hello.
Please review my simple fix below for 6468534 "(reflect) Exception
types cannot be parameterized, rephrase getGenericExceptionTypes."
As documented in the JLS, "It is a compile-time error if a generic
class is a direct or indirect subclass of |Throwable|."
http://ja
Changeset: b8004f6f4812
Author:kevinw
Date: 2009-09-22 17:01 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8004f6f4812
6882768: (launcher) test for 6842838 is broken
Summary: Testcase correction.
Reviewed-by: ksrini
! test/tools/launcher/6842838/Test6842838.sh
Changeset:
It was on JDK 1.6.0_u16 client compiler. Persisting about 2 000 "large"
entities (~45 attributes) and 200 000 entities (~4 attributes) in one
transaction (tuned with: batch writes, cache all statements, batch size = 200,
bind all parameters)
Profiler: JProfiler version 4.2.4
I'm not "JDK" guru
Changeset: 023063a403ed
Author:chegar
Date: 2009-09-22 14:42 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/023063a403ed
6882654: Remove dependency on java.util.concurrent from KeepAlive implementaion
Reviewed-by: michaelm
! src/share/classes/sun/net/www/http/KeepAliveCache.
Tom Hawtin wrote:
> Janda Martin wrote:
>> I would like to ask about any plans of speed improvements to
>> "System.identityHashCode" or "IdentityHashMap"
>>
>> I use EclipseLink and it uses IdentityHashMap for storing entities and their
>> clones.
>>
>> In my case System.identityHashCode consumes
Janda, you could provide a/the patch to force the fix of this bug.
See: http://openjdk.java.net/contribute/
-Ulf
Am 22.09.2009 13:35, Tom Hawtin schrieb:
Janda Martin wrote:
I would like to ask about any plans of speed improvements to
"System.identityHashCode" or "IdentityHashMap"
I use Ecl
Janda Martin wrote:
I would like to ask about any plans of speed improvements to "System.identityHashCode" or
"IdentityHashMap"
I use EclipseLink and it uses IdentityHashMap for storing entities and their
clones.
In my case System.identityHashCode consumes 54% of time during insert data to
d
I would like to ask about any plans of speed improvements to
"System.identityHashCode" or "IdentityHashMap"
I use EclipseLink and it uses IdentityHashMap for storing entities and their
clones.
In my case System.identityHashCode consumes 54% of time during insert data to
database. There are lot
Rob Leland wrote:
..Mandy,
Three questions.
-import java.util.logging.Logger;
+import sun.util.logging.PlatformLogger;
It seems counter intuitive that a dependency would be change
from a java.* -> sun.* since this the OpenJDK ,why not add it to
java.util.log.* ?
This change-set isn't adding
15 matches
Mail list logo
