hg: jdk7/tl/jdk: 6870812: enhance security tools to use ECC algorithms

2009-10-20 Thread weijun . wang
Changeset: 0d7c64c023c6 Author:weijun Date: 2009-10-21 08:17 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d7c64c023c6 6870812: enhance security tools to use ECC algorithms Reviewed-by: vinnie, mullan ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/

Review request for 6878475: Better regex named-group and backreference syntax

2009-10-20 Thread Xueming Shen
Alan, Martin The CCC also approved this change. Would you please help review? There is no doc/impl change in the webrev since you guys reviewed (for CCC) last time. http://cr.openjdk.java.net/~sherman/6878475/webrev Thanks, Sherman Xueming Shen wrote: Hi Guess you might be interested to he

Code review request for 4206909 : adding Z_SYNC_FLUSH support to deflaters

2009-10-20 Thread Xueming Shen
Martin, Alan. Finally got the CCC approval. Here is the final webrev http://cr.openjdk.java.net/~sherman/4206909/webrev The only difference compared to the webrev you guys reviewed last time at http://cr.openjdk.java.net/~sherman/zipflush/webrev is to use the Google copyright in test case In

Code review request for 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent

2009-10-20 Thread Joseph D. Darcy
Hello. Please review this small doc clarification; modPow is not defined for negative exponents unless the BigInteger being operated on is relatively prime to the modulus. There are a few stylistic javadoc cleanups in the patch below too. Webrev: http://cr.openjdk.java.net/~darcy/6560935.0/

hg: jdk7/tl/langtools: 6893062: remove support for obsolete attributes

2009-10-20 Thread jonathan . gibbons
Changeset: a491ad1bb624 Author:jjg Date: 2009-10-20 10:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a491ad1bb624 6893062: remove support for obsolete attributes Reviewed-by: ksrini ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/

Re: Code review request for 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError

2009-10-20 Thread Joseph D. Darcy
Dmitry Nadezhin wrote: I want to make comments to this change from point of view of the post "BigInteger.bitLength() can return negative results". Suppose that the range of valid BigInteger is restiricted either to [-2^Integer.MAX_VALUE , 2^Integer.MAX_VALUE-1] or to [-2^Integer.MAX_VALUE+1, 2^I

Re: Code review request for 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError

2009-10-20 Thread Joseph D. Darcy
Alan Bateman wrote: Joseph D. Darcy wrote: Hello. Please review this simple improvement in handling an exceptional condition in BigInteger. A stack overflow on an argument of BigInteger.shitf{Left, Right}(Integer.MIN_VALUE) is handled as an explicit ArithmeticException, the same exception u

hg: jdk7/tl/jdk: 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError

2009-10-20 Thread joe . darcy
Changeset: 0dd3d16e8183 Author:darcy Date: 2009-10-20 09:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0dd3d16e8183 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError Reviewed-by: alanb ! src/share/classes/java/math/BigInteger.java + test/ja

hg: jdk7/tl/jdk: 6890349: Fix #6870935 in jdk7/pit/b74 caused HttpClinet's check for "proxy capture" attack by-passed.

2009-10-20 Thread michael . mcmahon
Changeset: 052f056f7ba1 Author:michaelm Date: 2009-10-20 15:35 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/052f056f7ba1 6890349: Fix #6870935 in jdk7/pit/b74 caused HttpClinet's check for "proxy capture" attack by-passed. Summary: pass exception up stack Reviewed-by: cheg

Re: Code review request for 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError

2009-10-20 Thread Alan Bateman
Joseph D. Darcy wrote: Hello. Please review this simple improvement in handling an exceptional condition in BigInteger. A stack overflow on an argument of BigInteger.shitf{Left, Right}(Integer.MIN_VALUE) is handled as an explicit ArithmeticException, the same exception used throughout BigIn