Re: Gap Buffer based AbstractStringBuilder implementation

2009-11-25 Thread Martin Buchholz
On Wed, Nov 25, 2009 at 21:24, Martin Buchholz wrote: > On Mon, Nov 23, 2009 at 22:51, Goktug Gokdogan wrote: >> Nobody is interested or everybody is busy? > > I think there's a place for a StringBuilder-like > abstraction that uses a gap buffer, > but it shouldn't replace StringBuilder. Let me

Re: Gap Buffer based AbstractStringBuilder implementation

2009-11-25 Thread Martin Buchholz
On Mon, Nov 23, 2009 at 22:51, Goktug Gokdogan wrote: > Nobody is interested or everybody is busy? I think there's a place for a StringBuilder-like abstraction that uses a gap buffer, but it shouldn't replace StringBuilder. Like ArrayList, users of StringBuilder expect that it is very efficient

Re: Gap Buffer based AbstractStringBuilder implementation

2009-11-25 Thread Goktug Gokdogan
Actually, this code is not related to size change or management, instead it modifies where the builder keeps the gap taking into account the last change position. So I think it is better not to handle these two issues together. On Tue, Nov 24, 2009 at 4:08 AM, Marek KozieĊ‚ wrote: > 2009/11/17 Gok

Fixes to java.util.zip javadoc

2009-11-25 Thread Martin Buchholz
Hi Sherman, Here are some javadoc fixes to recent changes in java.util.zip: http://cr.openjdk.java.net/~martin/webrevs/openjdk7/ziplink/ Please review. Martin

Re: Need reviewer - java.template changes

2009-11-25 Thread Martin Buchholz
The Basic-X.java related changes look good to me. Martin On Wed, Nov 25, 2009 at 14:34, Kelly O'Hair wrote: > Need reviewer. > > 6903197: Some java template files need to be renamed to .java.template > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-6903197/webrev/ > > Changing a few more jav

Need reviewer - java.template changes

2009-11-25 Thread Kelly O'Hair
Need reviewer. 6903197: Some java template files need to be renamed to .java.template http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-6903197/webrev/ Changing a few more java source template filenames: make/tools/CharsetMapping/DoubleByte-X.java.template (was make/tools/CharsetMapping/Doub

hg: jdk7/tl/jdk: 6904183: Fix jdk/test/com/sun/jdi tests to run with -samevm

2009-11-25 Thread kelly . ohair
Changeset: 57195a368d33 Author:ohair Date: 2009-11-25 08:24 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/57195a368d33 6904183: Fix jdk/test/com/sun/jdi tests to run with -samevm Reviewed-by: dcubed ! test/Makefile ! test/ProblemList.txt ! test/com/sun/jdi/BadHandshakeTest.