hg: jdk7/tl/jdk: 3 new changesets

2009-11-26 Thread weijun . wang
Changeset: 7871897537b1 Author:weijun Date: 2009-11-27 08:51 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7871897537b1 6853328: Support OK-AS-DELEGATE flag Reviewed-by: valeriep ! src/share/classes/com/sun/security/jgss/ExtendedGSSContext.java ! src/share/classes/org/ietf/

Re: Need reviewer - java.template changes

2009-11-26 Thread Rémi Forax
Le 26/11/2009 19:18, Kelly O'Hair a écrit : Thanks. I don't quite understand the 'prefer the original' comment, all I'm adding is a .template suffix, the basename is still there, nothing was taken away. In the Makefiles and the ant scripts it makes life so much easier with this .template suf

Re: Need reviewer - java.template changes

2009-11-26 Thread Kelly O'Hair
Thanks. I don't quite understand the 'prefer the original' comment, all I'm adding is a .template suffix, the basename is still there, nothing was taken away. In the Makefiles and the ant scripts it makes life so much easier with this .template suffix. Maybe it's only something a 'build' person

Re: hg: jdk7/tl/jdk: 3 new changesets

2009-11-26 Thread Alan Bateman
Bob Lee wrote: : Should we use an enum for the flush strategies? It would help separate them from the compression strategies, and it would make the new method easier to use because it would be obvious at compile time which values you can pass in (as opposed to allowing any random int). Also

Re: Gap Buffer based AbstractStringBuilder implementation

2009-11-26 Thread Goktug Gokdogan
I think, we can overcome the slowdown. The point of my prototype is to check the general performance characteristics. Slowdown is more likely due to the poorly optimized extra method call to keep all logic in one place. Normally the gap buffer algorithm should add only one comparison overhead to th

Re: Need reviewer - java.template changes

2009-11-26 Thread Alan Bateman
Kelly O'Hair wrote: Need reviewer. 6903197: Some java template files need to be renamed to .java.template http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-6903197/webrev/ Looks okay to me (although I prefer the original names :-). It would be good to send a heads-up to i18n-dev for the chang

Re: Fixes to java.util.zip javadoc

2009-11-26 Thread Alan Bateman
Martin Buchholz wrote: Hi Sherman, Here are some javadoc fixes to recent changes in java.util.zip: http://cr.openjdk.java.net/~martin/webrevs/openjdk7/ziplink/ Please review. Martin Looks good to me. I've created the following to track this: 6905029: Broken links in Deflater and Deflater