core-libs-dev@openjdk.java.net

2009-12-14 Thread Dmitry Nadezhin
> The current specification of the "interesting" methods in StrictMath, such as sin/cos, log, > etc. are to use the FDLIBM algorithms. Thank you. I forgot about these lines in java.lang.StrictMath . * To help ensure portability of Java programs, the definitions of * some of the numeric function

core-libs-dev@openjdk.java.net

2009-12-14 Thread Joseph D. Darcy
Dmitry Nadezhin wrote: Joseph D. Darcy wrote: Yes, porting FDLIBM to Java has been an oft-delayed "nice to have" project of mine. It is not obvious from looking at my ceil/floor code, but it started with the FDLIBM versions of those algorithms. The tests are new and greatly outnumber the cod

core-libs-dev@openjdk.java.net

2009-12-14 Thread Dmitry Nadezhin
Joseph D. Darcy wrote: Yes, porting FDLIBM to Java has been an oft-delayed "nice to have" project of mine. It is not obvious from looking at my ceil/floor code, but it started with the FDLIBM versions of those algorithms. The tests are new and greatly outnumber the code changes, as it typica

core-libs-dev@openjdk.java.net

2009-12-14 Thread Alan Bateman
Joseph D. Darcy wrote: : Webrev so updated: http://cr.openjdk.java.net/~darcy/6908131.1 I'm not an expert on floating point but this implementation looks good to me. The test looks good too. I agree with your previous comment to transition to pure-java implementations in steps - that should hel

core-libs-dev@openjdk.java.net

2009-12-14 Thread Joseph D. Darcy
Alan Bateman wrote: Joseph D. Darcy wrote: Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's numerical experts, to review the floor/ceil al

core-libs-dev@openjdk.java.net

2009-12-14 Thread Christian Thalinger
On Mon, 2009-12-14 at 10:16 -0800, Joseph D. Darcy wrote: > > Not a review, but did you think about implementing the whole FDLIBM in > > Java, as done here: > > > > http://mail.openjdk.java.net/pipermail/hotspot-dev/2009-August/001970.html > > > > Yes, porting FDLIBM to Java has been an oft-del

Re: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present

2009-12-14 Thread Mandy Chung
Alan Bateman wrote: Mandy - what is the existing behavior for when the environment property is null or a non-Applet type? I don't know the COS Naming Service Provider but I assume it will throw CCE if the property value is not an Applet. With the proposed change it looks like it will throw an

core-libs-dev@openjdk.java.net

2009-12-14 Thread Joseph D. Darcy
Christian Thalinger wrote: On Mon, 2009-12-14 at 01:31 -0800, Joseph D. Darcy wrote: Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's nu

Re: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present

2009-12-14 Thread Alan Bateman
Mandy Chung wrote: The JNDI cosnaming provider currently has a static dependency on java.applet.Applet that is only needed in an applet environment. This fix will allow JNDI cosnaming provider to be used when java.applet is not present. Webrev: http://cr.openjdk.java.net/~mchung/6898747/web

core-libs-dev@openjdk.java.net

2009-12-14 Thread Alan Bateman
Joseph D. Darcy wrote: Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's numerical experts, to review the floor/ceil algorithm and testing.

core-libs-dev@openjdk.java.net

2009-12-14 Thread Christian Thalinger
On Mon, 2009-12-14 at 01:31 -0800, Joseph D. Darcy wrote: > Hello. > > Please review my fix for > > 6908131 Pure Java implementations of StrictMath.floor(double) > &StrictMath.ceil(double) > http://cr.openjdk.java.net/~darcy/6908131.0/ > > I've asked Doug Priest, one of Sun's numerical experts,

core-libs-dev@openjdk.java.net

2009-12-14 Thread Joseph D. Darcy
Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's numerical experts, to review the floor/ceil algorithm and testing. I've incorporated his f