Re: Code review request to add @param tags to various classes

2010-02-23 Thread Martin Buchholz
I agree that's it's a pretty good policy to have @params for all type parameters. Approved. Martin On Tue, Feb 23, 2010 at 19:37, Joe Darcy wrote: > Hello. > > Please review the patch below which adds missing "@param " tags to > document type variables in various types. > > -Joe > > --- old/src

Code review request to add @param tags to various classes

2010-02-23 Thread Joe Darcy
Hello. Please review the patch below which adds missing "@param " tags to document type variables in various types. -Joe --- old/src/share/classes/java/lang/Iterable.java2010-02-23 19:00:32.0 -0800 +++ new/src/share/classes/java/lang/Iterable.java2010-02-23 19:00:31.

hg: jdk7/tl/langtools: 6511613: javac unexpectedly doesn't fail in some cases if an annotation processor specified

2010-02-23 Thread jonathan . gibbons
Changeset: 6eca0895a644 Author:jjg Date: 2010-02-23 18:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6eca0895a644 6511613: javac unexpectedly doesn't fail in some cases if an annotation processor specified Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac

hg: jdk7/tl/jdk: 6365587: Proxy-Connection header sent through tunnel

2010-02-23 Thread christopher . hegarty
Changeset: c96d6cb31723 Author:chegar Date: 2010-02-23 17:08 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c96d6cb31723 6365587: Proxy-Connection header sent through tunnel Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java