TEST: java/nio/channels/AsynchronousSocketChannel/Basic.java

2010-03-11 Thread Kelly O'Hair
I'm having problems with this test on Solaris 10 X86 and Fedora 9 32bit. Ring any bells? -kto -- TEST: java/nio/channels/AsynchronousSocketChannel/Basic.java JDK under test: (/tmp/jprt/P1/T/173102.ohair/testproduct/ solaris_i586_5.10-product) ope

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

2010-03-11 Thread Martin Buchholz
On Thu, Mar 11, 2010 at 13:14, Ulf Zibis wrote: > Am 11.03.2010 20:38, schrieb Martin Buchholz: >> >> Ulf, your changes would be easier to get in >> if they were organized as mq patch files that >> could be qimported into an existing mq repo. >> > > To be honest, I never heard about mq. Can you po

hg: jdk7/tl/jdk: 6929479: Add a system property sun.zip.disableMemoryMapping to disable mmap use in ZipFile

2010-03-11 Thread xueming . shen
Changeset: ee385b4e2ffb Author:sherman Date: 2010-03-11 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee385b4e2ffb 6929479: Add a system property sun.zip.disableMemoryMapping to disable mmap use in ZipFile Summary: system property sun.zip.disableMemoryMapping to disab

Re: Codereview needed for #6929479

2010-03-11 Thread Xueming Shen
Alan Bateman wrote: Xueming Shen wrote: Alan, webrev has been updated to use the sun.zip.disableMemoryMapping http://cr.openjdk.java.net/~sherman/6929479/webrev Please review. Thanks, Sherman I agree it's a better name. In ZipFile it would be good to put a comment at the initialization so

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

2010-03-11 Thread Xueming Shen
Martin, Ulf Following bug/rfs have been filed. 6934265 Add public method Character.isBMPCodePoint 6934268 Better implementation of Character.isValidCodePoint and isSupplementaryCodePoint() 6934270: Remove javac warnings from Character.java 6934271: Better handling of longer utf-8 sequences Ma

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

2010-03-11 Thread Ulf Zibis
Am 11.03.2010 20:38, schrieb Martin Buchholz: Ulf, your changes would be easier to get in if they were organized as mq patch files that could be qimported into an existing mq repo. To be honest, I never heard about mq. Can you point me to some docs please? I've done that below, which include

Re: Progress of patches

2010-03-11 Thread Ulf Zibis
Am 11.03.2010 20:56, schrieb Martin Buchholz: Why isn't this true for isSupplementaryCodePoint() too ? Particularly there the "cheap" compare against 0 can't be benefited. Because almost all code points are actually BMP, the naive implementation of isValidCodePoint will almost always req

Re: Progress of patches

2010-03-11 Thread Martin Buchholz
On Thu, Mar 11, 2010 at 10:25, Ulf Zibis wrote: > Am 11.03.2010 05:42, schrieb Martin Buchholz: >> >> I couldn't resist making a similar change to isValidCodePoint. >> >> @@ -2678,7 +2678,8 @@ >>       * @since  1.5 >>       */ >>      public static boolean isValidCodePoint(int codePoint) { >> -  

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

2010-03-11 Thread Martin Buchholz
Ulf, your changes would be easier to get in if they were organized as mq patch files that could be qimported into an existing mq repo. I've done that below, which includes a subset of your own proposed changes: http://cr.openjdk.java.net/~martin/webrevs/openjdk7/isSupplementaryCodePoint/ http://c

Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

2010-03-11 Thread Ulf Zibis
Sherman, I know, your time ... ... but maybe someone is needed for sponsor here: https://bugs.openjdk.java.net/show_bug.cgi?id=100132 Could you do this? Much thanks, -Ulf Am 10.03.2010 19:23, schrieb Xueming Shen: approved. I don't have a spare ws right now.so please just push, it's alm

Re: Progress of patches

2010-03-11 Thread Ulf Zibis
Am 11.03.2010 05:42, schrieb Martin Buchholz: I couldn't resist making a similar change to isValidCodePoint. @@ -2678,7 +2678,8 @@ * @since 1.5 */ public static boolean isValidCodePoint(int codePoint) { -return codePoint>= MIN_CODE_POINT&& codePoint<= MAX_CODE_POINT

Re: Progress of patches

2010-03-11 Thread Ulf Zibis
I couldn't resist too ;-) . See: https://bugs.openjdk.java.net/attachment.cgi?id=178&action=diff Download: https://bugs.openjdk.java.net/attachment.cgi?id=178 Please have in mind: - the performance advantage as pair only occurs, if isBMPCodePoint too uses logical shift '>>>'. - String(int[] cod

hg: jdk7/tl/jdk: 6223635: Code hangs at connect call even when Timeout is specified when using a socks proxy

2010-03-11 Thread christopher . hegarty
Changeset: c6f8c58ed51a Author:chegar Date: 2010-03-11 17:50 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c6f8c58ed51a 6223635: Code hangs at connect call even when Timeout is specified when using a socks proxy Reviewed-by: michaelm, chegar Contributed-by: damjan@gmail

hg: jdk7/tl/jdk: 6933629: java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode

2010-03-11 Thread christopher . hegarty
Changeset: c342735a3e58 Author:chegar Date: 2010-03-11 17:37 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c342735a3e58 6933629: java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode Reviewed-by: alanb ! test/ProblemList.txt ! test/java/net/CookieHan

hg: jdk7/tl/jdk: 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread christopher . hegarty
Changeset: 07e1c5a90c6a Author:chegar Date: 2010-03-11 16:17 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/07e1c5a90c6a 6934054: java/net/Socket/FDClose.java return error in samevm Summary: test is no longer useful Reviewed-by: alanb ! test/ProblemList.txt - test/java/net/S

Re: Codereview needed for #6929479

2010-03-11 Thread Alan Bateman
Xueming Shen wrote: Alan, webrev has been updated to use the sun.zip.disableMemoryMapping http://cr.openjdk.java.net/~sherman/6929479/webrev Please review. Thanks, Sherman I agree it's a better name. In ZipFile it would be good to put a comment at the initialization so that the reader under