hg: jdk7/tl/jdk: 6868865: Test: sun/security/tools/jarsigner/oldsig.sh fails under all platforms

Changeset: 0500f7306cbe Author:weijun Date: 2010-03-17 09:55 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0500f7306cbe 6868865: Test: sun/security/tools/jarsigner/oldsig.sh fails under all platforms Reviewed-by: wetmore ! test/sun/security/tools/jarsigner/oldsig.sh

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

Am 16.03.2010 21:46, schrieb Martin Buchholz: On Tue, Mar 16, 2010 at 13:27, Ulf Zibis wrote: Am 13.03.2010 00:29, schrieb Martin Buchholz: Won't you like to add: *Note: In combination with {...@link #isBMPCodePoint(int)} this * method should be in 2nd place to permit additional

request for paired constants in j.l.Character

In java.lang.Character we have: public static final char MIN_VALUE = '\u'; public static final char MAX_VALUE = '\u'; public static final int MIN_CODE_POINT = 0x00; public static final int MAX_CODE_POINT = 0X10; public static final int MIN_SUPPLEMENTARY_CODE_POI

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

Am 17.03.2010 00:41, schrieb Martin Buchholz: On Tue, Mar 16, 2010 at 16:14, Ulf Zibis wrote: Am 16.03.2010 22:36, schrieb Martin Buchholz: On Tue, Mar 16, 2010 at 13:58, Ulf Zibis wrote: Additionally, toUpperCaseCharArray(), codePointCountImpl(), String(int[], int, int) would profit f

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

On Tue, Mar 16, 2010 at 16:14, Ulf Zibis wrote: > Am 16.03.2010 22:36, schrieb Martin Buchholz: > > On Tue, Mar 16, 2010 at 13:58, Ulf Zibis wrote: > > > > Additionally, toUpperCaseCharArray(), codePointCountImpl(), String(int[], > int, int) would profit from consecutive use of isBMPCodePoint + >

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

Am 16.03.2010 22:36, schrieb Martin Buchholz: On Tue, Mar 16, 2010 at 13:58, Ulf Zibis wrote: Additionally, toUpperCaseCharArray(), codePointCountImpl(), String(int[], int, int) would profit from consecutive use of isBMPCodePoint + isSupplementaryCodePoint() or isHighSurrogate() + isLowSur

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

Am 16.03.2010 23:35, schrieb Xueming Shen: Martin Buchholz wrote: On Tue, Mar 16, 2010 at 13:06, Xueming Shen wrote: Martin Buchholz wrote: Therefore the existing implementation return codePoint>= MIN_SUPPLEMENTARY_CODE_POINT && codePoint<= MAX_CODE_POINT; will almost always perform just

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

I am recanting my previous support for any change to isSupplementaryCodePoint. I think my brain (or maybe Ulf's brain) tricked me into thinking that the considerations for isValidCodePoint and isBMPCodePoint also apply to isSupplementaryCodePoint. Sorry. I renamed my patch file from isSupplement

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

Am 16.03.2010 21:57, schrieb Martin Buchholz: On Tue, Mar 16, 2010 at 12:48, Ulf Zibis wrote: - Same shift magic would enhance isISOControl(), isHighSurrogate(), isLowSurrogate(), in particular if latter occur consecutive. isISOControl - yes, others - I am not convinced.

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

On Tue, Mar 16, 2010 at 13:58, Ulf Zibis wrote: > Additionally, toUpperCaseCharArray(), codePointCountImpl(), String(int[], > int, int) would profit from consecutive use of isBMPCodePoint + > isSupplementaryCodePoint() or isHighSurrogate() + isLowSurrogate. For codePointCountImpl(), I do not agr

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

Martin Buchholz wrote: On Tue, Mar 16, 2010 at 13:06, Xueming Shen wrote: Martin Buchholz wrote: Therefore the existing implementation return codePoint>= MIN_SUPPLEMENTARY_CODE_POINT && codePoint<= MAX_CODE_POINT; will almost always perform just one comparison aga

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

Am 13.03.2010 00:29, schrieb Martin Buchholz: OK, next round of review. I changed my UTF-8 changes to be behavior-preserving, removing any hint of controversy, and renamed the patch to "utf8-twiddling". I got Ulf in my head, and can't stop micro-optimizing. I added a new micro-optimizing patch

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

On Tue, Mar 16, 2010 at 13:06, Xueming Shen wrote: > Martin Buchholz wrote: >> >> Therefore the existing implementation  return codePoint>= MIN_SUPPLEMENTARY_CODE_POINT            &&  codePoint<= MAX_CODE_POINT; will almost always perform just one comparison against a cons

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

Very descriptive visualization. :-) I mean: if( 6932837 && (review ID of 1735166) gets fixed ) { existing isSupplementaryCodePoint() impl is BEST } else if ( 6933327 gets fixed ) { the proposed is better } else { proposed is still little better than existing isSupplementaryCodePoin

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

On Tue, Mar 16, 2010 at 13:36, Ulf Zibis wrote: > Am 16.03.2010 21:28, schrieb Martin Buchholz: > Sorry, I'm still not convinced for the surrogate testing methods. > Almost all chars are less than MIN_SURROGATE, so you have to beat > the already amazingly cheap > x >= MIN_SURROGATE. > > > Good po

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

On Tue, Mar 16, 2010 at 13:27, Ulf Zibis wrote: > Am 13.03.2010 00:29, schrieb Martin Buchholz: > > Won't you like to add: >     * Note: In combination with {...@link #isBMPCodePoint(int)} this >     * method should be in 2nd place to permit additional HotSpot compiler >     * optimization. Exampl

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

Am 16.03.2010 21:28, schrieb Martin Buchholz: On Tue, Mar 16, 2010 at 12:48, Ulf Zibis wrote: H.. Yes, you've convinced me! Done. THE meeting had it's success. ;-) - Same shift magic would enhance isISOControl(), isHighSurrogate(), isLowSurrogate(), in particular if l

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

What did you mean "Hotspot could benefit from..." Are you saying? if( 6932837 gets fixed ) { existing isSupplementaryCodePoint() impl is better } else if ( 6933327 gets fixed ) { the proposed is better } else { existing isSupplementaryCodePoint() impl might still be better } So we

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

On Tue, Mar 16, 2010 at 12:48, Ulf Zibis wrote: > Here my additions: > > Am 13.03.2010 00:04, schrieb Martin Buchholz: >>> >>> - Why don't you like using the new isBMPCodePoint() for >>> isSupplementaryCodePoint() and toUpperCaseCharArray() ? >>> >> >> I now use it for the assert in toUpperCaseCha

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

Here you can see, how HotSpot could benefit from that bit twiddling: I've filed some bugs against HotSpot to optimize those cases: 6932837 - Better use unsigned jump if one of the range limits is 0 6933327

Re: Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

Here my additions: Am 13.03.2010 00:04, schrieb Martin Buchholz: - Why don't you like using the new isBMPCodePoint() for isSupplementaryCodePoint() and toUpperCaseCharArray() ? I now use it for the assert in toUpperCaseCharArray() return !isBMPCodePoint() && isValidCodePoint();

Re: review request for 6798511/6860431: Include functionality of Surrogate in Character

Martin Buchholz wrote: Therefore the existing implementation return codePoint>= MIN_SUPPLEMENTARY_CODE_POINT && codePoint<= MAX_CODE_POINT; will almost always perform just one comparison against a constant, which is hard to beat. 1. Wondering: I think there are TWO compar

hg: jdk7/tl/jdk: 6935199: java/net regression tests failing with Assertions

Changeset: 895a1211b2e1 Author:chegar Date: 2010-03-16 14:31 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/895a1211b2e1 6935199: java/net regression tests failing with Assertions Reviewed-by: michaelm ! test/ProblemList.txt ! test/java/net/CookieHandler/TestHttpCookie.java

hg: jdk7/tl/jdk: 6934923: test/java/net/ipv6tests/TcpTest.java hangs on Solaris 10

Changeset: f88f6f8ddd21 Author:chegar Date: 2010-03-16 10:05 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f88f6f8ddd21 6934923: test/java/net/ipv6tests/TcpTest.java hangs on Solaris 10 Reviewed-by: alanb ! test/java/net/ipv6tests/TcpTest.java ! test/java/net/ipv6tests/Test