Here's another little improvement that should use isBMPCodePoint:
diff --git a/src/share/classes/java/lang/AbstractStringBuilder.java
b/src/share/classes/java/lang/AbstractStringBuilder.java
--- a/src/share/classes/java/lang/AbstractStringBuilder.java
+++ b/src/share/classes/java/lang/AbstractStri
Changeset: 35d272ef7598
Author:ohair
Date: 2010-03-19 18:17 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/rev/35d272ef7598
6936788: Minor adjustment to top repo test/Makefile, missing non-zero exit case
Reviewed-by: jjg
! test/Makefile
On Fri, Mar 19, 2010 at 14:46, Ulf Zibis wrote:
> Am 16.03.2010 23:35, schrieb Xueming Shen:
> Now I have two patches in my mq queue.
> Martin, how do I create 2 exports in the form, you would like?
Just copy the patch files to some public web-accessible place,
as I do with cr.openjdk.java.net.
Interesting benchmark results!
Your microbenchmark technique looks unusual, but seems to work.
I'm surprised there is that much difference.
I would take out the swallowing of Exception.
---
Your data contains only supplementary characters,
which we are assuming are very rare.
So I don't consid
Am 16.03.2010 23:35, schrieb Xueming Shen:
Martin Buchholz wrote:
The primary theory here is that branches are expensive,
and we are reducing them by one.
There are still two branches in new impl, if you count the "ifeq" and
"if_icmpge"(?)
We are trying to "optimize" this piece of code wi
Am 17.03.2010 18:05, schrieb Xueming Shen:
Martin Buchholz wrote:
On Wed, Mar 17, 2010 at 01:11, Ulf Zibis wrote:
Am I mad ???
2nd. correction:
But
for (int i = offset; i < offset + count; i++) {
int c = codePoints[i];
char plane = (char)(c >>> 16);
if
On Fri, Mar 19, 2010 at 13:29, schrieb Ulf Zibis :
> Am 17.03.2010 16:46, schrieb Martin Buchholz:
> The char is not important here, maybe give hotspot a hint that value is
> always positive 16-bit. My idea was to indicate this to the reader.
I think naming the variable "plane" and using the ">>
Am 17.03.2010 16:46, schrieb Martin Buchholz:
On Wed, Mar 17, 2010 at 01:11, Ulf Zibis wrote:
Am I mad ???
2nd. correction:
But
for (int i = offset; i< offset + count; i++) {
int c = codePoints[i];
char plane = (char)(c>>> 16);
if (plane == 0)
Martin Buchholz wrote:
I renamed my patch file from isSupplementaryCodePoint to isValidCodePoint.
6934268: Better implementation of Character.isValidCodePoint
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/isValidCodePoint
It's fine. But if I was you I would not "optimize" it.
693426
Changeset: 3bb93c410f41
Author:chegar
Date: 2010-03-19 13:07 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3bb93c410f41
6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with
modules build
Reviewed-by: alanb
! test/ProblemList.txt
! test/java/net/Serv
10 matches
Mail list logo
