Re: review request 6933322 - Add methods highSurrogate(), lowSurrogate() to class Character

2010-04-02 Thread Martin Buchholz
On Fri, Apr 2, 2010 at 17:54, Ulf Zibis wrote: > Looks good to me, but what about integrating **/highSurrogate2? I plan to do that just before I commit. > I think you have done a little bit too much in the 2nd paragraphs. I rarely > have seen such detailedness on current javadocs. The source is

Re: review request 6933322 - Add methods highSurrogate(), lowSurrogate() to class Character

2010-04-02 Thread Ulf Zibis
Looks good to me, but what about integrating **/highSurrogate2? Am 02.04.2010 22:01, schrieb Martin Buchholz: Hi Masayoshi, Writing good spec is hard and annoying, but important. I think you have done a little bit too much in the 2nd paragraphs. I rarely have seen such detailedness on cu

Re: review request 6933322 - Add methods highSurrogate(), lowSurrogate() to class Character

2010-04-02 Thread Masayoshi Okutsu
Hi Martin, Here are my comments on the 6933322 changes. - I'd suggest that the Unicode terms be used instead of "the first part" and "the second part", something like "the high surrogate (also known as leading surrogate) code unit of the surrogate pair." If you want to emphasize the order, "t

Re: java.util.Pair

2010-04-02 Thread tom . hawtin
On 30/03/2010 09:08, Weijun Wang wrote: > I know such a simple thing can be made very complex and everyone might > want to add a new method into it. How about we just make it most > primitive? Simply an immutable and Serializable class, two final > fields, one constructor, two getters (?), and no

Re: Kinda ?

2010-04-02 Thread Bruce Chapman & Barbara Carey
Paul Hohensee wrote: "in a way" plus "somewhat", as in "it's kinda bad" == "in a way, it's somewhat bad". On 3/22/10 7:02 PM, Ulf Zibis wrote: Can somebody betray the sense of "Kinda" to me? -Ulf a spoken contraction of "kind of" (similar meaning to sorta a contraction of sort-of) noth

Re: review request 6933322 - Add methods highSurrogate(), lowSurrogate() to class Character

2010-04-02 Thread Martin Buchholz
Hi Masayoshi, Writing good spec is hard and annoying, but important. I've improved the spec in various ways, mostly as you suggested. Please see the updated webrev http://cr.openjdk.java.net/~martin/webrevs/openjdk7/highSurrogate/ Martin On Thu, Apr 1, 2010 at 01:42, Masayoshi Okutsu wrote: >