Re: Disambiguating empty catch blocks

2010-04-16 Thread Joe Darcy
Martin Buchholz wrote: On Thu, Apr 15, 2010 at 20:02, Andrew Thompson wrote: On Apr 14, 2010, at 6:49 AM, Bruce Chapman wrote: One thing we definitely can do is to add a new constructor to AssertionError, that takes a cause as an argument, consistent with other exceptions.

Re: Disambiguating empty catch blocks

2010-04-16 Thread Martin Buchholz
On Thu, Apr 15, 2010 at 20:02, Andrew Thompson wrote: > > On Apr 14, 2010, at 6:49 AM, Bruce Chapman wrote: > >>> One thing we definitely can do is to add a new constructor >>> to AssertionError, that takes a cause as an argument, >>> consistent with other exceptions. >>> >> Yeah, that was a minor

Re: Bugs in java.util.ArrayList, java.util.Hashtable and java.io.ByteArrayOutputStream

2010-04-16 Thread Martin Buchholz
On Fri, Apr 16, 2010 at 03:17, David Holmes wrote: > Hi Martin, > > Martin Buchholz said the following on 04/16/10 16:09: >> >> I recently discovered another place to handle huge arrays better - in >> AbstractCollection. >> I've put those changes into >> http://cr.openjdk.java.net/~martin/webrevs/

Re: UNIXProcess improvements

2010-04-16 Thread Martin Buchholz
On Fri, Apr 16, 2010 at 09:18, Mark Reinhold wrote: > For now I suggest leaving old @author tags as-is. OK, done. Version 0.2 of the webrev is published. Martin

Re: UNIXProcess improvements

2010-04-16 Thread Mark Reinhold
> Date: Fri, 16 Apr 2010 09:09:31 -0700 > From: Martin Buchholz > On Fri, Apr 16, 2010 at 09:00, chris.hega...@oracle.com wrote: >> I took a look at the preliminary changes. >>  * I'm not sure we can remove any previous authors names. > > We've considered doing that en masse. Yes, and we might

Re: UNIXProcess improvements

2010-04-16 Thread Martin Buchholz
I should have explicitly invited Michael and Xueming to review, as well. On Fri, Apr 16, 2010 at 09:00, Chris Hegarty wrote: > Martin, > > I filed the following to track this: >  6944584: Improvements to subprocess handling on Unix Thanks. > I took a look at the preliminary changes. >  * I'm no

Re: UNIXProcess improvements

2010-04-16 Thread Chris Hegarty
Martin, I filed the following to track this: 6944584: Improvements to subprocess handling on Unix I took a look at the preliminary changes. * I'm not sure we can remove any previous authors names. * I assume the second part, buffering of data after process termination has not been impleme

Re: Need reviewer - Change to jdk/test/makefile for shared library execute permissions

2010-04-16 Thread Alan Bateman
Kelly O'Hair wrote: Need reviewer - Change to jdk/test/makefile for shared library execute permissions We been having some spurious test failures on windows and finally tracked it down to this issue. Fixing it in the jdk/test/Makefile seemed like the best place, even though none of us really

Re: Bugs in java.util.ArrayList, java.util.Hashtable and java.io.ByteArrayOutputStream

2010-04-16 Thread David Holmes
Hi Martin, Martin Buchholz said the following on 04/16/10 16:09: I recently discovered another place to handle huge arrays better - in AbstractCollection. I've put those changes into http://cr.openjdk.java.net/~martin/webrevs/openjdk7/ArrayResize2/ I don't understand what you are doing here:

Re: Bugs in java.util.ArrayList, java.util.Hashtable and java.io.ByteArrayOutputStream

2010-04-16 Thread Chris Hegarty
Martin Buchholz wrote: Hi Chris, I recently discovered another place to handle huge arrays better - in AbstractCollection. I've put those changes into http://cr.openjdk.java.net/~martin/webrevs/openjdk7/ArrayResize2/ I propose to qfold these into the original changes for this bug http://cr.open

Re: A few char-fiddling optimizations for Pattern.java

2010-04-16 Thread Ulf Zibis
Am 16.04.2010 10:48, schrieb Ulf Zibis: On a 2nd thought, I think a code point in the surrogate range should be rare, as it is kinda invalid. So why check it in 1. place. What is the purpose of the method? - isNotValidOrSurrogateBMPCodePoint --> includes negative and values > MAX_SUPPLEMENTARY_

hg: jdk7/tl/jdk: 6944361: Missing CKR_ values in PKCS11Exception

2010-04-16 Thread ahughes
Changeset: c444651077d2 Author:andrew Date: 2010-04-16 09:54 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c444651077d2 6944361: Missing CKR_ values in PKCS11Exception Summary: Allow native NSS errors to be observed and correctly reported Reviewed-by: wetmore, valeriep ! sr

Re: A few char-fiddling optimizations for Pattern.java

2010-04-16 Thread Ulf Zibis
Am 16.04.2010 02:52, schrieb Martin Buchholz: On Thu, Apr 15, 2010 at 17:23, Ulf Zibis wrote: Hi Xueming and Ulf, Please review a few more optimizations to be added to the current crop: http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Pattern-opt/ Have you tried to disassemb