hg: jdk7/tl/jdk: 6917323: serializable classes in java.dyn do not specify serialVersionUIDs

2010-10-06 Thread joe . darcy
Changeset: a6295291fab1 Author:darcy Date: 2010-10-06 21:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a6295291fab1 6917323: serializable classes in java.dyn do not specify serialVersionUIDs Reviewed-by: jrose ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Kelly O'Hair
On Oct 6, 2010, at 2:28 PM, Mandy Chung wrote: On 10/06/10 13:37, Alan Bateman wrote: This batch eliminates a bunch of compiler warnings from the native code: http://cr.openjdk.java.net/~alanb/6989466/webrev/ Looks good to me. I will defer to your build to verify if there is any rema

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Dr Andrew John Hughes
On 6 October 2010 21:56, Dr Andrew John Hughes wrote: > On 6 October 2010 21:37, Alan Bateman wrote: >> >> This batch eliminates a bunch of compiler warnings from the native code: >>  http://cr.openjdk.java.net/~alanb/6989466/webrev/ >> >> It also fixes an incorrect usage of memset found along th

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Kelly O'Hair
This looks ok to me. If it gets past a JPRT build on all platforms I think it's golden. Thank you. May your fortune cookies always be positive. ;^) -kto On Oct 6, 2010, at 1:37 PM, Alan Bateman wrote: This batch eliminates a bunch of compiler warnings from the native code: http://cr.ope

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Mandy Chung
On 10/06/10 13:37, Alan Bateman wrote: This batch eliminates a bunch of compiler warnings from the native code: http://cr.openjdk.java.net/~alanb/6989466/webrev/ Looks good to me. I will defer to your build to verify if there is any remaining one. It also fixes an incorrect usage of me

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Dr Andrew John Hughes
On 6 October 2010 21:37, Alan Bateman wrote: > > This batch eliminates a bunch of compiler warnings from the native code: >  http://cr.openjdk.java.net/~alanb/6989466/webrev/ > > It also fixes an incorrect usage of memset found along the way. > > -Alan. > This looks good from reading the patch.

6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

2010-10-06 Thread Alan Bateman
This batch eliminates a bunch of compiler warnings from the native code: http://cr.openjdk.java.net/~alanb/6989466/webrev/ It also fixes an incorrect usage of memset found along the way. -Alan.

Re: 6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol)

2010-10-06 Thread Chris Hegarty
Alan Bateman wrote: The fix for 6981138 a few weeks ago added another test to test/java/lang/ProcessBuilder/Basic.java. That test is failing on Solaris because the asynchronous close of the stream connected to the child's stdout causes the reader thread to throw an IOException with an except

Re: 6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol)

2010-10-06 Thread Kelly O'Hair
Looks ok to me. Maybe your comment should be added to the test? Might explain the code better. -kto On Oct 6, 2010, at 9:18 AM, Alan Bateman wrote: The fix for 6981138 a few weeks ago added another test to test/java/ lang/ProcessBuilder/Basic.java. That test is failing on Solaris becau

6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol)

2010-10-06 Thread Alan Bateman
The fix for 6981138 a few weeks ago added another test to test/java/lang/ProcessBuilder/Basic.java. That test is failing on Solaris because the asynchronous close of the stream connected to the child's stdout causes the reader thread to throw an IOException with an exception message that the

hg: jdk7/tl/jdk: 2 new changesets

2010-10-06 Thread lance . andersen
Changeset: 0f23a139e819 Author:lancea Date: 2010-10-06 10:09 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f23a139e819 6988310: SyncFactory.setLogger(Logger,Level) requires unspecified security permission Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/spi/SyncFac

Re: Code Review Request for # 6975829 : Perf. of gzip in existing JDKs is too slower than in 1.3.1

2010-10-06 Thread Alan Bateman
Xueming Shen wrote: Alan, It appears we do have a regression test [1] in our repository to make sure that we do NOT do round-trip more than necessary for "short" input. While the change in http://cr.openjdk.java.net/~sherman/6975829/webrev