Re: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError

2010-10-18 Thread David Holmes
Mandy Chung said the following on 10/19/10 15:05: On 10/18/10 9:24 PM, David Holmes wrote: Hi Mandy, Given you can't actually test ArrayList I would drop it altogether and move the test to java/util/vector/TestEnsureCapacity But it tests ArrayList.ensureCapacity(Integer.MIN_VALUE) which sho

hg: jdk7/tl/langtools: 6551367: javadoc throws ClassCastException when an @link tries to reference constructor.

2010-10-18 Thread sundararajan . a
Changeset: 5286a99de2e6 Author:sundar Date: 2010-10-19 11:47 +0530 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5286a99de2e6 6551367: javadoc throws ClassCastException when an @link tries to reference constructor. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/

Re: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError

2010-10-18 Thread Mandy Chung
On 10/18/10 9:24 PM, David Holmes wrote: Hi Mandy, Given you can't actually test ArrayList I would drop it altogether and move the test to java/util/vector/TestEnsureCapacity But it tests ArrayList.ensureCapacity(Integer.MIN_VALUE) which should not throw any exception (the regression throws

Re: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError

2010-10-18 Thread David Holmes
Hi Mandy, Given you can't actually test ArrayList I would drop it altogether and move the test to java/util/vector/TestEnsureCapacity David Mandy Chung said the following on 10/19/10 14:07: On 10/18/10 4:54 PM, David Holmes wrote: Hi Mandy, The functional changes seem ok. However the Arra

Re: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError

2010-10-18 Thread Mandy Chung
On 10/18/10 4:54 PM, David Holmes wrote: Hi Mandy, The functional changes seem ok. However the ArrayList test is not right because it checks the size not the capacity. The same with the Vector test, though at least with Vector you can check capacity(). I missed the Vector.capacity() metho

Re: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError

2010-10-18 Thread David Holmes
Hi Mandy, The functional changes seem ok. However the ArrayList test is not right because it checks the size not the capacity. The same with the Vector test, though at least with Vector you can check capacity(). I find it odd that ArrayList has a very well defined notion of capacity yet no m

Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError

2010-10-18 Thread Mandy Chung
Please review the fix for: 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError with minCap=Integer.MIN_VALUE Webrev at: http://cr.openjdk.java.net/~mchung/6992121/webrev.00/ This is a regression caused by the changes for 6933217 (Huge arrays handled poorly in core

hg: jdk7/tl/langtools: 6991980: polymorphic signature calls don't share the same CP entries

2010-10-18 Thread maurizio . cimadamore
Changeset: 493ecc8111ba Author:mcimadamore Date: 2010-10-18 19:14 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/493ecc8111ba 6991980: polymorphic signature calls don't share the same CP entries Summary: wrong use of attr env in Infer.java prevents sharing of CP entries

hg: jdk7/tl/jdk: 6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6 workspace

2010-10-18 Thread sean . coffey
Changeset: 426e5f2dbea3 Author:coffeys Date: 2010-10-18 18:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/426e5f2dbea3 6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6 workspace Reviewed-by: alanb + test/java/nio/channels/Selector/TemporaryS

hg: jdk7/tl/jdk: 6992545: FindBugs scan - Malicious code vulnerability Warnings in com.sun.net.httpserver.HttpsParameters.*

2010-10-18 Thread chris . hegarty
Changeset: 5193b0c2baf0 Author:chegar Date: 2010-10-18 16:51 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5193b0c2baf0 6992545: FindBugs scan - Malicious code vulnerability Warnings in com.sun.net.httpserver.HttpsParameters.* Reviewed-by: alanb ! src/share/classes/com/sun

hg: jdk7/tl/jdk: 2 new changesets

2010-10-18 Thread sean . mullan
Changeset: 0f5bab573e01 Author:mullan Date: 2010-10-18 09:00 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f5bab573e01 6988599: CertificateRevokedException specifies name of authority but interacts with authority instance Reviewed-by: vinnie ! src/share/classes/java/secur

hg: jdk7/tl/jdk: 2 new changesets

2010-10-18 Thread alan . bateman
Changeset: b79600ecf0e4 Author:alanb Date: 2010-10-18 10:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b79600ecf0e4 4837564: (bf) Please make DirectByteBuffer performance enhancements Reviewed-by: chegar ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/sh