Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2011-01-05 Thread Stuart Marks
On 1/5/11 5:36 AM, Alan Bateman wrote: I've taken the liberty to generate a webrev from the changeset, just to make it a bit easier for folks to browse and review. http://cr.openjdk.java.net/~alanb/6927486/webrev/ I don't see any issues with the changes to j.u.Hashtable. You might have seen Stua

Re: [Fwd: Re: hg: jdk7/tl/langtools: 7010194: several langtools regression failures after JSR 292 changes (b123)]

2011-01-05 Thread Rémi Forax
On 01/05/2011 12:53 PM, Maurizio Cimadamore wrote: On 05/01/11 11:23, Alan Bateman wrote: Hi maurizio, In my opinion, XlintWarn should also test invokeGeneric(). Moreover, it will be better to have one test by invoke*() instead of having one test for all invoke*() Rémi Hi Remi I agree on your

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2011-01-05 Thread Alan Bateman
Neil Richards wrote: Please find attached a changeset to address the problem reported in bug 6927486, "Deadlock in legacy Hashtable writeObject()". I've taken the liberty to generate a webrev from the changeset, just to make it a bit easier for folks to browse and review. http://cr.openjdk.

Re: [Fwd: Re: hg: jdk7/tl/langtools: 7010194: several langtools regression failures after JSR 292 changes (b123)]

2011-01-05 Thread Maurizio Cimadamore
On 05/01/11 11:23, Alan Bateman wrote: Hi maurizio, In my opinion, XlintWarn should also test invokeGeneric(). Moreover, it will be better to have one test by invoke*() instead of having one test for all invoke*() Rémi Hi Remi I agree on your comments; however note that the aim of the XlintWarn

Re: Code Review 7000511: PrintStream, PrintWriter, Formatter leave files open when exception thrown

2011-01-05 Thread Alan Bateman
Chris Hegarty wrote: : Thanks for the comments. Please take a look at the latest changes. http://cr.openjdk.java.net/~chegar/7000511/webrev.02/webrev/ I see you've updated this to webrev.03 so I looked at that. Overall this looks much cleaner and you've addressed the issues that I pointed ou

Re: hg: jdk7/tl/langtools: 7010194: several langtools regression failures after JSR 292 changes (b123)

2011-01-05 Thread Rémi Forax
Hi maurizio, In my opinion, XlintWarn should also test invokeGeneric(). Moreover, it will be better to have one test by invoke*() instead of having one test for all invoke*() Rémi On 01/05/2011 11:00 AM, maurizio.cimadam...@oracle.com wrote: Changeset: 15484cb7e5ae Author:mcimadamore Date

hg: jdk7/tl/langtools: 7010194: several langtools regression failures after JSR 292 changes (b123)

2011-01-05 Thread maurizio . cimadamore
Changeset: 15484cb7e5ae Author:mcimadamore Date: 2011-01-05 09:59 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/15484cb7e5ae 7010194: several langtools regression failures after JSR 292 changes (b123) Summary: Some regression tests rely on unsupported JSR 292 features