Re: code review request for 7011095, revert diamond changes in method args

2011-01-10 Thread Joe Darcy
Hi Stuart. Looks good; approved! Thanks, -Joe Stuart Marks wrote: Hi all, This is a followup to the diamond conversion I did for 6880112, reviewed here a few weeks ago [1]. That conversion applied the diamond operator in variable initializers, assignment statements, return statements, an

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2011-01-10 Thread Brian Goetz
While on the subject of serialization deadlocks in core libraries, Amy Williams and Mike Ernst did a paper (also became Amy's masters thesis) back when Mike was at MIT on static detection of deadlocks and they built a tools which found several deadlocks in the JDK collections. Does anyone recal

hg: jdk7/tl/jdk: 7005608: diamond conversion of JCA and crypto providers

2011-01-10 Thread stuart . marks
Changeset: 2a0ff59928de Author:smarks Date: 2011-01-10 17:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a0ff59928de 7005608: diamond conversion of JCA and crypto providers Reviewed-by: wetmore ! src/share/classes/java/security/Security.java ! src/share/classes/sun/secur

code review request for 7011095, revert diamond changes in method args

2011-01-10 Thread Stuart Marks
Hi all, This is a followup to the diamond conversion I did for 6880112, reviewed here a few weeks ago [1]. That conversion applied the diamond operator in variable initializers, assignment statements, return statements, and in method arguments. For stylistic reasons we've decided that using

hg: jdk7/tl/langtools: 6396503: javac should not require assertions enabled

2011-01-10 Thread jonathan . gibbons
Changeset: 7c537f4298fb Author:jjg Date: 2011-01-10 15:08 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7c537f4298fb 6396503: javac should not require assertions enabled Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/Main.java ! src/share/classes/com

hg: jdk7/tl/langtools: 6992999: fully remove JSR 308 from langtools

2011-01-10 Thread jonathan . gibbons
Changeset: d17f37522154 Author:jjg Date: 2011-01-10 14:57 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d17f37522154 6992999: fully remove JSR 308 from langtools Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/s

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2011-01-10 Thread Mike Duigou
Hi Neil; Thanks for the updates. I have posted both this webrev and the Hashtable counterpart on cr.openjdk.java.net: Hashtable : http://cr.openjdk.java.net/~mduigou/6927486.1/webrev/ Vector : http://cr.openjdk.java.net/~mduigou/6934356.3/webrev/ I am confused on one point about the license.

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2011-01-10 Thread Alan Bateman
Neil Richards wrote: : Apologies for seeming to approach the solution asymptotically. Please find attached a further webrev zip file with modification to the writeObject's javadoc and testcases copyright date range. Please let me know if you find anything further. The update to the javadoc l

hg: jdk7/tl/jdk: 6544224: Remove the need of sun.reflect.misc

2011-01-10 Thread lance . andersen
Changeset: f4d755bbdabe Author:lancea Date: 2011-01-10 14:43 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4d755bbdabe 6544224: Remove the need of sun.reflect.misc Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2011-01-10 Thread Alan Bateman
Neil Richards wrote: : Okay. I've updated the changeset to do this too, and attached this as a webrev zip file (as per Dalibor's suggestion). Please review this modified changeset, and let me know if anything further is required for its acceptance. Looks fine to me. As per the tests for the

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2011-01-10 Thread Alan Bateman
Neil Richards wrote: Based on Alan Bateman's feedback for my fix for a similar problem seen in java.util.Hashtable (http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-January/005601.html), I've revised the changeset once again to use diamond operators in the testcases, and to their main me

hg: jdk7/tl/jdk: 7002957: (fc) FileChannel.transferTo fails to load libsendfile on Solaris 64-bit

2011-01-10 Thread alan . bateman
Changeset: ee5bf287d0c4 Author:alanb Date: 2011-01-10 09:32 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee5bf287d0c4 7002957: (fc) FileChannel.transferTo fails to load libsendfile on Solaris 64-bit Reviewed-by: chegar ! make/java/nio/Makefile ! src/solaris/native/sun/nio/