Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2011-01-12 Thread Peter Jones
Hello, Sorry for chiming in late here, but I was wondering-- has the performance impact of this change been measured? Many years ago, the performance impact vs. the apparent severity of the bug at the time held back this fix (using PutField). Of course, both sides of that consideration may ha

Re: A HashMap bug with a Proxy value?

2011-01-12 Thread Jing LV
Hi, Chris, David and Alan, thanks for comments. Yes I was talking about the java.lang.reflect.Proxy, and proxy.equals(proxy) will return false if equals() (in InvocationHandler) is not well overriden. There is some solution on this problem (on spec. etc. ). However but for common developers (

hg: jdk7/tl/jdk: 2 new changesets

2011-01-12 Thread keith . mcguigan
Changeset: f5c0b3cbee2f Author:kamg Date: 2011-01-12 11:47 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5c0b3cbee2f 6436034: Instance filter doesn't filter event if it occurs in native method Summary: Use 'GetLocalInstance' JVMTI extension if it exists Reviewed-by: coleenp

hg: jdk7/tl/jdk: 7008713: diamond conversion of kerberos5 and security tools

2011-01-12 Thread stuart . marks
Changeset: a5a22f93e4c5 Author:smarks Date: 2011-01-12 13:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5a22f93e4c5 7008713: diamond conversion of kerberos5 and security tools Reviewed-by: weijun ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/

Re: A HashMap bug with a Proxy value?

2011-01-12 Thread Alan Bateman
Chris Hegarty wrote: Are you referring to java.net.Proxy? Proxy.equals depends on the resolution of its address. Address resolution could change over time, depending on the caching policy. java.net.URL has a similar issue. Strangely,I would have expected containsValue and containsKey to behave i

Re: A HashMap bug with a Proxy value?

2011-01-12 Thread David M. Lloyd
In my experience, the following are true: 1. Usage of any object has a hash key whose equals() result depends on external or mutable factors should never be used as a hash key for any reason. 2. Any object class for which, when given two instances "a" and "b", a == b is true but a.equals(b) is fal

Re: A HashMap bug with a Proxy value?

2011-01-12 Thread Chris Hegarty
Are you referring to java.net.Proxy? Proxy.equals depends on the resolution of its address. Address resolution could change over time, depending on the caching policy. java.net.URL has a similar issue. Strangely,I would have expected containsValue and containsKey to behave in a similar fashion. I

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

2011-01-12 Thread Brian Goetz
Yes, that's the one. Nothing to do with serialization, just a plain old deadlock. I believe this can happen with ordinary collections wrapped with synchronizedXxx() as well? But I don't think these admit an easy fix. On 1/11/2011 8:47 AM, Alan Bateman wrote: Brian Goetz wrote: While on the

A HashMap bug with a Proxy value?

2011-01-12 Thread Jing LV
Hello everyone, (As I am new in OpenJDK, please tell me if I post on the wrong mailing-list). I find an odd behaviour of HashMap. If we put a value which is an instance of Proxy, it would return false while checking containsValue(proxyinstance). I checked use Proxy instance as a key, it works well

hg: jdk7/tl/jdk: 7005424: Resync java.util.concurrent classes with Dougs CVS - Jan 2011

2011-01-12 Thread chris . hegarty
Changeset: cb3ecb5e4ce5 Author:dl Date: 2011-01-12 14:40 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb3ecb5e4ce5 7005424: Resync java.util.concurrent classes with Dougs CVS - Jan 2011 Reviewed-by: dholmes, chegar, mduigou ! src/share/classes/java/util/Collections.java !