hg: jdk7/tl/jdk: 7030400: 3/4 PrivateTransportTest.sh needs adjustment to work with 7003964

2011-03-30 Thread daniel . daugherty
Changeset: e2862ac26354 Author:dcubed Date: 2011-03-30 21:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e2862ac26354 7030400: 3/4 PrivateTransportTest.sh needs adjustment to work with 7003964 Summary: Fix typo in GetModuleHandle() function lookup. Reviewed-by: dholmes, al

hg: jdk7/tl/jdk: 7032364: Add jvm.cfg file for ARM and PPC architectures

2011-03-30 Thread david . holmes
Changeset: 5107fb3a9c06 Author:dholmes Date: 2011-03-30 22:20 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5107fb3a9c06 7032364: Add jvm.cfg file for ARM and PPC architectures Reviewed-by: darcy, bdelsart, alanb, mduigou + src/solaris/bin/arm/jvm.cfg + src/solaris/bin/ppc/

hg: jdk7/tl/langtools: 7031005: javap prints "extends java.lang.Object"

2011-03-30 Thread jonathan . gibbons
Changeset: c55928005af4 Author:jjg Date: 2011-03-30 18:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c55928005af4 7031005: javap prints "extends java.lang.Object" Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/Type.java ! src/share/classes/com

hg: jdk7/tl/langtools: 7031108: NPE in javac.jvm.ClassReader.findMethod in PackageElement.enclosedElements from AP in incr build

2011-03-30 Thread jonathan . gibbons
Changeset: 02ba4ff98742 Author:jjg Date: 2011-03-30 18:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/02ba4ff98742 7031108: NPE in javac.jvm.ClassReader.findMethod in PackageElement.enclosedElements from AP in incr build Reviewed-by: darcy, mcimadamore ! src/share/

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-03-30 Thread Xueming Shen
On 03/30/2011 12:53 PM, Neil Richards wrote: Hi Sherman, Thanks for your review and comments on this. On Tue, 2011-03-29 at 12:05 -0700, Xueming Shen wrote: Hi Neil, It appears to be a "regression" in scenario you described (user application never close the input stream after use and the ZipFi

Re: Trivial review: 7032364 Add jvm.cfg file for ARM and PPC architectures

2011-03-30 Thread David Holmes
Hi Joe, Joe Darcy said the following on 03/31/11 02:19: David Holmes wrote: http://cr.openjdk.java.net/~dholmes/7032364/webrev/ More pieces to support SE Embedded. In the jvm.cfg files for other "newer" configurations, "-hotspot" is set to "ERROR." So unless you have a need to recognize -

Re: Trivial review: 7032364 Add jvm.cfg file for ARM and PPC architectures

2011-03-30 Thread David Holmes
Hi Andrew, Dr Andrew John Hughes said the following on 03/31/11 00:08: On 30 March 2011 08:09, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/7032364/webrev/ More pieces to support SE Embedded. When are these files installed? Will they interfere with Zero/Shark installs on ARM & P

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-03-30 Thread Neil Richards
Hi Sherman, Thanks for your review and comments on this. On Tue, 2011-03-29 at 12:05 -0700, Xueming Shen wrote: > Hi Neil, > > It appears to be a "regression" in scenario you described (user > application never close the input stream after use and the ZipFile > instance being retained during the

Re: Trivial review: 7032364 Add jvm.cfg file for ARM and PPC architectures

2011-03-30 Thread Joe Darcy
David Holmes wrote: http://cr.openjdk.java.net/~dholmes/7032364/webrev/ More pieces to support SE Embedded. David Hi David. In the jvm.cfg files for other "newer" configurations, "-hotspot" is set to "ERROR." So unless you have a need to recognize -hotspot in ARM and PPC I would encourage

Re: Request for review: 6312706: Map entrySet iterators should return different entries on each call to next()

2011-03-30 Thread Neil Richards
On Tue, 2011-03-29 at 15:09 -0700, Mike Duigou wrote: > I think your suspicion is correct that the anonymous inner Object is > used rather than new Object so that it can be distinguished more > easily in heap dumps or via other tools. I would be fine with using > Integer(0) as the sentinel value. I

Re: Trivial review: 7032364 Add jvm.cfg file for ARM and PPC architectures

2011-03-30 Thread Dr Andrew John Hughes
On 30 March 2011 08:09, David Holmes wrote: > http://cr.openjdk.java.net/~dholmes/7032364/webrev/ > > More pieces to support SE Embedded. > > David > When are these files installed? Will they interfere with Zero/Shark installs on ARM & PPC? Thanks, -- Andrew :-) Free Java Software Engineer Re

Re: Trivial review: 7032364 Add jvm.cfg file for ARM and PPC architectures

2011-03-30 Thread Mike Duigou
If the files are fine with no entries defined then it looks good. I would have expected at least one KNOWN entry, no? Mike On Mar 30 2011, at 00:09 , David Holmes wrote: > http://cr.openjdk.java.net/~dholmes/7032364/webrev/ > > More pieces to support SE Embedded. > > David

Re: Trivial review: 7032364 Add jvm.cfg file for ARM and PPC architectures

2011-03-30 Thread David Holmes
Hi Bertrand, Bertrand Delsart said the following on 03/30/11 18:49: No objections two small comments since I do not know in which context this is used: - I'm surprised that it ends up in a solaris directory (and not linux or share) Historically in the jdk repo "solaris" means "not-windows".

Trivial review: 7032364 Add jvm.cfg file for ARM and PPC architectures

2011-03-30 Thread David Holmes
http://cr.openjdk.java.net/~dholmes/7032364/webrev/ More pieces to support SE Embedded. David