hg: jdk7/tl/jdk: 6894072: always refresh keytab

2011-04-20 Thread weijun . wang
Changeset: f8956ba13b37 Author:weijun Date: 2011-04-20 18:41 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f8956ba13b37 6894072: always refresh keytab Reviewed-by: valeriep ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java +

hg: jdk7/tl/jdk: 2 new changesets

2011-04-20 Thread michael . x . mcmahon
Changeset: ed01737a2e9a Author:michaelm Date: 2011-04-20 12:03 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed01737a2e9a 7034570: java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited Reviewed-by: dholmes, alanb !

Re: Review : 6546713: Link optional in Collection exception documentation to explanation

2011-04-20 Thread Doug Lea
On 04/19/11 21:07, David Holmes wrote: Hi Mike, Mike Duigou said the following on 04/20/11 08:00: Hello All; Another collections javadoc review request. This change links the (optional) notes in on various Collection methods to text which explains why they are not thrown by all collections.

Re: Review (Updated) : 4884238 : Constants for Standard Charsets

2011-04-20 Thread Ulf Zibis
Am 20.04.2011 02:23, schrieb Mike Duigou: On Apr 19 2011, at 04:52 , Ulf Zibis wrote: I think, we should catch the problem at the source. ... In my approach from Bug 100098 - Make sun.nio.cs.* charset objects light-weight such a class is named 'FastCharset'. Unfortunately any we at a very

Re: advice review requested for 6896297, race condition in rmid causing JCK failure

2011-04-20 Thread Stuart Marks
On 4/20/11 9:00 AM, Alan Bateman wrote: Stuart Marks wrote: Hi all, Please review an updated webrev for this bug: http://cr.openjdk.java.net/~smarks/reviews/6896297/webrev.1/ Using ConcurrentHashMap is much nicer in many ways, and it seems to resolve the JCK failures at least as well as the

Re: Review : 6546713: Link optional in Collection exception documentation to explanation

2011-04-20 Thread Mike Duigou
The webrev is now updated with the suggested changes. Doug Lea has already committed the cooresponding changes for the java.util.concurrent package to the jsr 166 CVS. Mike On Apr 19 2011, at 18:31 , Mike Duigou wrote: Not a problem on both counts. I will update the webrev shortly. Revised

Re: advice review requested for 6896297, race condition in rmid causing JCK failure

2011-04-20 Thread Peter Jones
Hi Stuart, On Apr 19, 2011, at 6:35 PM, Stuart Marks wrote: Please review an updated webrev for this bug: http://cr.openjdk.java.net/~smarks/reviews/6896297/webrev.1/ Using ConcurrentHashMap is much nicer in many ways, and it seems to resolve the JCK failures at least as well as the

hg: jdk7/tl/jdk: 6896297: (rmi) fix ConcurrentModificationException causing TCK failure

2011-04-20 Thread stuart . marks
Changeset: 00f3997e6aeb Author:smarks Date: 2011-04-20 16:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/00f3997e6aeb 6896297: (rmi) fix ConcurrentModificationException causing TCK failure Reviewed-by: alanb, dholmes, peterjones !

hg: jdk7/tl/jdk: 6546713: link the word (optional) in exception specifications to the text which provides explanation and context.

2011-04-20 Thread mike . duigou
Changeset: d5a7ed4e72a4 Author:mduigou Date: 2011-04-20 17:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5a7ed4e72a4 6546713: link the word (optional) in exception specifications to the text which provides explanation and context. Reviewed-by: dholmes, dl !