StandardCharset vs. StandardCharsets

2011-05-02 Thread mark . reinhold
2011/4/29 16:28 -0700, mike.dui...@oracle.com: > Hi Mark; > > I'm still not on your wavelength on this issue. For two reasons: > > - Collections, Arrays, Channels, Objects aren't typically used for > holding constants. They are either factories or collections of static > utility methods. Only Col

hg: jdk7/tl/jdk: 2 new changesets

2011-05-02 Thread michael . x . mcmahon
Changeset: 60b4039f60f9 Author:michaelm Date: 2011-05-02 20:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/60b4039f60f9 7041044: InetAddress.getByName(String,InetAddress) added in error Reviewed-by: alanb ! src/share/classes/java/net/InetAddress.java ! src/share/classes/j

Re: Codereview request: CR 7040220 java/char_encodin Optimize UTF-8 charset for String.getBytes()/toCharArray()

2011-05-02 Thread Alan Bateman
Xueming Shen wrote: : Webrev has been updated accordingly. I renamed the getBBuffer to getByteBuffer, now it "looks" better:-) The updated webrev looks fine to me. Personally I wouldn't have cached the byte buffer as the wrapping is not expensive (doesn't copy the array) and it's only used f

hg: jdk7/tl/jdk: 7040220: java/char_encodin Optimize UTF-8 charset for String.getBytes()/new String(byte[])

2011-05-02 Thread xueming . shen
Changeset: fa17f2b9a6d5 Author:sherman Date: 2011-05-02 11:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa17f2b9a6d5 7040220: java/char_encodin Optimize UTF-8 charset for String.getBytes()/new String(byte[]) Summary: implement sun.nio.cs.ArrayEn/Decoer in utf8 Reviewed-

hg: jdk7/tl/jdk: 7040151: SPNEGO GSS code does not parse tokens in accordance to RFC 2478

2011-05-02 Thread weijun . wang
Changeset: d08d77ad2d7b Author:weijun Date: 2011-05-03 02:48 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d08d77ad2d7b 7040151: SPNEGO GSS code does not parse tokens in accordance to RFC 2478 Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/spnego/NegTokenInit.j

hg: jdk7/tl/jdk: 7041136: Use Objects.equals in JDK platform classes

2011-05-02 Thread joe . darcy
Changeset: bd1ffb167be0 Author:darcy Date: 2011-05-02 11:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bd1ffb167be0 7041136: Use Objects.equals in JDK platform classes Reviewed-by: alanb, mduigou ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/

Re: Codereview request: CR 7040220 java/char_encodin Optimize UTF-8 charset for String.getBytes()/toCharArray()

2011-05-02 Thread Xueming Shen
On 5/2/2011 7:31 AM, Alan Bateman wrote: Xueming Shen wrote: Hi This is motivated by Neil's request to optimize common-case UTF8 path for native ZipFile.getEntry calls [1]. As I said in my replying email [2] I believe a better approach might be to "patch" UTF8 charset directly to implement

hg: jdk7/tl/jdk: 6553182: Need to modify javadoc doclet for GPL

2011-05-02 Thread bhavesh . patel
Changeset: c678b0cf5f92 Author:bpatel Date: 2011-05-02 10:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c678b0cf5f92 6553182: Need to modify javadoc doclet for GPL Reviewed-by: jjg ! make/docs/Makefile

hg: jdk7/tl/langtools: 6553182: Need to modify javadoc doclet for GPL

2011-05-02 Thread bhavesh . patel
Changeset: dbc4ced9d171 Author:bpatel Date: 2011-05-02 10:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dbc4ced9d171 6553182: Need to modify javadoc doclet for GPL Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/

Re: Codereview request: CR 7040220 java/char_encodin Optimize UTF-8 charset for String.getBytes()/toCharArray()

2011-05-02 Thread Alan Bateman
Xueming Shen wrote: Hi This is motivated by Neil's request to optimize common-case UTF8 path for native ZipFile.getEntry calls [1]. As I said in my replying email [2] I believe a better approach might be to "patch" UTF8 charset directly to implement sun.nio.cs.ArrayDecoder/Encoder interface t

hg: jdk7/tl/langtools: 7040883: Compilation error: "length in Array is defined in an inaccessible class or interface"

2011-05-02 Thread maurizio . cimadamore
Changeset: 384ea9a98912 Author:mcimadamore Date: 2011-05-02 12:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/384ea9a98912 7040883: Compilation error: "length in Array is defined in an inaccessible class or interface" Summary: Fix of 7034511 (now backed out) is caus

hg: jdk7/tl/jdk: 2 new changesets

2011-05-02 Thread michael . x . mcmahon
Changeset: 94551cf150a1 Author:michaelm Date: 2011-05-02 11:02 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/94551cf150a1 6569621: Problem with java/classes_net Reviewed-by: chegar ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/Socket.java ! src/

hg: jdk7/tl/langtools: 6492694: @deprecated tag doesn't work in package-info files.

2011-05-02 Thread bhavesh . patel
Changeset: 62bc3775d5bb Author:bpatel Date: 2011-05-02 02:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/62bc3775d5bb 6492694: @deprecated tag doesn't work in package-info files. Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.