hg: jdk8/tl/jdk: 7055363: jdk_security3 test target cleanup

Changeset: cb83fe13af98 Author:weijun Date: 2011-08-12 12:26 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb83fe13af98 7055363: jdk_security3 test target cleanup Reviewed-by: alanb, xuelei ! test/Makefile ! test/ProblemList.txt ! test/com/sun/security/auth/login/ConfigFile

hg: jdk8/tl/jdk: 7076415: sun/security/krb5/runNameEquals.sh failed on sles 10

Changeset: 4574445f35ac Author:weijun Date: 2011-08-12 11:20 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4574445f35ac 7076415: sun/security/krb5/runNameEquals.sh failed on sles 10 Reviewed-by: xuelei ! test/sun/security/krb5/Krb5NameEquals.java

Re: Any chance to see EnumSet implement SortedSet in JDK8?

There's an existing RFE for this request: CR#6278287 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6278287 Wherein Kevin Bourrillion provides some excellent analysis. The RFE hasn't been targeted to Java 8 and I'm unaware of any plan to escalate the priority. It would be a very good issue

Re: Any chance to see EnumSet implement SortedSet in JDK8?

On 8/11/2011 5:21 PM, Ulf Zibis wrote: Am 12.08.2011 01:03, schrieb Joe Darcy: Hello. On 8/11/2011 1:56 PM, Rémi Forax wrote: On 08/11/2011 10:19 PM, assembling signals wrote: Hello, community! Enum does implement Comparable, while EnumSet does NOT implement SortedSet and EnumMap doesn NOT

Re: Any chance to see EnumSet implement SortedSet in JDK8?

Am 12.08.2011 01:03, schrieb Joe Darcy: Hello. On 8/11/2011 1:56 PM, Rémi Forax wrote: On 08/11/2011 10:19 PM, assembling signals wrote: Hello, community! Enum does implement Comparable, while EnumSet does NOT implement SortedSet and EnumMap doesn NOT implement SortedMap. Should I file a bu

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

On 08/11/2011 02:56 PM, Rémi Forax wrote: On 08/11/2011 10:55 PM, Jonathan Gibbons wrote: Rémi, you wrote: On 08/11/2011 09:07 PM, Alexandre Boulgakov wrote: >/ Please review the attached patch to fix a build break. />/ />/ The fix changes new Class<>[] to new Class[] in two places. />/ />/

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

Agreed; looks good! Thanks, -Joe On 8/11/2011 2:41 PM, Rémi Forax wrote: On 08/11/2011 11:25 PM, Alexandre Boulgakov wrote: Hello, Joe and Rémi: Please review this updated webrev that incorporates your suggestions. http://cr.openjdk.java.net/~mduigou/7077389/1/webrev/

Re: Any chance to see EnumSet implement SortedSet in JDK8?

Hello. On 8/11/2011 1:56 PM, Rémi Forax wrote: On 08/11/2011 10:19 PM, assembling signals wrote: Hello, community! Enum does implement Comparable, while EnumSet does NOT implement SortedSet and EnumMap doesn NOT implement SortedMap. Should I file a bug report (RFE), would there be a chance to

Re: Code review request for 4900206 "Include worst-case rounding tests for Math library functions"

Hi Alan. On 8/11/2011 7:20 AM, Alan Bateman wrote: Joe Darcy wrote: Hello. Cleaning up my bug backlog, please review the addition of some new math library tests: 4900206 "Include worst-case rounding tests for Math library functions" http://cr.openjdk.java.net/~darcy/4900206.0/ Th

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

On 08/11/2011 10:55 PM, Jonathan Gibbons wrote: Rémi, you wrote: On 08/11/2011 09:07 PM, Alexandre Boulgakov wrote: >/ Please review the attached patch to fix a build break. />/ />/ The fix changes new Class<>[] to new Class[] in two places. />/ />/ Thanks, />/ Sasha / Hi Sasha, you can rew

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

On 08/11/2011 11:25 PM, Alexandre Boulgakov wrote: Hello, Joe and Rémi: Please review this updated webrev that incorporates your suggestions. http://cr.openjdk.java.net/~mduigou/7077389/1/webrev/ Specifically, I: * removed the 4 ser

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

Hello, Joe and Rémi: Please review this updated webrev that incorporates your suggestions. http://cr.openjdk.java.net/~mduigou/7077389/1/webrev/ Specifically, I: * removed the 4 serialVersionUIDs I added; * used "new TypeName[...]" i

Re: Any chance to see EnumSet implement SortedSet in JDK8?

On 08/11/2011 10:19 PM, assembling signals wrote: Hello, community! Enum does implement Comparable, while EnumSet does NOT implement SortedSet and EnumMap doesn NOT implement SortedMap. Should I file a bug report (RFE), would there be a chance to see this being implemented in JDK8? I've aske

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

Rémi, you wrote: On 08/11/2011 09:07 PM, Alexandre Boulgakov wrote: >/ Please review the attached patch to fix a build break. />/ />/ The fix changes new Class<>[] to new Class[] in two places. />/ />/ Thanks, />/ Sasha / Hi Sasha, you can rewrite: connectMethod = corbaStubClass.getMeth

hg: jdk8/tl/jdk: 7077672: jdk8_tl nightly fail in step-2 build on 8/10/11

Changeset: 79bd5691d85f Author:jjg Date: 2011-08-11 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79bd5691d85f 7077672: jdk8_tl nightly fail in step-2 build on 8/10/11 Reviewed-by: mchung, jjg Contributed-by: alexandre.boulga...@oracle.com ! src/share/classes/com/sun/

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

On 08/11/11 12:07, Alexandre Boulgakov wrote: Please review the attached patch to fix a build break. The fix changes new Class<>[] to new Class[] in two places. The patch looks good to me. Mandy

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

It seems that the line endings were broken in the attachment, so I'm going to resend the patch in-line. -Sasha -- diff -r 18329abcdb7c src/share/classes/com/sun/jndi/ldap/Obj.java --- a/src/share/classes/com/sun/jndi/ldap/Obj.javaWed Aug 10 13:44

Any chance to see EnumSet implement SortedSet in JDK8?

Hello, community! Enum does implement Comparable, while EnumSet does NOT implement SortedSet and EnumMap doesn NOT implement SortedMap. Should I file a bug report (RFE), would there be a chance to see this being implemented in JDK8? Best regards, Ivan G Shevchenko

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

On 08/11/2011 09:07 PM, Alexandre Boulgakov wrote: Please review the attached patch to fix a build break. The fix changes new Class<>[] to new Class[] in two places. Thanks, Sasha Hi Sasha, you can rewrite: connectMethod = corbaStubClass.getMethod("connect", new Class<>[] {

Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

Please review the attached patch to fix a build break. The fix changes new Class<>[] to new Class[] in two places. Thanks, Sasha diff -r 18329abcdb7c src/share/classes/com/sun/jndi/ldap/Obj.java --- a/src/share/classes/com/sun/jndi/ldap/Obj.java Wed Aug 10 13:44:58 2011 -0700 +++ b/src/sha

Re: Code review request for 4900206 "Include worst-case rounding tests for Math library functions"

Your fix adds worst-case rounding tests for math functions. It may also be useful to include worst-case rounding tests for number conversions (string-to-double). I have explored string-to-double issues, including problems when the converted numbers are close to the breakpoints between doubles. T

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

Alexandre Boulgakov wrote: Hello Joe, Thanks for reviewing and responding so quickly! On 8/10/2011 12:39 PM, Joe Darcy wrote: On 8/10/2011 11:36 AM, Alexandre Boulgakov wrote: Hello Joe, Could you please review these small changes to remove javac build warnings from the reflection classes?

Re: Code review request for 4900206 "Include worst-case rounding tests for Math library functions"

Joe Darcy wrote: Hello. Cleaning up my bug backlog, please review the addition of some new math library tests: 4900206 "Include worst-case rounding tests for Math library functions" http://cr.openjdk.java.net/~darcy/4900206.0/ These tests probe at hard to round values generated by

hg: jdk8/tl/jdk: 7047325: Internal API to improve management of direct buffers

Changeset: ddcb874581eb Author:coffeys Date: 2011-08-11 12:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddcb874581eb 7047325: Internal API to improve management of direct buffers Reviewed-by: alanb, mduigou ! make/com/oracle/Makefile - make/com/oracle/net/Makefile ! mak

Re: Code review request: 7077389 Reflection classes do not build with javac -Xlint:all -Werror

On 08/10/2011 10:43 PM, Alexandre Boulgakov wrote: Hello Remi, Hello, Thanks for the feedback! On 8/10/2011 1:22 PM, Rémi Forax wrote: On 08/10/2011 09:39 PM, Joe Darcy wrote: On 8/10/2011 11:36 AM, Alexandre Boulgakov wrote: Hello Joe, Could you please review these small changes to rem