Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

2011-08-12 Thread Jonathan Gibbons
On 08/12/2011 05:28 AM, Rémi Forax wrote: On 08/12/2011 01:29 AM, Jonathan Gibbons wrote: If you see any more opportunities for cleanup, I hope you'll let us know. Patches (or even changesets) would be even better :-) You could even have fun with the compiler and tree API to find examples o

hg: jdk8/tl/jdk: 7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list

2011-08-12 Thread stuart . marks
Changeset: 3f66f9ca1ba5 Author:smarks Date: 2011-08-12 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f66f9ca1ba5 7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list Reviewed-by: weijun, alanb ! test/ProblemList.txt

hg: jdk8/tl/jdk: 4900206: Include worst-case rounding tests for Math library functions

2011-08-12 Thread joe . darcy
Changeset: 8f962aca221e Author:darcy Date: 2011-08-12 13:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f962aca221e 4900206: Include worst-case rounding tests for Math library functions Reviewed-by: alanb ! test/java/lang/Math/Tests.java + test/java/lang/Math/WorstCaseTe

Re: Any chance to see EnumSet implement SortedSet in JDK8?

2011-08-12 Thread Rémi Forax
On 08/12/2011 08:21 PM, mike.ske...@talk21.com wrote: Hi Remi That is precisely my point The specification of RandomAccess defines the non functional behaviour so you are not inferring it you are using the specification You cannot assume that a list that does not implement RA has any preferred

Re: Any chance to see EnumSet implement SortedSet in JDK8?

2011-08-12 Thread mike . skells
Hi Remi That is precisely my point The specification of RandomAccess defines the non functional behaviour so you are not inferring it you are using the specification You cannot assume that a list that does not implement RA has any preferred iteration characteristics though Regards Mike --Or

Re: Any chance to see EnumSet implement SortedSet in JDK8?

2011-08-12 Thread mike . skells
Hi David, It doesn't work really in the general case because of wrapper classes Collections.unmodifyableCollection(c) for instance need to infer the characteristics from the content It could be a default implementation though Regards Mike --Original Message-- From: David Schlosnagle To:

Re: Any chance to see EnumSet implement SortedSet in JDK8?

2011-08-12 Thread David Schlosnagle
On Fri, Aug 12, 2011 at 9:06 AM, Rémi Forax wrote: > On 08/12/2011 02:46 PM, mike.ske...@talk21.com wrote: >> >> Hi Remi, >> Your argument is flawed >> >> The complexity of the operations is not defined by the interface or the >> presence or absence of the interface > > In theory yes, but in pract

hg: jdk8/tl/jdk: 7078355: sun/net/www/protocol/file/DirPermissionDenied.sh leaves garbage on some linux systems

2011-08-12 Thread weijun . wang
Changeset: e533c13df9ad Author:weijun Date: 2011-08-12 21:04 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e533c13df9ad 7078355: sun/net/www/protocol/file/DirPermissionDenied.sh leaves garbage on some linux systems Reviewed-by: chegar ! test/sun/net/www/protocol/file/DirPe

Re: Any chance to see EnumSet implement SortedSet in JDK8?

2011-08-12 Thread Rémi Forax
On 08/12/2011 02:46 PM, mike.ske...@talk21.com wrote: Hi Remi, Your argument is flawed The complexity of the operations is not defined by the interface or the presence or absence of the interface In theory yes, but in practice ... What is the purpose of java.util.RandomAccess ? If you have

Re: Any chance to see EnumSet implement SortedSet in JDK8?

2011-08-12 Thread mike . skells
Hi Remi, Your argument is flawed The complexity of the operations is not defined by the interface or the presence or absence of the interface If you have complexity algo checks then these can only be applied to known classes where the complexity is defined in the interface or class As such the

Re: Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

2011-08-12 Thread Rémi Forax
On 08/12/2011 01:29 AM, Jonathan Gibbons wrote: On 08/11/2011 02:56 PM, Rémi Forax wrote: On 08/11/2011 10:55 PM, Jonathan Gibbons wrote: Rémi, you wrote: On 08/11/2011 09:07 PM, Alexandre Boulgakov wrote: >/ Please review the attached patch to fix a build break. />/ />/ The fix changes new

Re: Any chance to see EnumSet implement SortedSet in JDK8?

2011-08-12 Thread Rémi Forax
On 08/12/2011 01:03 AM, Joe Darcy wrote: Hello. On 8/11/2011 1:56 PM, Rémi Forax wrote: On 08/11/2011 10:19 PM, assembling signals wrote: Hello, community! Enum does implement Comparable, while EnumSet does NOT implement SortedSet and EnumMap doesn NOT implement SortedMap. Should I file a bu