Re: Are the faster versions of HashMap and BigInteger going into jdk7?

2011-08-15 Thread Dr Andrew John Hughes
On 02:39 Mon 15 Aug , Alan Eliasen wrote: > On 10/27/2009 01:12 AM, Alan Eliasen wrote: > > On 10/23/2009 11:01 AM, Andrew John Hughes wrote: > >> 6622432 is the one of the ones I just pointed to i.e. it's in JDK7. > >> If Alan has a further patch and hasn't even submitted it for > >> inclusion

hg: jdk8/tl/jdk: 7079204: add several security and networking tests to problems list

2011-08-15 Thread weijun . wang
Changeset: dd218ad64d5c Author:weijun Date: 2011-08-16 08:53 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd218ad64d5c 7079204: add several security and networking tests to problems list Reviewed-by: smarks ! test/ProblemList.txt

hg: jdk8/tl/jdk: 7064075: Security libraries don't build with javac -Xlint:all, -deprecation -Werror

2011-08-15 Thread jonathan . gibbons
Changeset: afb6f2370cd3 Author:jjg Date: 2011-08-15 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/afb6f2370cd3 7064075: Security libraries don't build with javac -Xlint:all,-deprecation -Werror Reviewed-by: xuelei, mullan Contributed-by: alexandre.boulga...@oracle.com

hg: jdk8/tl/jdk: 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread joe . darcy
Changeset: 6e9ed747d0ca Author:darcy Date: 2011-08-15 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6e9ed747d0ca 4850225: Integer.getInteger() : Bad reference to getProperty? Reviewed-by: lancea ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Joe Darcy
Hi Sasha. In the JDK javadoc, I don't think we are that consistent on one or two spaces between sentences so the change below is fine. Thanks for checking, -Joe Alexandre Boulgakov wrote: In Integer.java, lines 779-780, there are multiple spaces between the sentences: 779 * The first argum

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Alexandre Boulgakov
In Integer.java, lines 779-780, there are multiple spaces between the sentences: 779 * The first argument is treated as the name of a system 780 * property. System properties are accessible through the {@link -Sasha On 8/15/2011 12:33 PM, Joe Darcy wrote: Hi Sasha. What is an example of what

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Joe Darcy
Hi Sasha. What is an example of what you're referring to? In the sdiff of the changes, the paragraph breaks are roughly the same. (I did reformat some paragraphs for line breaks, etc.) -Joe Alexandre Boulgakov wrote: Hello Joe, It looks like you have added multiple spaces between some se

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Lance Andersen - Oracle
looks fine Joe... Best Lance On Aug 15, 2011, at 3:17 PM, Joe Darcy wrote: > Hello. > > More bug cleanup, please review this small change to correct a misstatement > in the javadoc of Integer and Long about getProperty; along the way, some > more uses of multi-catch are added: > > 4850225:

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Alexandre Boulgakov
Hello Joe, It looks like you have added multiple spaces between some sentences. Is this intentional? Cheers, Sasha On 8/15/2011 12:17 PM, Joe Darcy wrote: Hello. More bug cleanup, please review this small change to correct a misstatement in the javadoc of Integer and Long about getProperty

JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Joe Darcy
Hello. More bug cleanup, please review this small change to correct a misstatement in the javadoc of Integer and Long about getProperty; along the way, some more uses of multi-catch are added: 4850225: Integer.getInteger() : Bad reference to getProperty? http://cr.openjdk.java.net/~darc

Re: Are the faster versions of HashMap and BigInteger going into jdk7?

2011-08-15 Thread Alan Eliasen
On 10/27/2009 01:12 AM, Alan Eliasen wrote: > On 10/23/2009 11:01 AM, Andrew John Hughes wrote: >> 6622432 is the one of the ones I just pointed to i.e. it's in JDK7. >> If Alan has a further patch and hasn't even submitted it for >> inclusion, it's obviously not in. > >I had just queried Joe

hg: jdk8/tl/jdk: 7063647: To use synchronized map in key manager

2011-08-15 Thread xuelei . fan
Changeset: b07cf6cbb62a Author:xuelei Date: 2011-08-15 00:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07cf6cbb62a 7063647: To use synchronized map in key manager Reviewed-by: wetmore, weijun ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java