Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

2011-08-15 Thread Sebastian Sickelmann
Hi, some time ago, i wrote[5] with Joe and David about advancing some exception-types to the 4 standard ctors. The first Exception i have looked at was InternalError and now(after some struggeling with gnumake and hg) my patches for reviewing are ready. I uploaded them at [4] I split the

Re: Are the faster versions of HashMap and BigInteger going into jdk7?

2011-08-15 Thread Alan Eliasen
On 10/27/2009 01:12 AM, Alan Eliasen wrote: On 10/23/2009 11:01 AM, Andrew John Hughes wrote: 6622432 is the one of the ones I just pointed to i.e. it's in JDK7. If Alan has a further patch and hasn't even submitted it for inclusion, it's obviously not in. I had just queried Joe Darcy at

JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Joe Darcy
Hello. More bug cleanup, please review this small change to correct a misstatement in the javadoc of Integer and Long about getProperty; along the way, some more uses of multi-catch are added: 4850225: Integer.getInteger() : Bad reference to getProperty?

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Alexandre Boulgakov
Hello Joe, It looks like you have added multiple spaces between some sentences. Is this intentional? Cheers, Sasha On 8/15/2011 12:17 PM, Joe Darcy wrote: Hello. More bug cleanup, please review this small change to correct a misstatement in the javadoc of Integer and Long about

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Lance Andersen - Oracle
looks fine Joe... Best Lance On Aug 15, 2011, at 3:17 PM, Joe Darcy wrote: Hello. More bug cleanup, please review this small change to correct a misstatement in the javadoc of Integer and Long about getProperty; along the way, some more uses of multi-catch are added: 4850225:

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Joe Darcy
Hi Sasha. What is an example of what you're referring to? In the sdiff of the changes, the paragraph breaks are roughly the same. (I did reformat some paragraphs for line breaks, etc.) -Joe Alexandre Boulgakov wrote: Hello Joe, It looks like you have added multiple spaces between some

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Alexandre Boulgakov
In Integer.java, lines 779-780, there are multiple spaces between the sentences: 779 * pThe first argument is treated as the name of a system 780 * property. System properties are accessible through the {@link -Sasha On 8/15/2011 12:33 PM, Joe Darcy wrote: Hi Sasha. What is an example of

Re: JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread Joe Darcy
Hi Sasha. In the JDK javadoc, I don't think we are that consistent on one or two spaces between sentences so the change below is fine. Thanks for checking, -Joe Alexandre Boulgakov wrote: In Integer.java, lines 779-780, there are multiple spaces between the sentences: 779 * pThe first

hg: jdk8/tl/jdk: 4850225: Integer.getInteger() : Bad reference to getProperty?

2011-08-15 Thread joe . darcy
Changeset: 6e9ed747d0ca Author:darcy Date: 2011-08-15 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6e9ed747d0ca 4850225: Integer.getInteger() : Bad reference to getProperty? Reviewed-by: lancea ! src/share/classes/java/lang/Integer.java !

hg: jdk8/tl/jdk: 7064075: Security libraries don't build with javac -Xlint:all, -deprecation -Werror

2011-08-15 Thread jonathan . gibbons
Changeset: afb6f2370cd3 Author:jjg Date: 2011-08-15 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/afb6f2370cd3 7064075: Security libraries don't build with javac -Xlint:all,-deprecation -Werror Reviewed-by: xuelei, mullan Contributed-by:

hg: jdk8/tl/jdk: 7079204: add several security and networking tests to problems list

2011-08-15 Thread weijun . wang
Changeset: dd218ad64d5c Author:weijun Date: 2011-08-16 08:53 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd218ad64d5c 7079204: add several security and networking tests to problems list Reviewed-by: smarks ! test/ProblemList.txt