hg: jdk8/tl/jdk: 7 new changesets

Changeset: 34fdcdb70d20 Author:rupashka Date: 2011-07-28 18:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34fdcdb70d20 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() Reviewed-by: alexp ! src/share/classes/javax/swing/RepaintManager.java Changeset

Request for Review: Chain more Exceptions (RuntimeException)

Hi, i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException. I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is fixed in the same manner as the patches there. http://oss-patches.24.eu/openjdk8/RuntimeException/REBAS

Re: Request Review for small change to remove 2 warnings in rmic

Am 18.08.2011 06:46, schrieb Sebastian Sickelmann: Am 18.08.2011 00:52, schrieb Mandy Chung: Thumbs up from me. Are you going to include this change with another CR that you have a fix to be pushed? I have some other improved that are reviewed by Joe actually. But there are on a completly o

Re: Request Review for small change to remove 2 warnings in rmic

Am 18.08.2011 00:52, schrieb Mandy Chung: Thumbs up from me. Are you going to include this change with another CR that you have a fix to be pushed? I have some other improved that are reviewed by Joe actually. But there are on a completly other topic and it should take some days to have all

Re: Request Review for small change to remove 2 warnings in rmic

Thumbs up from me. Are you going to include this change with another CR that you have a fix to be pushed? Mandy On 8/17/11 3:45 PM, Sebastian Sickelmann wrote: Hi while searching if i created warnings with an change i have seen that there are 2 warnings in rmic that are easy to remove. Ple

Request Review for small change to remove 2 warnings in rmic

Hi while searching if i created warnings with an change i have seen that there are 2 warnings in rmic that are easy to remove. Please review this hg export (no webrev unfortunately, because my free-file-host-provider is out of service :-( ) # HG changeset patch # User Sebastian # Date 1313620

Re: Request for review 6237353: Remove sun.io package from j2se binary

Those charsets at sun.awt.motif are using some of them. -Sherman On 8/17/2011 3:08 PM, Ulf Zibis wrote: Sherman, thanks. There are some more public sun.io-bridge-methods which could be saved or at least made package-private, e.g.: - EUC_TW.Encoder.toEUC() - EUC_TW.Decoder.toUnicode() - Doubl

Re: Request for review 6237353: Remove sun.io package from j2se binary

Sherman, thanks. There are some more public sun.io-bridge-methods which could be saved or at least made package-private, e.g.: - EUC_TW.Encoder.toEUC() - EUC_TW.Decoder.toUnicode() - DoubleByte.Encoder.encodeChar() - DoubleByte.Decoder.decodeSingle() - DoubleByte.Decoder.decodeDouble() - Double

hg: jdk8/tl/jdk: 7066490: @since 1.7 tag is missing for java.util.regex.Matcher.group(java.lang.String)

Changeset: 11cc9c2e0431 Author:sherman Date: 2011-08-17 15:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11cc9c2e0431 7066490: @since 1.7 tag is missing for java.util.regex.Matcher.group(java.lang.String) Summary: Added the @since 1.7 tag Reviewed-by: mduigou, forax ! s

Re: Request for review for 7066490: @since 1.7 tag is missing for java.util.regex.Matcher.group(java.lang.String)

Mike Duigou wrote: Looks good. This should be backported to 7 updates. I would say "yes" in case the javadoc gets regenerated at some point. -Joe Mike On Aug 17 2011, at 14:37 , Xueming Shen wrote: The @since 1.7 tag was missed when regex groupname suport was added in JDK7. Here is

Re: hg: jdk8/tl/jdk: 2 new changesets

It breaks my webrev a did 2 minutes before my upload completed. :-( But never mind. You are right. Removing is always a win. ;-) Am 17.08.2011 23:14, schrieb Rémi Forax: Hurrah, this is the changeset of the month, removing things is always a win. Rémi On 08/17/2011 11:05 PM, xueming.s...@oracl

Re: Request for review for 7066490: @since 1.7 tag is missing for java.util.regex.Matcher.group(java.lang.String)

On 08/17/2011 11:37 PM, Xueming Shen wrote: The @since 1.7 tag was missed when regex groupname suport was added in JDK7. Here is the webrev for adding it back in. http://cr.openjdk.java.net/~sherman/7066490/webrev Thanks! -Sherman lo

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Am 17.08.2011 23:34, schrieb Alexandre Boulgakov: On 8/17/2011 2:04 PM, Sebastian Sickelmann wrote: Am 17.08.2011 16:58, schrieb Alexandre Boulgakov: Hello Sebastian. On 8/17/2011 7:43 AM, Sebastian Sickelmann wrote: Am 17.08.2011 13:45, schrieb Alan Bateman: joe.da...@oracle.com wrote: I

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

On 8/17/2011 2:04 PM, Sebastian Sickelmann wrote: Am 17.08.2011 16:58, schrieb Alexandre Boulgakov: Hello Sebastian. On 8/17/2011 7:43 AM, Sebastian Sickelmann wrote: Am 17.08.2011 13:45, schrieb Alan Bateman: joe.da...@oracle.com wrote: I am willing to sponsor this work and I've filed bug

Re: Request for review for 7066490: @since 1.7 tag is missing for java.util.regex.Matcher.group(java.lang.String)

Looks good. This should be backported to 7 updates. Mike On Aug 17 2011, at 14:37 , Xueming Shen wrote: > The @since 1.7 tag was missed when regex groupname suport was added in JDK7. > Here is the webrev for adding it back in. > > http://cr.openjdk.java.net/~sherman/7066490/webrev >

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Am 17.08.2011 16:43, schrieb Sebastian Sickelmann: Am 17.08.2011 13:45, schrieb Alan Bateman: joe.da...@oracle.com wrote: I am willing to sponsor this work and I've filed bug 7080020 "Add conventional constructors to InternalError" for it. Thanks Joe, and to help this along here's the webre

Request for review for 7066490: @since 1.7 tag is missing for java.util.regex.Matcher.group(java.lang.String)

The @since 1.7 tag was missed when regex groupname suport was added in JDK7. Here is the webrev for adding it back in. http://cr.openjdk.java.net/~sherman/7066490/webrev Thanks! -Sherman

Re: hg: jdk8/tl/jdk: 2 new changesets

Hurrah, this is the changeset of the month, removing things is always a win. Rémi On 08/17/2011 11:05 PM, xueming.s...@oracle.com wrote: Changeset: 2961329a6774 Author:sherman Date: 2011-08-17 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2961329a6774 6237353: Remo

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 2961329a6774 Author:sherman Date: 2011-08-17 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2961329a6774 6237353: Remove sun.io package from j2se binary Summary: Removed sun.io package and related test cases Reviewed-by: alanb ! make/java/sun_nio/FILES_java.

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Am 17.08.2011 16:58, schrieb Alexandre Boulgakov: Hello Sebastian. On 8/17/2011 7:43 AM, Sebastian Sickelmann wrote: Am 17.08.2011 13:45, schrieb Alan Bateman: joe.da...@oracle.com wrote: I am willing to sponsor this work and I've filed bug 7080020 "Add conventional constructors to Internal

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Am 17.08.2011 03:11, schrieb joe.da...@oracle.com: Hello. On 8/14/2011 11:17 PM, Sebastian Sickelmann wrote: Hi, some time ago, i wrote[5] with Joe and David about advancing some exception-types to the 4 standard ctors. The first Exception i have looked at was InternalError and now(after s

Re: hg: jdk8/tl/jdk: 7077389: Reflection classes do not build with javac -Xlint:all -Werror

One day, someone brave enough should rewrite sun/reflect/generics because there is a lot of boilerplate in this package. The same code in ASM is at least 5 times shorter. Rémi On 08/17/2011 09:12 PM, jonathan.gibb...@oracle.com wrote: Changeset: e59aad6ed600 Author:jjg Date: 2011-08-1

Re: Request for review 6237353: Remove sun.io package from j2se binary

Updated accordingly. Thanks! -Sherman On 08/17/2011 11:34 AM, Alexandre Boulgakov wrote: Hello Sherman, You would also need to remove "JAVAC_LINT_OPTIONS = -Xlint:all,-deprecation" on line 35. When JAVAC_MAX_WARNINGS=true, JAVAC_LINT_OPTIONS automatically gets set to -Xlint:all [1], so that

Two heads after pull of tl/jdk and jdk8/jdk

Hi, after pulling from both sources http://hg.openjdk.java.net/jdk8/tl/jdk/ http://hg.openjdk.java.net/jdk8/jdk8/jdk/ i see that i got two heads. Is it because in all the other repositorys jdk8/*/jdk there are also many changes to the jdk-sub-repo? Should i worry about these changes and merge

hg: jdk8/tl/jdk: 7077389: Reflection classes do not build with javac -Xlint:all -Werror

Changeset: e59aad6ed600 Author:jjg Date: 2011-08-15 17:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e59aad6ed600 7077389: Reflection classes do not build with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulga...@oracle.com ! make/java/java/Mak

hg: jdk8/tl/jdk: 2 new changesets

Changeset: f4fe826b8034 Author:jjg Date: 2011-08-17 05:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4fe826b8034 7079606: tl nightly build failure due to incomplete generification Reviewed-by: jjg Contributed-by: alexandre.boulga...@oracle.com ! make/com/sun/security/Ma

Re: Request for review 6237353: Remove sun.io package from j2se binary

Thanks Sasha, The flag has been set to true, as suggested. The webrev has been updated according. http://cr.openjdk.java.net/~sherman/6237353/webrev/ -Sherman On 08/17/2011 05:54 AM, Alexandre Boulgakov wrote: Hello Sherman, Can you

Re: Request for review 6237353: Remove sun.io package from j2se binary

Hello Sherman, You would also need to remove "JAVAC_LINT_OPTIONS = -Xlint:all,-deprecation" on line 35. When JAVAC_MAX_WARNINGS=true, JAVAC_LINT_OPTIONS automatically gets set to -Xlint:all [1], so that line will not do anything. Thanks, Sasha [1] Actually, it gets set to "-Xlint:all -Xlint

Re: Request for review 6237353: Remove sun.io package from j2se binary

Ulf, I tried to be conservative to not touch the source code, just in case I might be forced to put them back again:-) But since I have already removed the whole sun.io source branch, it's reasonable to do the complete cleanup up as well. The webrev has been updated accordingly (to remove tho

hg: jdk8/tl/jdk: 2 new changesets

Changeset: c3a8d5feee94 Author:naoto Date: 2011-08-17 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3a8d5feee94 7073906: Locale.getDefault() returns wrong Locale for Java SE 7 Reviewed-by: okutsu ! src/windows/native/java/lang/java_props_md.c Changeset: f59c83f515e6

Re: 7015589: (spec) BufferedWriter.close leaves stream open if close of underlying Writer fails

On 08/17/2011 06:41 PM, Jing LV wrote: Hi Alan, Sorry for late reply, I somehow miss this mail. The patch seems perfect. Just a curious question about the fix in BufferedWriter: -try { +try (Writer w = out) { flushBuffer(); } finally { -

Re: 7015589: (spec) BufferedWriter.close leaves stream open if close of underlying Writer fails

Hi Alan, Sorry for late reply, I somehow miss this mail. The patch seems perfect. Just a curious question about the fix in BufferedWriter: -try { +try (Writer w = out) { flushBuffer(); } finally { -out.close();

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Hello Sebastian. On 8/17/2011 7:43 AM, Sebastian Sickelmann wrote: Am 17.08.2011 13:45, schrieb Alan Bateman: joe.da...@oracle.com wrote: I am willing to sponsor this work and I've filed bug 7080020 "Add conventional constructors to InternalError" for it. Thanks Joe, and to help this along

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Am 17.08.2011 13:45, schrieb Alan Bateman: joe.da...@oracle.com wrote: I am willing to sponsor this work and I've filed bug 7080020 "Add conventional constructors to InternalError" for it. Thanks Joe, and to help this along here's the webrev with Sebastian's patches: http://cr.openjdk.ja

Re: Request for review 6237353: Remove sun.io package from j2se binary

Hello Sherman, Can you check if any deprecation warnings are generated from the other classes built by java/sun_nio/Makefile? Suppressing deprecation warnings might no longer be necessary now that sun.io is gone, and then you can change lines 34-35 in the makefile to "JAVAC_MAX_WARNINGS = true

Re: Request for review 6237353: Remove sun.io package from j2se binary

As a consequence, allmost all classes in sun.nio.cs and templates in make/tools/CharsetMapping could be made package private, at least all access to the mapping tables! ... and don't forget to remove in each sun.nio.cs class and template: /** * These accessors are temporarily supplied

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

joe.da...@oracle.com wrote: I am willing to sponsor this work and I've filed bug 7080020 "Add conventional constructors to InternalError" for it. Thanks Joe, and to help this along here's the webrev with Sebastian's patches: http://cr.openjdk.java.net/~alanb/7080020/webrev/ I haven't rea

Re: Request for review 6237353: Remove sun.io package from j2se binary

Xueming Shen wrote: Hi, This is something long over due. Some background info. (1)The java.nio.charset package (to replace the private sun.io package) is added into JDK 1.4 as the result of the nio JSR. Part of the sun.io converters were migrated to the java.nio.charset implementa

Request for review 6237353: Remove sun.io package from j2se binary

Hi, This is something long over due. Some background info. (1)The java.nio.charset package (to replace the private sun.io package) is added into JDK 1.4 as the result of the nio JSR. Part of the sun.io converters were migrated to the java.nio.charset implementation in JDK8. (2) All