Changeset: d177eecda07e
Author:dholmes
Date: 2011-09-20 22:20 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d177eecda07e
7012206: ~20 tools tests failing due to -XX:-UsePerfData default in Java SE
Embedded
Summary: Explicitly enable UsePerfData for the tools that require it
Changeset: 029ba13aa0df
Author:dcubed
Date: 2011-09-20 19:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/029ba13aa0df
7085944: 3/3 FDS: gdb does not find debug symbols for libjsig link
Summary: Add support for importing .debuginfo files from HSX.
Reviewed-by: phh
! make/c
There was an omission in the original webrev regarding the jtreg
invocation changes for PrologSizeSanityCheck.java. The @run directive
needs the name of the class to invoke
+ * @run main/othervm -XX:+UsePerfData PrologSizeSanityCheck
Updated webrev at:
http://cr.openjdk.java.net/~dholmes/70
Changes look good.
On Sep 20 2011, at 17:54 , Joe Darcy wrote:
> Mike Duigou wrote:
>> Looks good.
>>
>> Do you think it's worth eliminating the private static method
>> toBoolean(String) in favour of the public static parseBoolean(String) method?
>>
>
> Sure; so updated in the revised webre
Changeset: 9b2fc8a11421
Author:darcy
Date: 2011-09-20 18:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b2fc8a11421
6268216: Boolean.getBoolean() throws SecurityException
Reviewed-by: mduigou
! src/share/classes/java/lang/Boolean.java
! src/share/classes/java/lang/Intege
Hi Mike,
A minor style nit. In Byte you have:
+public static final int BYTES = Byte.SIZE / Byte.SIZE;
whereas all the other classes use SIZE / Byte.size
David
On 21/09/2011 6:11 AM, Mike Duigou wrote:
Hello all;
Here's a webrev for two small additions to the primitive wrapper types
(Bo
Mike Duigou wrote:
Looks good.
Do you think it's worth eliminating the private static method toBoolean(String)
in favour of the public static parseBoolean(String) method?
Sure; so updated in the revised webrev:
http://cr.openjdk.java.net/~darcy/6268216.1/
I'll push after a successful
Looks good.
Do you think it's worth eliminating the private static method toBoolean(String)
in favour of the public static parseBoolean(String) method?
Mike
On Sep 20 2011, at 16:46 , Joe Darcy wrote:
> Hello.
>
> Please review this simple fix to add some informative text detailing when an
Hi Mike.
Approved, with a comment. For cases like Boolean, Double, and Long, I'd
prefer to see the instance hashCode method rewritten in terms of the new
static hashCode method.
Cheers,
-Joe
On 9/20/2011 1:11 PM, Mike Duigou wrote:
Hello all;
Here's a webrev for two small additions to th
Hello.
Please review this simple fix to add some informative text detailing
when an unchecked security exception can be thrown:
6268216 "Boolean.getBoolean() throws SecurityException"
http://cr.openjdk.java.net/~darcy/6268216.0/
Diff below.
Thanks,
-Joe
--- old/src/share/classes/java
On Sep 19, 2011, at 2:58 PM, John Rose wrote:
> http://cr.openjdk.java.net/~jrose/7030453/webrev.00
After some comments from David Holmes (thanks David!) I added internal comments
about race conditions.
I refreshed the webrev with the additional comments. I also changed one
variable to be vol
On Sep 19, 2011, at 11:58 PM, John Rose wrote:
> http://cr.openjdk.java.net/~jrose/7030453/webrev.00
src/share/classes/java/lang/ClassValue.java:
233 /** Value stream for for hashCodeForCache. See similar structure in
ThreadLocal. */
Two for's.
578 * from the ehad of a non-null
Hello all;
Here's a webrev for two small additions to the primitive wrapper types
(Boolean, Byte, Character, Double, Float, Integer, Long, Short).
http://cr.openjdk.java.net/~mduigou/7088913/0/webrev/
The webrev combines two issues:
7088913: Add compatible static hashCode(primitive) to pri
Changeset: c77b41652266
Author:mduigou
Date: 2011-09-20 12:27 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c77b41652266
7074264: Switches to packages tree view and adds unit tests to sources
Reviewed-by: igor
! make/netbeans/README
! make/netbeans/common/closed-share-view.
Changeset: ac964af3b5e7
Author:jjg
Date: 2011-09-20 12:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac964af3b5e7
7030473: Remove dead field JCCompilationUnit.flags
Reviewed-by: dlsmith
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
On 09/20/11 12:29, Aleksey Shipilev wrote:
Hi,
I've been stumbled upon this for a bit.
Is there any specific reason DelayQueue is not serializable? Or is it
an API bug?
The backing PriorityQueue *is* serializable.
It was a deliberate decision.
DelayQueues use relative times, so the delays don
Hi,
I've been stumbled upon this for a bit.
Is there any specific reason DelayQueue is not serializable? Or is it
an API bug?
The backing PriorityQueue *is* serializable.
Thanks,
Aleksey.
On Sep 19, 2011, at 10:05 PM, David Holmes wrote:
> Thanks Alan. Other failures haven't shown up thus far so for now we'll just
> address these ones (it improves the pass rate somewhat :) ).
>
> Could I get a second review from someone in serviceability?
They look fine to me.
-kto
>
> Thank
On 09/19/2011 04:21 PM, michael.x.mcma...@oracle.com wrote:
Changeset: e3d78fe803d4
Author:michaelm
Date: 2011-09-19 15:14 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3d78fe803d4
7091369: DatagramSocket/Limit.java failing on 8 and 7u2
Reviewed-by: chegar, alanb
! src/w
19 matches
Mail list logo
