Re: code review request : 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

2011-11-01 Thread Seán Coffey
On 30/10/2011 16:33, Alan Bateman wrote: On 28/10/2011 19:13, Seán Coffey wrote: This is a second stab at cleaning up the close() and finalize() methods for FileInputStream / FileOutputStream / RandomAccessFile classes so that all parents/referents sharing the same native FileDescriptor

Re: code review request : 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

2011-11-01 Thread Charles Lee
On 10/29/2011 02:13 AM, Seán Coffey wrote: This is a second stab at cleaning up the close() and finalize() methods for FileInputStream / FileOutputStream / RandomAccessFile classes so that all parents/referents sharing the same native FileDescriptor are closed out correctly. With Alan's

Re: code review request : 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

2011-11-01 Thread Seán Coffey
Charles, Yes - all three streams will now be closed. Previous to 7082769, when any of the streams calls close(), the underlying filedescriptor used get closed out via the native close0() call. A list of Closeables is maintained by FileDescriptor. regards, Sean. On 01/11/2011 13:54, Charles

Re: code review request : 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

2011-11-01 Thread Charles Lee
On 11/01/2011 10:46 PM, Seán Coffey wrote: Charles, Yes - all three streams will now be closed. Previous to 7082769, when any of the streams calls close(), the underlying filedescriptor used get closed out via the native close0() call. A list of Closeables is maintained by FileDescriptor.

Re: code review request : 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

2011-11-01 Thread Seán Coffey
The fd count was only used if it was the finalizer thread. Any explicit close() call not from finalizer meant that the FD got closed. /* * If FileDescriptor is still in use by another stream, the finalizer * will not close it. */ if ((useCount = 0)

Re: code review request : 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

2011-11-01 Thread Charles Lee
On 11/01/2011 11:09 PM, Seán Coffey wrote: If FileDescriptor is still /* * If FileDescriptor is still in use by another stream, the finalizer * will not close it. */ if ((useCount = 0) || !isRunningFinalize()) { close0(); } Hi

Code Review Request for 6578042

2011-11-01 Thread Darryl Mocek
Hello. Please review this patch to fix Bug #6578042 (System.clearProperty() throws ClassCastException if property value isn't a String). The issue is that through the Hashtable methods, it's possible to add a Property which isn't a String and set it through System.setProperties.

RE: Benchmarks for NIO buffer performance

2011-11-01 Thread Iris Clark
Hi, Mark. You gave me a copy of those test when I was working on this bug: 4463011: (bf) View-buffer bulk get/put operations are slow If I recall correctly, I modified the tests for my particular problem and added them to that bug as attachments. iris -Original Message- From: Mark