Re: Code Review - CR #7114195 -Short timeouts on regression tests

On 22/12/2011 15:08, Gary Adams wrote: : Webrev at: http://cr.openjdk.java.net/~gadams/7114195/ Dropping the /timeout from tests that specify <= 120s should be fine (and skimming through the patch, I don't see any issues). All it really means is that if the test hangs or deadlocks then it

Re: Request for review: 7123582: (launcher) display the -version and -XshowSettings

On 23/12/2011 02:22, Kumar Srinivasan wrote: Hi, This fixes a bug in launcher where showSettings in conjunction with -version will do both and exit successfully. Thanks to Sean for pointing this out. Here is the webrev: http://cr.openjdk.java.net/~ksrini/7123582/ Thanks Kumar Looks okay to

Re: Request for review: 7123582: (launcher) display the -version and -XshowSettings

Alan, On 23/12/2011 02:22, Kumar Srinivasan wrote: Hi, This fixes a bug in launcher where showSettings in conjunction with -version will do both and exit successfully. Thanks to Sean for pointing this out. Here is the webrev: http://cr.openjdk.java.net/~ksrini/7123582/ Thanks Kumar Look

Code Review - CR# 7030573 insufficient disk space for large file test

The LargeFileAvailable regression test had intermittent failures when there was not sufficient space available to create a 7G temp file. This webrev presents a simple check to see if the available usable space is less than 7G and scales the test back accordingly. The original bug report suggests

Re: Code Review Request for Bug #4802647

Here's an updated webrev for review for 4802647, which also contains a fix for 7123424. 7123424, as noted below, is the newly filed bug regarding the same bug behavior for CopyOnWriteArrayList and CopyOnWriteArraySet. It seems best to combine the fix for both into one webrev, so this webrev f

Code review request for #6469160, #7088271

Hello core-libs. I was wondering of somebody could be please review the following fix for #6469160 and #7088271. The changes in the webrev fix both bugs. Information is below: Webrev URL: http://cr.openjdk.java.net/~bpassani/6469160_7088271/1/

7121110 : JAXP 1.4.5 update 1 for 7u4 & jaxp source in jdk7 repo

Hi All, We have prepared a jaxp update for 7u4. The listed changes have been posted to the jdk7u-dev alias with "7u4 Request for approval for CR 7121110 - JAXP 1.4.5 update 1 for 7u4". With this update, we are adding jaxp sources back into the jdk7 repository, which means we are abandoning t

Re: Code Review Request for Bug #4802647

Hi Brandon, This looks okay to me. Just to clarify for other readers, the change to CopyOnWriteArrayList doesn't use Objects.requireNonNull because this code has to sync up with Doug Lea's jsr166 repository which runs on multiple version of the platform (some without requireNonNull). Also C

Re: 7121110 : JAXP 1.4.5 update 1 for 7u4 & jaxp source in jdk7 repo

On 12/23/2011 04:27 PM, Joe Wang wrote: Hi All, We have prepared a jaxp update for 7u4. The listed changes have been posted to the jdk7u-dev alias with "7u4 Request for approval for CR 7121110 - JAXP 1.4.5 update 1 for 7u4". With this update, we are adding jaxp sources back into the jdk7 reposi

hg: jdk8/tl/langtools: 7124605: typos in javac comments

Changeset: 116f68a5e677 Author:jjg Date: 2011-12-23 22:30 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/116f68a5e677 7124605: typos in javac comments Reviewed-by: ksrini ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/gener

Re: 7121110 : JAXP 1.4.5 update 1 for 7u4 & jaxp source in jdk7 repo

On 12/23/2011 2:11 PM, Omair Majid wrote: On 12/23/2011 04:27 PM, Joe Wang wrote: Hi All, We have prepared a jaxp update for 7u4. The listed changes have been posted to the jdk7u-dev alias with "7u4 Request for approval for CR 7121110 - JAXP 1.4.5 update 1 for 7u4". With this update, we are ad