Looks good.
Mandy
On 1/10/2012 5:20 PM, Joe Darcy wrote:
Hello,
Please review this simple fix to the javadoc of java.lang.Throwable;
use of "<" and ">" rather than "<" and ">" currently causes
malformed HTML to be generated.
--- a/src/share/classes/java/lang/Throwable.javaTue Jan 10
17
Looks good
On Jan 10, 2012, at 8:20 PM, Joe Darcy wrote:
> Hello,
>
> Please review this simple fix to the javadoc of java.lang.Throwable; use of
> "<" and ">" rather than "<" and ">" currently causes malformed HTML to
> be generated.
>
> --- a/src/share/classes/java/lang/Throwable.javaT
Changeset: 62dbcbe4c446
Author:darcy
Date: 2012-01-10 17:46 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62dbcbe4c446
7128931: Bad HTML escaping in java.lang.Throwable javadoc
Reviewed-by: mduigou
! src/share/classes/java/lang/Throwable.java
On 01/10/2012 01:14 PM, Mandy Chung wrote:
I18NJarTest.java
L29: Is -XDignore.symbol.file really needed? As far as I see,
the test only uses the public APIs.
L79: should it check if the returned value is false?
Otherwise, looks good.
Looks fine,
-Joe
Mandy
On 1/10/2012 1
Looks good.
On Jan 10 2012, at 17:20 , Joe Darcy wrote:
> Hello,
>
> Please review this simple fix to the javadoc of java.lang.Throwable; use of
> "<" and ">" rather than "<" and ">" currently causes malformed HTML to
> be generated.
>
> --- a/src/share/classes/java/lang/Throwable.javaTue
Hello,
Please review this simple fix to the javadoc of java.lang.Throwable; use
of "<" and ">" rather than "<" and ">" currently causes malformed
HTML to be generated.
--- a/src/share/classes/java/lang/Throwable.javaTue Jan 10 17:12:11
2012 -0800
+++ b/src/share/classes/java/lang/Throwab
Changeset: 49e64a8fc18f
Author:darcy
Date: 2012-01-10 17:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49e64a8fc18f
7112008: Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization of Class
Instances
Reviewed-by: mduigou
! src/share/classes/java/lang/Object.java
Kumar,
Could you fill in the introduced-in field in the CR?
Thanks
jeannette
On Jan 10, 2012, at 1:52 PM, Mandy Chung wrote:
> On 1/10/2012 1:44 PM, Kumar Srinivasan wrote:
>>
>>> I18NJarTest.java
>>> L29: Is -XDignore.symbol.file really needed? As far as I see,
>>> the test o
On 1/10/2012 1:44 PM, Kumar Srinivasan wrote:
I18NJarTest.java
L29: Is -XDignore.symbol.file really needed? As far as I see,
the test only uses the public APIs.
This is needed, since TestHelper uses javac and tar apis
behind the scenes.
Ah. I missed its reference to sun.to
Vote: yes
iris
Vote: yes
iris
I18NJarTest.java
L29: Is -XDignore.symbol.file really needed? As far as I see,
the test only uses the public APIs.
This is needed, since TestHelper uses javac and tar apis
behind the scenes.
L79: should it check if the returned value is false?
IMO not necessary, if mkdi
I18NJarTest.java
L29: Is -XDignore.symbol.file really needed? As far as I see,
the test only uses the public APIs.
L79: should it check if the returned value is false?
Otherwise, looks good.
Mandy
On 1/10/2012 1:06 PM, Kumar Srinivasan wrote:
sorry I pasted the wrong webrev i
Hello,
Please review this small doc cleanup of java.lang.Object:
7112008 Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization
of Class Instances
http://cr.openjdk.java.net/~darcy/7112008.0/
Full patch below inline.
Thanks,
-Joe
--- old/src/share/classes/java/lang/Object.java
sorry I pasted the wrong webrev in the email,
here is the right one...
http://cr.openjdk.java.net/~ksrini/7125442/
Kumar
Hi,
Please review:
CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125442
Webrev:
http://cr.openjdk.java.net/~ksrini/7124443/
Thanks
Kumar
Hi,
Please review:
CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125442
Webrev:
http://cr.openjdk.java.net/~ksrini/7124443/
Thanks
Kumar
Changeset: bba276a6aa0d
Author:chegar
Date: 2012-01-10 12:48 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bba276a6aa0d
7128584: Typo in sun.misc.VM's private directMemory field comment
Reviewed-by: forax, chegar
Contributed-by: Krystal Mok
! src/share/classes/sun/misc/VM.
Changeset: d72de8b3fe36
Author:chegar
Date: 2012-01-10 10:57 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d72de8b3fe36
7123415: Some cases of network interface indexes being read incorrectly
Reviewed-by: chegar
Contributed-by: brandon.passan...@oracle.com
! src/solaris/nat
Hi Chris and Remi,
Thank you very much :-)
Regards,
Kris Mok
On Tue, Jan 10, 2012 at 6:58 PM, Rémi Forax wrote:
> On 01/10/2012 11:43 AM, Chris Hegarty wrote:
>
>> I created CR 7128584: "Typo in sun.misc.VM's private directMemory field
>> comment", for this issue, and will push Kris' change wi
On 01/10/2012 11:43 AM, Chris Hegarty wrote:
I created CR 7128584: "Typo in sun.misc.VM's private directMemory
field comment", for this issue, and will push Kris' change with Remi
and myself as reviewer and listing Kris as the contributor.
Thanks,
-Chris.
Thanks,
Rémi
On 01/10/12 08:22 AM
I created CR 7128584: "Typo in sun.misc.VM's private directMemory field
comment", for this issue, and will push Kris' change with Remi and
myself as reviewer and listing Kris as the contributor.
Thanks,
-Chris.
On 01/10/12 08:22 AM, Rémi Forax wrote:
I think it's better if it has it's own bug
On 10/01/2012 01:05, Neil Richards wrote:
Hi all,
When proposing the change for 6312706 [1], I erroneously managed to
convince myself (and others!) that it would be safe to use 'new
Integer(0)' for java.util.EnumMap.NULL (the object used to mark null
values for entries in the map) [2].
This was
I think it's better if it has it's own bug id and changeset.
I'm sure Joe can create a bug id for it.
Rémi
On 01/10/2012 06:51 AM, Krystal Mok wrote:
Hi all,
Just found a little typo in sun.misc.VM:
diff -r 00e2c88e2234 src/share/classes/sun/misc/VM.java
--- a/src/share/classes/sun/misc/VM.ja
23 matches
Mail list logo
