Re: POSIX compatibility change for including wait.h in UNIXProcess_md.c

2012-01-12 Thread Jonathan Lu
Hello David and Alan, Thanks for the review. Do you plan to push it? Cheers - Jonathan On 01/12/2012 07:33 PM, Alan Bateman wrote: On 12/01/2012 09:35, Jonathan Lu wrote: Hi core-libs-dev, It was found that solaris/native/java/lang/UNIXProcess_md.c includes which does not seem to be compli

Re: Updated unit test for BigInteger patch (#4837946)

2012-01-12 Thread Tim Buktu
On 01/11/2012 11:59 AM, Joe Darcy wrote: > Thanks Tim. I'll add this to my review queue after Alan Eliasen's work > (finally) gets in. Sounds good. I wanted to point out that my patch includes Alan's and it applies to the latest JDK8 sources without any manual merging, so it should be less work

hg: jdk8/tl/jdk: 2 new changesets

2012-01-12 Thread valerie . peng
Changeset: ef3b6736c074 Author:valeriep Date: 2012-01-12 16:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef3b6736c074 7088989: Improve the performance for T4 by utilizing the newly provided crypto APIs Summary: Added the OracleUcrypto provider for utilizing the Solaris

hg: jdk8/tl/jdk: 7090565: Move test/closed/javax/security/auth/x500/X500Principal/Parse.java to open tests

2012-01-12 Thread weijun . wang
Changeset: 38bf1e9b6979 Author:weijun Date: 2012-01-13 09:50 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38bf1e9b6979 7090565: Move test/closed/javax/security/auth/x500/X500Principal/Parse.java to open tests Reviewed-by: mullan + test/javax/security/auth/x500/X500Princip

hg: jdk8/tl/langtools: 7123100: javac fails with java.lang.StackOverflowError

2012-01-12 Thread maurizio . cimadamore
Changeset: 133744729455 Author:mcimadamore Date: 2012-01-12 15:28 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/133744729455 7123100: javac fails with java.lang.StackOverflowError Summary: Inference of under-constrained type-variables creates erroneous recursive wildc

Re: Code review: 7126979 (props) JCK test java_lang/System/GetProperties.java failing [macosx]

2012-01-12 Thread David Holmes
On 12/01/2012 10:49 PM, Michael McMahon wrote: Thanks David. Just found it now (Alan noticed it too). Scott sent his webrev yesterday. It looks like both solutions fix the problem. The difference is that Scott's re-initializes the properties from native code each time System.initProperties() is

Re: Code review: 7126979 (props) JCK test java_lang/System/GetProperties.java failing [macosx]

2012-01-12 Thread Michael McMahon
Thanks David. Just found it now (Alan noticed it too). Scott sent his webrev yesterday. It looks like both solutions fix the problem. The difference is that Scott's re-initializes the properties from native code each time System.initProperties() is called. On the other platforms, we only call

Re: Code review: 7126979 (props) JCK test java_lang/System/GetProperties.java failing [macosx]

2012-01-12 Thread David Holmes
Michael, There was a different patch for this posted earlier today where the props fields were all nulled out so they didn't reference the freed locations amy more. (I didn't keep the email) ??? David On 12/01/2012 9:22 PM, Michael McMahon wrote: Could I get the following change for jdk7u-

hg: jdk8/tl/jdk: 7106773: 512 bits RSA key cannot work with SHA384 and SHA512

2012-01-12 Thread xuelei . fan
Changeset: 11e52d5ba64e Author:xuelei Date: 2012-01-12 03:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11e52d5ba64e 7106773: 512 bits RSA key cannot work with SHA384 and SHA512 Reviewed-by: weijun ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! src/share/classe

Re: Code review: 7126979 (props) JCK test java_lang/System/GetProperties.java failing [macosx]

2012-01-12 Thread Alan Bateman
On 12/01/2012 11:22, Michael McMahon wrote: Could I get the following change for jdk7u-osx reviewed please? http://cr.openjdk.java.net/~michaelm/7126979/webrev.1/ The freeProps() call added by mac port can only be called once. Issue seen if System.setProperties(null) is called. GetJavaProperti

Re: POSIX compatibility change for including wait.h in UNIXProcess_md.c

2012-01-12 Thread Alan Bateman
On 12/01/2012 09:35, Jonathan Lu wrote: Hi core-libs-dev, It was found that solaris/native/java/lang/UNIXProcess_md.c includes which does not seem to be compliant with POSIX specification, in which the expected header file name should be . see http://en.wikipedia.org/wiki/C_POSIX_library. I

Strange or obsolete @see tags in some exception javadoc

2012-01-12 Thread Martin Desruisseaux
Hello all Some widely-used exceptions which were defined in the old Java 1.0 days have strange or obsolete javadoc "@see" tags: http://docs.oracle.com/javase/7/docs/api/java/lang/IllegalArgumentException.html IllegalArgumentException declares "@see Thread#setPriority(int)". Why is Thread.setP

Code review: 7126979 (props) JCK test java_lang/System/GetProperties.java failing [macosx]

2012-01-12 Thread Michael McMahon
Could I get the following change for jdk7u-osx reviewed please? http://cr.openjdk.java.net/~michaelm/7126979/webrev.1/ The freeProps() call added by mac port can only be called once. Issue seen if System.setProperties(null) is called. GetJavaProperties() called a second time, which is supposed

Re: POSIX compatibility change for including wait.h in UNIXProcess_md.c

2012-01-12 Thread David Holmes
Hi Jonathon, On 12/01/2012 7:35 PM, Jonathan Lu wrote: It was found that solaris/native/java/lang/UNIXProcess_md.c includes which does not seem to be compliant with POSIX specification, in which the expected header file name should be . see http://en.wikipedia.org/wiki/C_POSIX_library. I also p

POSIX compatibility change for including wait.h in UNIXProcess_md.c

2012-01-12 Thread Jonathan Lu
Hi core-libs-dev, It was found that solaris/native/java/lang/UNIXProcess_md.c includes which does not seem to be compliant with POSIX specification, in which the expected header file name should be . see http://en.wikipedia.org/wiki/C_POSIX_library. I also performed a 'grep' for the code bas