Hi Brandon,
This point fix still bothered me so I dug a bit deeper into what the
code does (as complex and convoluted as it is). I wanted to compare the
cases of 0.0 and 1.0 to see why they differed and it seemed to me that
the difference was introduced way back when the FormattedFloatingDecim
Changeset: 7aa5ddfa3c9d
Author:okutsu
Date: 2012-01-27 14:58 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7aa5ddfa3c9d
7130335: Problem with timezone in a SimpleDateFormat
Reviewed-by: peytoia
! src/share/classes/java/text/SimpleDateFormat.java
+ test/java/text/Format/Date
Hi David. I have revised my fix for this CR. Here's a description of
the most recent changes:
1. The code fix has been moved slightly from it's original position
into a section within FormattedFloatingDecimal.java which handles
0.0* numbers.
2. The code fix no longer changes the p
Sherman, thanks for offering to investigate the performance impact, if
any, of this change.
-Joe
PS All the jar/zip regression tests pass with this change.
On 01/26/2012 09:52 AM, Xueming Shen wrote:
Joe,
The changes look fine. However I have the same performance concern in
cases that the vm
Changeset: 5ee30ab905db
Author:wetmore
Date: 2012-01-26 17:16 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ee30ab905db
7126889: Incorrect SSLEngine debug output
Reviewed-by: xuelei
! src/share/classes/sun/security/ssl/EngineArgs.java
! src/share/classes/sun/security/ssl/S
Changeset: b518b160607f
Author:lancea
Date: 2012-01-26 19:41 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b518b160607f
7133815: address the findbug errors in CachedRowSetImpl, SerialStruct,
BaseRow, SerialInputImpl, SerialOutputImpl
Reviewed-by: forax
! src/share/classes
On 01/27/2012 01:03 AM, Lance Andersen - Oracle wrote:
Hi Remi,
thanks for the additional info. Made the extra
changehttp://cr.openjdk.java.net/~lancea/7133815/webrev.02, so I hope we are
good to go now.
Best
Lance
thumb up :)
Rémi
On Jan 26, 2012, at 6:47 PM, Rémi Forax wrote:
On 01/
Hi Remi,
thanks for the additional info. Made the extra
changehttp://cr.openjdk.java.net/~lancea/7133815/webrev.02, so I hope we are
good to go now.
Best
Lance
On Jan 26, 2012, at 6:47 PM, Rémi Forax wrote:
> On 01/27/2012 12:12 AM, Lance Andersen - Oracle wrote:
>> Hi Remi,
>>
>> Thanks for
On 01/27/2012 12:12 AM, Lance Andersen - Oracle wrote:
Hi Remi,
Thanks for the feedback, I made the suggested changes
http://cr.openjdk.java.net/~lancea/7133815/webrev.01/ and re-ran the rowset tck
.
Best
Lance
Lance,
sorry to not have been crystal clear in my previous email,
I've forgott
Hi Remi,
Thanks for the feedback, I made the suggested changes
http://cr.openjdk.java.net/~lancea/7133815/webrev.01/ and re-ran the rowset tck
.
Best
Lance
On Jan 26, 2012, at 5:21 PM, Rémi Forax wrote:
> On 01/26/2012 10:46 PM, Lance Andersen - Oracle wrote:
>> Hi,
>>
>> Looking for a revi
On 01/26/2012 10:46 PM, Lance Andersen - Oracle wrote:
Hi,
Looking for a reviewer for http://cr.openjdk.java.net/~lancea/7133815/webrev.00/
this is a small change to address 2 findbug errors. The findbug issues being
addressed:
May expose internal representation by returning reference to m
Hi,
Looking for a reviewer for http://cr.openjdk.java.net/~lancea/7133815/webrev.00/
this is a small change to address 2 findbug errors. The findbug issues being
addressed:
May expose internal representation by returning reference to mutable object
and
Load of known null value
For Cache
Hello,
On 1/26/2012 9:13 AM, Ulf Zibis wrote:
Am 26.01.2012 17:11, schrieb Roger Riggs:
[snip]
Its unfortunate that between the method name and need to qualify
with the class (or use static imports) that the code is longer and
not always clearer.
+1
- static import could become ambiguou
Am 26.01.2012 17:11, schrieb Roger Riggs:
Is there any performance impact of the method call vs the &0xff?
Hotspot will in-line the code but for VMs with less sophisticated
optimizations it will be a net loss.
+1
At least in interpreter and maybe -client compiler the new code would have
perform
Changeset: 350971f50949
Author:rbackman
Date: 2012-01-26 09:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/350971f50949
7133124: Remove redundant packages from JAR command line
Reviewed-by: acorn, alanb, dholmes, rottenha
! make/common/Release.gmk
> I think we forgot to create a bug for this, I've created it now:
>
> 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than
> wait.h
>
Thanks a lot, Alan!
>
> I don't mind pushing it for you but maybe this is something that Neil
> wants to do?
>
>
Hi Neil, could you please
Changeset: ceab7e149581
Author:peytoia
Date: 2012-01-26 17:06 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ceab7e149581
7017458: (cal) Multithreaded deserialization of Calendar leads to
ClassCastException
Reviewed-by: okutsu
! src/share/classes/java/util/Calendar.java
+ t
17 matches
Mail list logo
