hg: jdk8/tl/jdk: 6879539: enable empty password support for pkcs12 keystore

2012-02-09 Thread weijun . wang
Changeset: bdd1dd1e1462 Author:weijun Date: 2012-02-10 11:41 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdd1dd1e1462 6879539: enable empty password support for pkcs12 keystore Reviewed-by: vinnie, weijun Contributed-by: Florian Weimer ! src/share/classes/com/sun/crypto/

Re: Warning Fixes from LJC Hack Session

2012-02-09 Thread Weijun Wang
Just give me anything that includes the jars not found yet. I just want to extract the hash line and cert info from them to make sure they can be removed from trusted.libraries safely. Thanks Max On 02/10/2012 11:11 AM, Stuart Marks wrote: Hi Mike, I finally got back to this. These fixes lo

Re: Warning Fixes from LJC Hack Session

2012-02-09 Thread Stuart Marks
Hi Mike, I finally got back to this. These fixes look pretty good and knock off 100+ additional warnings! I've filed bug 7143230 [1] to track this. I took a look through the code and I took the liberty of fixing up a few very minor things: 1. Removed unnecessary casts to ZipEntry in JarVerifi

RE: Codereview request for 6995537: different behavior in iso-2022-jp encoding between jdk131/140/141 and jdk142/5/6/7

2012-02-09 Thread Jason Mehrens
Sherman, My mistake, I missed the fact that flushBuffer does not flush the encoder. I incorrectly thought that write/print caused the encoder to flush and only the direct call to OSW.flush did not. Jason Date: Thu, 9 Feb 2012 11:29:04 -0800 From: xueming.s...@oracle.com To: jason_mehr.

Re: Codereview request for 6995537: different behavior in iso-2022-jp encoding between jdk131/140/141 and jdk142/5/6/7

2012-02-09 Thread Xueming Shen
Jason, I might be misunderstanding your suggestion, but the current implementation of OutputStreamWriter.flushBuffer()/StreamWriter.implFlushBuffer() does not flush the encoder, so even the caller can choose when to invoke flushBuffer(), it does not solve the problem (flush() invokes flushBuff

Re: Codereview request for 6995537: different behavior in iso-2022-jp encoding between jdk131/140/141 and jdk142/5/6/7

2012-02-09 Thread Xueming Shen
CCed Bill Shannon. On 02/09/2012 11:10 AM, Xueming Shen wrote: CharsetEncoder has the "flush()" method as the last step (of a series of "encoding" steps) to flush out any internal state to the output buffer. The issue here is the the upper level wrapper class, OutputStreamWriter in our case,

Re: Codereview request for 6995537: different behavior in iso-2022-jp encoding between jdk131/140/141 and jdk142/5/6/7

2012-02-09 Thread Xueming Shen
CharsetEncoder has the "flush()" method as the last step (of a series of "encoding" steps) to flush out any internal state to the output buffer. The issue here is the the upper level wrapper class, OutputStreamWriter in our case, doesn't provide a "explicit" mechanism to let the user to reques

RE: Codereview request for 6995537: different behavior in iso-2022-jp encoding between jdk131/140/141 and jdk142/5/6/7

2012-02-09 Thread Jason Mehrens
Sherman, As a workaround, what about allowing a write of empty string or empty char array to call flushBuffer? If you call PrintStream.print("") then flushBuffer is called on the internal writers. But if you try the same by doing OuputStreamWriter.write("") the flushbuffer call is trapped b

hg: jdk8/tl/jdk: 7144086: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java failing intermittently

2012-02-09 Thread alan . bateman
Changeset: 8326d434681d Author:alanb Date: 2012-02-09 16:38 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8326d434681d 7144086: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java failing intermittently Reviewed-by: chegar ! test/java/nio/file/WatchService/Sensit

Re: Codereview request for 6995537: different behavior in iso-2022-jp encoding between jdk131/140/141 and jdk142/5/6/7

2012-02-09 Thread Masayoshi Okutsu
First of all, is this really a Java SE bug? The usage of OutputSteamWriter in JavaMail seems to be wrong to me. The writeTo method in the bug report doesn't seem to be able to deal with any stateful encodings. Masayoshi On 2/9/2012 3:26 PM, Xueming Shen wrote: Hi This is a long standing "re