Great, I've pushed in the remaining changes:
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/445ada5e6b4a
I hope these patches are providing value for the OpenJDK team as we
plan to do more. I know that there is a bit of a cost for you guys
in terms of reviewing and merging. I'm starting to get a
Changeset: 237198ef45f5
Author:jjh
Date: 2012-02-13 16:01 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/237198ef45f5
7142672: Problems with the value passed to the 'classes' param of
JavaCompiler.CompilationTask.getTask(...)
Reviewed-by: jjg
! src/share/classes/com/s
Am 14.02.2012 00:41, schrieb Jeff Hain:
(I don't really like the term "exact", which supposes modulo arithmetic is
not exact in its kind, and it doesn't contain the supposition that the result should be
in range.)
+1
-Ulf
Hello.
- It could be great to have versions of these methods that don't throw an
ArithmeticException in case of overflow, but would return the closest value
(XXX.MAX_VALUE or XXX.MIN_VALUE).
A common use-case I see (and have) for this is when dealing with dates and
durations (*), in which cas
On 2/13/2012 11:07 AM, Bill Shannon wrote:
Can you detect the case of creating an InputStreamReader using the
default encoding, wrapped around the InputStream from System.in
that refers to the console? If so, it might be good to handle that
case as well, although at this point I would conside
Sherman,
thanks for your additional explanation.
One nit more...
Why you use the "sun." prefix? I think,
"stdout.encoding"
"stderr.encoding"
would be enough + nicer. In some years, nobody will have any association with
'sun'.
On the other hand, it would be more true to use:
"windows
On 2/13/2012 11:07 AM, Bill Shannon wrote:
Thanks for fixing this!
The webrev is at
http://cr.openjdk.java.net/~sherman/4153167/webrev
You probably don't need to malloc 64 bytes for a string that's
going to be less than 16 bytes. And shouldn't you use snprintf
in any event?
Unlike Unix,
To have separate sun.stdout.encoding and sun.stderr.encoding is mainly
because of implementation
convenience. I need three things from the native (1) is std.out tty (2)
is std.err tty (3) the console
encoding if (1) or (2) are true, and I tried to avoid to go down to
native multiple times it a
Thanks for the raising the question on the blog and the comments.
I see support based only on general principles and not from use cases
where the function would be essential. At this point, we're not trying to
provide a complete set of exact arithmetic functions but to cover the cases
where deve
Am 13.02.2012 19:35, schrieb Xueming Shen:
On 2/13/2012 10:15 AM, Ulf Zibis wrote:
Interesting issue, especially for us germans!
What is about System.in, if one types some umlaute at Windows console?
System.in is a "InputStream", no charset involved there, you build your own
"reader"
on to
On 2/13/2012 10:15 AM, Ulf Zibis wrote:
Interesting issue, especially for us germans!
What is about System.in, if one types some umlaute at Windows console?
System.in is a "InputStream", no charset involved there, you build
your own "reader"
on top of that yourself.
Why are there theo
Interesting issue, especially for us germans!
What is about System.in, if one types some umlaute at Windows console?
Why are there theoretically different code pages for stdout and stderr?
-Ulf
Am 13.02.2012 18:36, schrieb Xueming Shen:
Hi
This is a long standing Windows codepage support is
On 11 February 2012 17:31, Roger Riggs wrote:
> Updated the webrev for CR6708398:
> http://cr.openjdk.java.net/~rriggs/6708398.2
> - Added a paragraph to the class javadoc for Math and StrictMath to
> introduce the exact arithmetic methods and their uses.
> - Editorial correction to fi
Changeset: cd5ca700da4c
Author:jjg
Date: 2012-02-12 16:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd5ca700da4c
7144979: incorrect path separator in make/build.xml for Windows when running
jtreg tests
Reviewed-by: jjg
Contributed-by: jan.vale...@oracle.com
! mak
Hi
This is a long standing Windows codepage support issue on Java platform
(we probably have
20 bug/rfes filed for this particular issue and closed as the dup of
4153167). Windows supports
two sets of codepages, ANSI (Windows) codepage and OEM (IBM) codepage.
Windows uses
ANSI/Windows codepa
Updated the webrev for CR6708398:
http://cr.openjdk.java.net/~rriggs/6708398.2
- Added a paragraph to the class javadoc for Math and StrictMath to
introduce the exact arithmetic methods and their uses.
- Editorial correction to first sentence of each method to consistent
use "Return
On 10/02/2012 13:09, Alex Lam S.L. wrote:
Hi there,
I have some code which calls FilterOutputStream.close(), which calls
the underlying OutputStream.flush() which throws IOException.
With previous versions of JavaSE, close() returns successfully without
any problems.
Using JDK8-b24, I get an I
Changeset: 184b9cb4f13a
Author:alanb
Date: 2012-02-09 13:43 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/184b9cb4f13a
7114611: (fs) DirectoryStream fails with SIGBUS on some embedded platforms,
dirent alignment
Reviewed-by: dholmes, alanb
Contributed-by: carlos.lucas...@or
x == Integer.MIN_VALUE should be faster than x == -x as it's a cmp against
a constant whereas the latter requires negating x (that's a dependency
too), tying up a register to store the negation, and then doing the cmp.
Sent from my phone
On Feb 3, 2012 12:53 PM, "Eamonn McManus" wrote:
> My init
Changeset: ce5ffdb2be25
Author:alanb
Date: 2012-02-05 12:29 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce5ffdb2be25
7140918: Remove dependency on apt and com.sun.mirror API
Reviewed-by: darcy
Contributed-by: miroslav@oracle.com, martin.gre...@oracle.com
! make/common
Hacker's Delight gives a formula equivalent to this one on page 27:
((x ^ r) & (y ^ r)) < 0
Having said that, I think Florian's assertion that such a rewrite will be
faster needs proof. In the original form...
(x ^ r) < 0 && (x ^ y) >= 0
...the first condition will be false half the time for ra
Thanks Tom.
Joe
On 2/13/2012 8:54 AM, Tom Hawtin wrote:
Looks good to me.
Tom
On 08/02/2012 22:13, Joe Wang wrote:
Hi,
The 7053556 patch added a (Oracle) implementation-only feature to allow
users to skip the plugability layer. In the same patch, there was also a
change that in secure mode,
Someone in the core-libs team should look at fixing this trivial javadoc
warning.
The replacement should presumably be {@code httpServerProvider}
-- Jon
# Packages (httpserver.packages):
# com.sun.net.httpserver
# com.sun.net.httpserver.spi
/opt/jdk/1.7.0/bin/java -XX:-PrintVMOptions
-X
Looks good to me.
Tom
On 08/02/2012 22:13, Joe Wang wrote:
Hi,
The 7053556 patch added a (Oracle) implementation-only feature to allow
users to skip the plugability layer. In the same patch, there was also a
change that in secure mode, dependent components should be loaded in a
hardwired mode.
Changeset: 3554f175341a
Author:vinnie
Date: 2012-02-13 14:26 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3554f175341a
7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when
timestamping is not done
Reviewed-by: xuelei, wetmore
! src/share/classes
Thanks for reporting this Jon.
I filed CR 7145043: "HttpServerProvider.java:81: warning -
@code("httpServerProvider") is an unknown tag"
You see quite a few of these type of RuntimePermission links through out
the core area. The intent is to link to RuntimePermission and show the
appropriate
26 matches
Mail list logo
