fd needs to be closed when fstat or malloc failed?
Thanks,
Masayoshi
On 3/13/2012 12:22 AM, Alan Bateman wrote:
On 12/03/2012 15:11, Seán Coffey wrote:
Yes - good catch. I hadn't tested the sym link being a relative path.
We should always open whatever is pointed to from
DEFAULT_ZONEINFO_FILE
On 13/03/2012 5:08 AM, Jason Mehrens wrote:
I'm not really confident about proposing "assertions as lint detection" rather than
adding explicit checks. We wouldn't (and don't) use optional assertions for array bounds
checking. This has clearly been the right choice. I'm still considering my>>
>>I'm not really confident about proposing "assertions as lint detection"
>>rather than adding explicit checks. We wouldn't (and don't) use optional
>>assertions for array bounds checking. This has clearly been the right choice.
>>I'm still considering my >>feelings about whether to be hardline
On 12/03/2012 11:34, Rémi Forax wrote:
Hi Sean,
the classpath attribute key in a Manifest is 'Class-Path' with a big 'P',
so the test run but I'm not sure it tests what it should.
Rémi
Attribute names are case insensitive so it shouldn't case a problem, but
I agree it would have been nicer to
On 12/03/2012 15:11, Seán Coffey wrote:
Yes - good catch. I hadn't tested the sym link being a relative path.
We should always open whatever is pointed to from
DEFAULT_ZONEINFO_FILE. This simplifies the code. Tested and looks good.
I assume this is the latest:
http://cr.openjdk.java.net/~coff
Yes - good catch. I hadn't tested the sym link being a relative path. We
should always open whatever is pointed to from DEFAULT_ZONEINFO_FILE.
This simplifies the code. Tested and looks good.
regards,
Sean.
On 12/03/12 14:34, Alan Bateman wrote:
On 12/03/2012 14:31, Seán Coffey wrote:
Ok - g
On 12/03/2012 14:31, Seán Coffey wrote:
Ok - good point on the stat change Alan. I think this is what you're
after :
http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.2/
At L295 then I assume itshould open DEFAULT_ZONEINFO_FILE, otherwise if
the sym link is a relative path then it would
Ok - good point on the stat change Alan. I think this is what you're after :
http://cr.openjdk.java.net/~coffeys/webrev.7149608.jdk8.2/
regards,
Sean.
On 12/03/12 11:04, Alan Bateman wrote:
On 09/03/2012 16:00, Seán Coffey wrote:
Issue seen on somewhat irregular linux system configuration wher
On 03/12/2012 11:27 AM, Alan Bateman wrote:
On 12/03/2012 09:28, Seán Coffey wrote:
Alan,
I did (briefly) look into using the java.util.jar API but wasn't
seeing the bug being triggered. Decided to use the jar process
command as an alternative.
The testcase was a port from JDK 6 and didn't
Changeset: 134d9f4f9498
Author:coffeys
Date: 2012-03-12 11:30 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134d9f4f9498
7148584: Jar tools fails to generate manifest correctly when boundary condition
hit
Reviewed-by: alanb, sherman
! src/share/classes/java/util/jar/Manife
On 09/03/2012 16:00, Seán Coffey wrote:
Issue seen on somewhat irregular linux system configuration where
/etc/localtime is a symbolic link to a directory outside of
/usr/share/zoneinfo.
In past, when a symbolic link was seen, the end target file was
assumed to be under /usr/share/zoneinfo an
On 12/03/2012 09:28, Seán Coffey wrote:
Alan,
I did (briefly) look into using the java.util.jar API but wasn't
seeing the bug being triggered. Decided to use the jar process command
as an alternative.
The testcase was a port from JDK 6 and didn't contain JDK 7+ features.
I've converted it n
Changeset: 6d934b1d9dd5
Author:alanb
Date: 2012-03-12 10:17 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d934b1d9dd5
7152866: Tests not run because they are missing the @run tag
Reviewed-by: chegar, dholmes
! test/ProblemList.txt
- test/java/io/File/isDirectory/Applet.htm
On 12/03/2012 09:42, Alan Bateman wrote:
On 11/03/2012 22:38, David Holmes wrote:
Thanks Chris. I hadn't realized that @build, @clean etc were shorthand
for @run build, @run clean etc. I would have assumed there was an
implicit @run main (or whatever) in all those cases. :(
Yes, @build, @clean
On 11/03/2012 22:38, David Holmes wrote:
Thanks Chris. I hadn't realized that @build, @clean etc were shorthand
for @run build, @run clean etc. I would have assumed there was an
implicit @run main (or whatever) in all those cases. :(
Yes, @build, @clean, @compile are just short hand. For simpl
Alan,
I did (briefly) look into using the java.util.jar API but wasn't seeing
the bug being triggered. Decided to use the jar process command as an
alternative.
The testcase was a port from JDK 6 and didn't contain JDK 7+ features.
I've converted it now though. Hope it's cleaner.
http://cr.
16 matches
Mail list logo
