Re: RFR: 7155300 Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-03-20 Thread Alan Bateman
On 21/03/2012 02:47, Shi Jun Zhang wrote: Hi Alan/David, There is no response on this thread for long time. I created a sun bug 7155300, could you help to review it? The webrev link is http://cr.openjdk.java.net/~zhangshj/pthread/webrev.02/ Looks okay to me. -Alan

Re: RFR (7u4) 7150637: No newline emitted after XML decl in XSLT output

2012-03-20 Thread Joe Wang
Thanks Lance! On 3/20/2012 2:44 PM, Lance Andersen - Oracle wrote: Hi Joe, This looks Ok, a couple of minor comments: - SerializationHandler.java could use a comment before the method setIsStandalone(). Added the following comment: /** * Specify if the output will be treated as a s

Re: RFR: 7155300 Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-03-20 Thread Shi Jun Zhang
On 3/12/2012 11:28 AM, Shi Jun Zhang wrote: On 3/9/2012 6:05 PM, David Holmes wrote: On 9/03/2012 7:04 PM, Alan Bateman wrote: On 09/03/2012 08:01, Shi Jun Zhang wrote: The situation in NativeThread.c is more complicated than other 2 files. I'm not familiar with BSD or Mac. It seems that we do

hg: jdk8/tl/jdk: 7146728: Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11

2012-03-20 Thread valerie . peng
Changeset: 4c4d2337dfad Author:valeriep Date: 2012-03-20 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c4d2337dfad 7146728: Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11 Summary: Always return the secret in the same l

Re: RFR (7u4) 7150637: No newline emitted after XML decl in XSLT output

2012-03-20 Thread Lance Andersen - Oracle
Hi Joe, This looks Ok, a couple of minor comments: - SerializationHandler.java could use a comment before the method setIsStandalone(). - ToXMLStream.java seems to have a typo in the comment /** 331 * Before Xalan 1497, a newline char was printed out if not inside of an 3

Re: No replaceLast() method in String

2012-03-20 Thread Mike Duigou
I took a look through the bug database and can't find a reason (if there was one). It's likely not implemented because Matcher doesn't implement replaceLast(). Mike On Mar 20 2012, at 09:28 , Alex Kravets wrote: > Hi, > > I was looking at String API and noticed that there are methods for stri

RFR (7u4) 7150637: No newline emitted after XML decl in XSLT output

2012-03-20 Thread Joe Wang
Hi, This is an issue introduced by an Apache update that although technically correct, was nonetheless an incompatible change. As reported in the CR, it caused NetBeans test failures and spurious reformatting of project metadata of users' projects that the version control tool would take as i

hg: jdk8/tl/jdk: 7154114: jstat tests failing on non-english locales; ...

2012-03-20 Thread staffan . larsen
Changeset: 2dc35f14bf17 Author:sla Date: 2012-03-20 12:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2dc35f14bf17 7154114: jstat tests failing on non-english locales 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system Reviewed-b

hg: jdk8/tl/jdk: 7152176: More krb5 tests

2012-03-20 Thread weijun . wang
Changeset: 0d1c576980a0 Author:weijun Date: 2012-03-20 19:12 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d1c576980a0 7152176: More krb5 tests Reviewed-by: xuelei + test/sun/security/krb5/auto/Basic.java ! test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/