Re: RFR: 7155300 Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-03-21 Thread Shi Jun Zhang
On 3/22/2012 12:36 PM, Charles Lee wrote: On 03/21/2012 10:47 AM, Shi Jun Zhang wrote: On 3/12/2012 11:28 AM, Shi Jun Zhang wrote: On 3/9/2012 6:05 PM, David Holmes wrote: On 9/03/2012 7:04 PM, Alan Bateman wrote: On 09/03/2012 08:01, Shi Jun Zhang wrote: The situation in NativeThread.c is m

Re: RFR: 7155300 Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-03-21 Thread Charles Lee
On 03/21/2012 10:47 AM, Shi Jun Zhang wrote: On 3/12/2012 11:28 AM, Shi Jun Zhang wrote: On 3/9/2012 6:05 PM, David Holmes wrote: On 9/03/2012 7:04 PM, Alan Bateman wrote: On 09/03/2012 08:01, Shi Jun Zhang wrote: The situation in NativeThread.c is more complicated than other 2 files. I'm not

hg: jdk8/tl/jdk: 7155300: Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-03-21 Thread littlee
Changeset: 1d418ec212ea Author:zhangshj Date: 2012-03-22 12:30 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d418ec212ea 7155300: Include pthread.h on all POSIX platforms except Solaris to improve portability Reviewed-by: alanb, dholmes ! src/solaris/bin/java_md.c ! src/s

Re: hg: jdk8/tl/jdk: 7145454: JVM wide monitor lock in Currency.getInstance(String)

2012-03-21 Thread David Holmes
Hi, I'm sorry I missed the review of this change. The following is somewhat inefficient: instance = instances.putIfAbsent(currencyCode, new Currency(currencyCode, defaultFractionDigits, numericCode)); return (instance != null ? instance : instances.get(currencyCode));

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-21 Thread Ulf Zibis
Am 19.03.2012 05:53, schrieb Sean Chou: Hi Ulf, I hope following comments can help reduce your concern. I don't think this footprint is a problem until it is proved to be one. If it is, a better javac can be used to save this footprint, and it would save much more. The actual problem might

hg: jdk8/tl/jdk: 7110104: It should be possible to stop and start JMX Agent at runtime

2012-03-21 Thread dmitriy . samersoff
Changeset: 1e737abbff6f Author:dsamersoff Date: 2012-02-27 15:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e737abbff6f 7110104: It should be possible to stop and start JMX Agent at runtime Summary: Added a capability to start and stop JMX Agent by jcmd Reviewed-by: acor

java.util.zip.Deflater: needsInput() returns true after finish()

2012-03-21 Thread Zhong Yu
In java.util.zip.Deflater, after finish() is called, needsInput() may still return true. This is counter-intuitive. It's probably not an issue in blocking style IO, since state is implied by context, code (lexically) after finish() knows it doesn't make sense to call needsInput(). In non-blocking

hg: jdk8/tl/jdk: 7149181: sun/management/jmxremote/startstop/JMXStartStopTest.sh failing on all platforms

2012-03-21 Thread dmitriy . samersoff
Changeset: c0a5140c641c Author:dsamersoff Date: 2012-02-28 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0a5140c641c 7149181: sun/management/jmxremote/startstop/JMXStartStopTest.sh failing on all platforms Summary: Disable test until JDK and hotspot changes meet each

hg: jdk8/tl/langtools: 7150579: Moved ant code into a separate package, anttasks.

2012-03-21 Thread fredrik . ohrstrom
Changeset: 7245999a0075 Author:ohrstrom Date: 2012-03-07 13:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7245999a0075 7150579: Moved ant code into a separate package, anttasks. Summary: To allow langtools to be built without ant, the ant tasks were moved to a sepa

Re: No replaceLast() method in String

2012-03-21 Thread Alex Kravets
So the next question is why Matcher doesn't implement it :) On Mar 20, 2012 2:35 PM, "Mike Duigou" wrote: > I took a look through the bug database and can't find a reason (if there > was one). It's likely not implemented because Matcher doesn't implement > replaceLast(). > > Mike > > On Mar 20 20

hg: jdk8/tl/jdk: 7145454: JVM wide monitor lock in Currency.getInstance(String)

2012-03-21 Thread naoto . sato
Changeset: 4a5817f9e249 Author:naoto Date: 2012-03-21 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a5817f9e249 7145454: JVM wide monitor lock in Currency.getInstance(String) Reviewed-by: okutsu ! src/share/classes/java/util/Currency.java

Re: RFR (7u4) 7150637: No newline emitted after XML decl in XSLT output

2012-03-21 Thread Joe Wang
Thanks for the quick review! Now, if only I can get the approval today, I can actually catch the code freeze... :) --Joe On 3/21/2012 5:26 AM, Lance Andersen - Oracle wrote: Thank you Joe, good to go from my perspective. Best Lance On Mar 20, 2012, at 11:36 PM, Joe Wang wrote: Thanks Lan

Re: RFR (7u4) 7150637: No newline emitted after XML decl in XSLT output

2012-03-21 Thread Lance Andersen - Oracle
Thank you Joe, good to go from my perspective. Best Lance On Mar 20, 2012, at 11:36 PM, Joe Wang wrote: > Thanks Lance! > > On 3/20/2012 2:44 PM, Lance Andersen - Oracle wrote: >> Hi Joe, >> >> This looks Ok, a couple of minor comments: >> >> - SerializationHandler.java could use a comment be

Re: RFR: 7155300 Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-03-21 Thread David Holmes
On 21/03/2012 2:30 PM, Alan Bateman wrote: On 21/03/2012 02:47, Shi Jun Zhang wrote: Hi Alan/David, There is no response on this thread for long time. I created a sun bug 7155300, could you help to review it? The webrev link is http://cr.openjdk.java.net/~zhangshj/pthread/webrev.02/ Looks o