Re: RFR 6963841: java/util/concurrent/Phaser/Basic.java fails intermittently

2012-03-27 Thread Chris Hegarty
On 27/03/12 05:21, David Holmes wrote: Hi Chris, On 27/03/2012 1:04 PM, Chris Hegarty wrote: David, Doug, This test has been failing intermittently on jdk7u-dev and jdk8 for a while now. It only appears to fail when run in our internal build/test system (JPRT). I believe the cause of the

Re: RFR 6963841: java/util/concurrent/Phaser/Basic.java fails intermittently

2012-03-27 Thread Alan Bateman
On 27/03/2012 05:21, David Holmes wrote: It's a little disconcerting that 10 seconds is not enough time, but we have so many timing issues these days it is not that surprising. :( The machines in question are relatively beefy but there is hardware visualization in the picture that may be an

Re: RFR 6963841: java/util/concurrent/Phaser/Basic.java fails intermittently

2012-03-27 Thread Doug Lea
On 03/26/12 23:04, Chris Hegarty wrote: David, Doug, This test has been failing intermittently on jdk7u-dev and jdk8 for a while now. It only appears to fail when run in our internal build/test system (JPRT). I believe the cause of the failure to be simply that the machines the test is run on

Re: RFR 6963841: java/util/concurrent/Phaser/Basic.java fails intermittently

2012-03-27 Thread Chris Hegarty
On 27/03/2012 10:26, Alan Bateman wrote: On 27/03/2012 05:21, David Holmes wrote: It's a little disconcerting that 10 seconds is not enough time, but we have so many timing issues these days it is not that surprising. :( The machines in question are relatively beefy but there is hardware

Re: RFR 6963841: java/util/concurrent/Phaser/Basic.java fails intermittently

2012-03-27 Thread Chris Hegarty
On 27/03/2012 11:58, Doug Lea wrote: On 03/26/12 23:04, Chris Hegarty wrote: . OK. I synced with our version. As always, it is too bad that there is no way to operationalize the notion of for some timeout value appropriate for the platform, no TimeoutExceptions occur. Thanks for pushing

hg: jdk8/tl/jdk: 7156000: Change makefile to reflect refactored classes

2012-03-27 Thread nils . loodin
Changeset: 7e7d55e20754 Author:nloodin Date: 2012-03-23 11:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7e7d55e20754 7156000: Change makefile to reflect refactored classes Reviewed-by: dholmes ! make/common/Release.gmk

RFR: 7134701 [macosx] Support legacy native library names

2012-03-27 Thread Michael McMahon
JDK 8 fix for this issue. For readers not familiar with Mac OS, this is to fix an issue which Apple's JDK 6 supports, but we broke in the jdk 7 initial port. The preferred native library file suffix is .dylib on Mac, but some legacy libraries use the suffix .jnilib. Currently openjdk on mac

Re: RFR: 7134701 [macosx] Support legacy native library names

2012-03-27 Thread Alan Bateman
On 27/03/2012 15:05, Michael McMahon wrote: JDK 8 fix for this issue. For readers not familiar with Mac OS, this is to fix an issue which Apple's JDK 6 supports, but we broke in the jdk 7 initial port. The preferred native library file suffix is .dylib on Mac, but some legacy libraries use the

Re: RFR: 7134701 [macosx] Support legacy native library names

2012-03-27 Thread Daniel D. Daugherty
On 3/27/12 8:05 AM, Michael McMahon wrote: JDK 8 fix for this issue. For readers not familiar with Mac OS, this is to fix an issue which Apple's JDK 6 supports, but we broke in the jdk 7 initial port. The preferred native library file suffix is .dylib on Mac, but some legacy libraries use the

Re: RFR 6963841: java/util/concurrent/Phaser/Basic.java fails intermittently

2012-03-27 Thread Kelly O'Hair
On Mar 27, 2012, at 2:26 AM, Alan Bateman wrote: On 27/03/2012 05:21, David Holmes wrote: It's a little disconcerting that 10 seconds is not enough time, but we have so many timing issues these days it is not that surprising. :( The machines in question are relatively beefy but there is

hg: jdk8/tl/jdk: 7156459: Remove unnecessary get() from Currency.getInstance()

2012-03-27 Thread naoto . sato
Changeset: b15db7ded589 Author:naoto Date: 2012-03-27 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b15db7ded589 7156459: Remove unnecessary get() from Currency.getInstance() Reviewed-by: chegar, dholmes, mduigou ! src/share/classes/java/util/Currency.java

Re: RFR: 7134701 [macosx] Support legacy native library names

2012-03-27 Thread Michael McMahon
On 27/03/12 16:03, Daniel D. Daugherty wrote: On 3/27/12 8:05 AM, Michael McMahon wrote: JDK 8 fix for this issue. For readers not familiar with Mac OS, this is to fix an issue which Apple's JDK 6 supports, but we broke in the jdk 7 initial port. The preferred native library file suffix is

Re: RFR: 7134701 [macosx] Support legacy native library names

2012-03-27 Thread Daniel D. Daugherty
On 3/27/12 12:46 PM, Michael McMahon wrote: On 27/03/12 16:03, Daniel D. Daugherty wrote: On 3/27/12 8:05 AM, Michael McMahon wrote: JDK 8 fix for this issue. For readers not familiar with Mac OS, this is to fix an issue which Apple's JDK 6 supports, but we broke in the jdk 7 initial port.

hg: jdk8/tl/jdk: 7134701: [macosx] Support legacy native library names

2012-03-27 Thread michael . x . mcmahon
Changeset: 396533b75ea0 Author:michaelm Date: 2012-03-27 21:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/396533b75ea0 7134701: [macosx] Support legacy native library names Reviewed-by: alanb, dcubed ! make/java/java/FILES_java.gmk +

RFR: 7134701 [macosx] Support legacy native library names

2012-03-27 Thread Michael McMahon
Could I get the following webrev for 7u4 reviewed please? It is the same code change as for jdk 8 http://cr.openjdk.java.net/~michaelm/7134701/webrev.7u4.1/ Thanks, Michael.

Re: RFR: 7134701 [macosx] Support legacy native library names

2012-03-27 Thread Daniel D. Daugherty
On 3/27/12 3:23 PM, Michael McMahon wrote: Could I get the following webrev for 7u4 reviewed please? It is the same code change as for jdk 8 http://cr.openjdk.java.net/~michaelm/7134701/webrev.7u4.1/ Thanks, Michael. Thumbs up. Dan make/java/java/FILES_java.gmk

Re: RFR: 7134701 [macosx] Support legacy native library names

2012-03-27 Thread David Holmes
The change to look for the alternate library name looks good to me. I'm happy to see this handled in this way. I can't comment on whether there are any other cases where the alternate name should be considered. David On 28/03/2012 12:05 AM, Michael McMahon wrote: JDK 8 fix for this issue.

Re: RFR: 7134701 [macosx] Support legacy native library names

2012-03-27 Thread Scott Kovatch
With this patch in place I can load the applet at Runescape.com now. I can't log in yet due to an AWT bug I probably haven't patched yet, but this is better than what it was. Minecraft.net is still giving me problems because it's bailing out before this change takes place. Here's the method

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-27 Thread Ulf Zibis
Hi Sean, Am 26.03.2012 07:02, schrieb Sean Chou: On Sat, Mar 24, 2012 at 5:09 AM, Ulf Zibis ulf.zi...@gmx.de mailto:ulf.zi...@gmx.de wrote: Will you please provide a jtreg style testcase with main method ? Well, as I'm missing your agreement, that David's test implementation

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-03-27 Thread David Holmes
Hi Ulf, I understand your point about ensuring we test AbstractCollection.toArray but I find this revised test much harder to understand. Also in the name setPseudoConcurrentSizeCourse the word Course doesn't fit. I'm not sure what you were meaning here? Perhaps just modifySize or