Changeset: 00572399d39d
Author:ksrini
Date: 2012-03-30 17:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/00572399d39d
7158090: (launcher) newly added ToolsOpts.java fails on openjdk builds
Reviewed-by: darcy
! test/tools/launcher/ToolsOpts.java
On Mar 28, 2012, at 5:42 PM, Vitaly Davidovich wrote:
> I think you can use diamond generic inference when declaring the weak intern
> set
>
Done; thanks.
> Also any reason you didn't use WeakHashMap directly with dummy value to
> simulate the set? Or wrap the WeakHashMap and synchronize the acc
On Mar 28, 2012, at 7:50 PM, David Holmes wrote:
> One query I have is whether, given its intended usage, this change might add
> pressure to the reference processing subsystem?
Not undue pressure, I hope. JSR 292 applications tend to converge rapidly on
the number of distinct MethodTypes they
Changeset: 7a7dcbbd610f
Author:wetmore
Date: 2012-03-30 15:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a7dcbbd610f
7142172: Custom TrustManagers that return null for getAcceptedIssuers will NPE
Reviewed-by: xuelei
! src/share/classes/sun/security/ssl/SSLContextImpl.ja
Oops, yes, there is a bug in my code:
FIXED_SIZE can't be reused for multiple instances of TestCollection, so it must
not be static.
Correction:
public class TestCollection extends AbstractCollection {
private final E[] elements;
private final int[] fixedSize;
private int[] sizes;
Am 30.03.2012 19:38, schrieb Brian Goetz:
Similarly class Infrastructure could be reused over all JDK's tests. But
personnally I would prefer to more and more use the JUnit framework. Is
there already an existing example?
There's good news on this front. We are in the process of making TestNG
Changeset: 379bc17d9a26
Author:mcimadamore
Date: 2012-03-30 19:19 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/379bc17d9a26
7157688: Regression: common compiler diagnostic features swapped required/found
types
Summary: bug in resource key in compiler.properties
Revie
On 03/30/2012 07:38 PM, Brian Goetz wrote:
Similarly class Infrastructure could be reused over all JDK's tests. But
personnally I would prefer to more and more use the JUnit framework. Is
there already an existing example?
There's good news on this front. We are in the process of making
TestN
Similarly class Infrastructure could be reused over all JDK's tests. But
personnally I would prefer to more and more use the JUnit framework. Is
there already an existing example?
There's good news on this front. We are in the process of making TestNG
a supported test framework for writing uni
Thanks!
On 3/30/2012 5:41 AM, Lance Andersen - Oracle wrote:
Hi Joe,
Looks fine
-lance
On Mar 30, 2012, at 3:24 AM, Joe Wang wrote:
Hi,
This is a one line fix: adding a return statement as suggested in the
bug report to guard against null value of the name parameter.
webrev: http://cr.op
Approved,
-Joe
On 3/30/2012 9:59 AM, Kumar Srinivasan wrote:
Hi,
Please review this simple fix, the check for "openjdk version" was missed
for openjdk builds, here is the correction:
http://cr.openjdk.java.net/~ksrini/7158090/
Thanks
Kumar
Hi,
Please review this simple fix, the check for "openjdk version" was missed
for openjdk builds, here is the correction:
http://cr.openjdk.java.net/~ksrini/7158090/
Thanks
Kumar
Changeset: 45177d830325
Author:ksrini
Date: 2012-03-29 17:49 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45177d830325
7156976: improve java tools testing
Reviewed-by: darcy
Contributed-by: steve.si...@oracle.com
! test/tools/launcher/TestHelper.java
+ test/tools/launcher/
Hi Joe,
Looks fine
-lance
On Mar 30, 2012, at 3:24 AM, Joe Wang wrote:
> Hi,
>
> This is a one line fix: adding a return statement as suggested in the bug
> report to guard against null value of the name parameter.
>
> webrev: http://cr.openjdk.java.net/~joehw/7u6/cr7151484/webrev/
>
> Pleas
Sorry guys, I think I found the actual cause for this failure. Though I
think the increased defensive timeouts are still a good idea.
There is a race in the test itself. The "One thread interrupted" test
tries to interrupt a thread blocked in awaitAdvanceInterruptibly, but
how do we know the t
Hi Ulf,
While try the ToArray.java testcase, I got the following output with
jdk1.7.0_01:
java.lang.Exception: Stack trace
at java.lang.Thread.dumpStack(Thread.java:1342)
at InfraStructure.fail(InfraStructure.java:9)
at InfraStructure.check(InfraStructure.java:12)
Hi,
This is a one line fix: adding a return statement as suggested in the
bug report to guard against null value of the name parameter.
webrev: http://cr.openjdk.java.net/~joehw/7u6/cr7151484/webrev/
Please review.
Thanks,
Joe
Hi Kurchi,
I've re-reviewed the file you merged, it's Ok for me.
Rémi
On 03/30/2012 02:15 AM, Kurchi Hazra wrote:
Hi,
These changes cleanup warnings in java.util.* and were contributed
by Remi Forax (fo...@univ-mlv.fr).
Specifically the files that I merged/had conflicts are:
src/share/
18 matches
Mail list logo
